[jira] [Commented] (OOZIE-1989) NPE during a rerun with forks

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119060#comment-14119060 ] 

Hadoop QA commented on OOZIE-1989:
----------------------------------

Testing JIRA OOZIE-1989

Cleaning local git workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 132
.    {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:red}-1 COMPILE{color}
.    {color:red}-1{color} HEAD does not compile
.    {color:red}-1{color} patch does not compile
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color} - patch does not compile, cannot run testcases
{color:red}-1 DISTRO{color}
.    {color:red}-1{color} distro tarball fails with the patch

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/1821/

> NPE during a rerun with forks
> -----------------------------
>
>                 Key: OOZIE-1989
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1989
>             Project: Oozie
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 4.1.0
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>            Priority: Blocker
>             Fix For: 4.1.0
>
>         Attachments: OOZIE-1989.patch
>
>
> OOZIE-1879 fixes a problem where the order of actions that the actions in a fork ended can be different than when they are executed during a rerun, resulting in an error.  It does this by using a comparator to sort them into the proper order in LiteWorkflowInstance.  However, the code assumes that all actions in the executionPath have an end time, which is not always true.  If that happens, you get an NPE like this:
> {noformat}
> java.lang.NullPointerException
>         at org.apache.oozie.workflow.lite.LiteWorkflowInstance$ActionEndTimesComparator.compare(LiteWorkflowInstance.java:739)
>         at org.apache.oozie.workflow.lite.LiteWorkflowInstance$ActionEndTimesComparator.compare(LiteWorkflowInstance.java:719)
>         at java.util.TimSort.countRunAndMakeAscending(TimSort.java:324)
>         at java.util.TimSort.sort(TimSort.java:189)
>         at java.util.TimSort.sort(TimSort.java:173)
>         at java.util.Arrays.sort(Arrays.java:659)
>         at java.util.Collections.sort(Collections.java:217)
>         at org.apache.oozie.workflow.lite.LiteWorkflowInstance.signal(LiteWorkflowInstance.java:316)
>         at org.apache.oozie.command.wf.SignalXCommand.execute(SignalXCommand.java:190)
>         at org.apache.oozie.command.wf.SignalXCommand.execute(SignalXCommand.java:73)
>         at org.apache.oozie.command.XCommand.call(XCommand.java:283)
>         at org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:323)
>         at org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:252)
>         at org.apache.oozie.service.CallableQueueService$CallableWrapper.run(CallableQueueService.java:174)
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
>         at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)