You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "sid-srini (via GitHub)" <gi...@apache.org> on 2026/03/10 15:40:24 UTC
[PR] Updating commons-lang3 and testng dependencies [netbeans]
sid-srini opened a new pull request, #9254:
URL: https://github.com/apache/netbeans/pull/9254
Updated the following third-party dependency modules:
1. apache commons lang3: from 3.17.0 to 3.19.0
2. testng: from 6.14.3 to 7.11.0
---
**^Add meaningful description above**
<details open>
<summary>Click to collapse/expand PR instructions</summary>
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
### PR approval and merge checklist:
1. [ ] Was this PR [correctly labeled](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240884239#PRsandYouAreviewerGuide-PRtriggeredCIJobs(conditionalCIpipeline)), did the right tests run? When did they run?
3. [ ] Is this PR [squashed](https://cwiki.apache.org/confluence/display/NETBEANS/git%3A+squash+and+merge)?
4. [ ] Are author name / email address correct? Are [co-authors](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line) correctly listed? Do the commit messages need updates?
3. [ ] Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?
If this PR targets the delivery branch: [don't merge](https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery). ([full wiki article](https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide))
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Updating commons-lang3 and testng dependencies [netbeans]
Posted by "sid-srini (via GitHub)" <gi...@apache.org>.
sid-srini commented on PR #9254:
URL: https://github.com/apache/netbeans/pull/9254#issuecomment-4487950890
Hi @mbien. I've rebased the commit to the current master which includes the post NB30 updates. Please re-trigger the CI checks and review the PR. Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Updating commons-lang3 and testng dependencies [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #9254:
URL: https://github.com/apache/netbeans/pull/9254#issuecomment-4039110392
I don't have much experience in the TestNG area so I looked at the classpath changes. TestNGs classpath change looked a bit scary at first but it might be optional deps.
lang3 looks fine:
```
$ mvn eu.maveniverse.maven.plugins:toolbox:gav-classpath-diff -Dunified -Dgav1=org.apache.commons:commons-lang3:3.17.0 -Dgav2=org.apache.commons:commons-lang3:3.19.0
...
[INFO] --- toolbox:0.15.4:gav-classpath-diff (default-cli) @ standalone-pom ---
[INFO] *** org.apache.commons:commons-lang3:jar 3.17.0 -> 3.19.0
```
TestNG:
```
$ mvn eu.maveniverse.maven.plugins:toolbox:gav-classpath-diff -Dunified -Dgav1=org.testng:testng:6.14.3 -Dgav2=org.testng:testng:7.11.0
...
[INFO] --- toolbox:0.15.4:gav-classpath-diff (default-cli) @ standalone-pom ---
[INFO] *** org.testng:testng:jar 6.14.3 -> 7.11.0
[INFO] --- com.beust:jcommander:jar:1.72
[INFO] --- org.apache-extras.beanshell:bsh:jar:2.0b6
[INFO] +++ org.slf4j:slf4j-api:jar:2.0.16
[INFO] +++ org.jcommander:jcommander:jar:1.83
[INFO] +++ org.webjars:jquery:jar:3.7.1
[INFO] +++ com.google.inject:guice:jar:5.1.0
[INFO] +++ javax.inject:javax.inject:jar:1
[INFO] +++ aopalliance:aopalliance:jar:1.0
[INFO] +++ com.google.guava:guava:jar:30.1-jre
[INFO] +++ com.google.guava:failureaccess:jar:1.0.1
[INFO] +++ com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava
[INFO] +++ com.google.code.findbugs:jsr305:jar:3.0.2
[INFO] +++ org.checkerframework:checker-qual:jar:3.5.0
[INFO] +++ com.google.errorprone:error_prone_annotations:jar:2.3.4
[INFO] +++ com.google.j2objc:j2objc-annotations:jar:1.3
[INFO] +++ org.yaml:snakeyaml:jar:2.2
```
the whole guice branch (+snakeyyaml) seems to be optional:
```
$ mvn eu.maveniverse.maven.plugins:toolbox:gav-tree -Dgav=org.testng:testng:7.11.0
[INFO] --- toolbox:0.15.4:gav-tree (default-cli) @ standalone-pom ---
[INFO] org.testng:testng:jar:7.11.0 (origin: central)
[INFO] ├─org.slf4j:slf4j-api:jar:2.0.16 [compile] (origin: central)
[INFO] ├─org.jcommander:jcommander:jar:1.83 [compile] (origin: central)
[INFO] ├─org.webjars:jquery:jar:3.7.1 [runtime] (origin: central)
[INFO] ├─com.google.inject:guice:jar:5.1.0 [compile, optional] (origin: central)
[INFO] │ ├─javax.inject:javax.inject:jar:1 [compile, optional] (origin: central)
[INFO] │ ├─aopalliance:aopalliance:jar:1.0 [compile, optional] (origin: central)
[INFO] │ ╰─com.google.guava:guava:jar:30.1-jre [compile, optional] (origin: central)
[INFO] │ ├─com.google.guava:failureaccess:jar:1.0.1 [compile, optional] (origin: central)
[INFO] │ ├─com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava [compile, optional] (origin: central)
[INFO] │ ├─com.google.code.findbugs:jsr305:jar:3.0.2 [compile, optional] (origin: central)
[INFO] │ ├─org.checkerframework:checker-qual:jar:3.5.0 [compile, optional] (origin: central)
[INFO] │ ├─com.google.errorprone:error_prone_annotations:jar:2.3.4 [compile, optional] (origin: central)
[INFO] │ ╰─com.google.j2objc:j2objc-annotations:jar:1.3 [compile, optional] (origin: central)
[INFO] ╰─org.yaml:snakeyaml:jar:2.2 [runtime, optional] (origin: central)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Updating commons-lang3 and testng dependencies [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #9254:
URL: https://github.com/apache/netbeans/pull/9254#discussion_r3343582041
##########
platform/o.apache.commons.lang3/build.xml:
##########
@@ -21,5 +21,19 @@
-->
<project name="platform/o.apache.commons.lang3" default="build" basedir=".">
<import file="../../nbbuild/templates/projectized.xml"/>
- <target name="jar"/>
+ <!--
+ The NetBeans module org.apache.commons.lang3 is just a repackaging
+ of the original bundle, with problematic elements relating to OSGI
+ and Netbinox replaced in the MANIFEST.
+ -->
Review Comment:
Ok - I see. Maybe it is finally time to ditch equinox (@mbien did some work that might enable us to do that). The hack from https://github.com/apache/netbeans/pull/9329 fixed the problem for bouncy castle, but there the Import-Packages are declared optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Updating commons-lang3 and testng dependencies [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #9254:
URL: https://github.com/apache/netbeans/pull/9254#discussion_r3284083815
##########
platform/o.apache.commons.lang3/build.xml:
##########
@@ -21,5 +21,19 @@
-->
<project name="platform/o.apache.commons.lang3" default="build" basedir=".">
<import file="../../nbbuild/templates/projectized.xml"/>
- <target name="jar"/>
+ <!--
+ The NetBeans module org.apache.commons.lang3 is just a repackaging
+ of the original bundle, with problematic elements relating to OSGI
+ and Netbinox replaced in the MANIFEST.
+ -->
Review Comment:
_What_ is problematic?
##########
platform/libs.testng/nbproject/project.xml:
##########
@@ -37,12 +37,20 @@
<package>org.testng.xml</package>
</public-packages>
<class-path-extension>
- <runtime-relative-path>ext/testng-6.14.3.jar</runtime-relative-path>
- <binary-origin>external/testng-6.14.3.jar</binary-origin>
+ <runtime-relative-path>ext/testng-7.11.0.jar</runtime-relative-path>
+ <binary-origin>external/testng-7.11.0.jar</binary-origin>
</class-path-extension>
<class-path-extension>
- <runtime-relative-path>ext/jcommander-1.78.jar</runtime-relative-path>
- <binary-origin>external/jcommander-1.78.jar</binary-origin>
+ <runtime-relative-path>ext/jcommander-1.85.jar</runtime-relative-path>
+ <binary-origin>external/jcommander-1.85.jar</binary-origin>
+ </class-path-extension>
+ <class-path-extension>
+ <runtime-relative-path>ext/testng-ant-1.0.0.jar</runtime-relative-path>
+ <binary-origin>external/testng-ant-1.0.0.jar</binary-origin>
+ </class-path-extension>
+ <class-path-extension>
+ <runtime-relative-path>ext/slf4j-api-2.0.17.jar</runtime-relative-path>
+ <binary-origin>external/slf4j-api-2.0.17.jar</binary-origin>
</class-path-extension>
Review Comment:
Is this needed? We have `slf4j-api` as a module. Do we need to update that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Updating commons-lang3 and testng dependencies [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing merged PR #9254:
URL: https://github.com/apache/netbeans/pull/9254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Updating commons-lang3 and testng dependencies [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #9254:
URL: https://github.com/apache/netbeans/pull/9254#discussion_r3343476855
##########
platform/libs.testng/nbproject/project.xml:
##########
@@ -37,12 +37,20 @@
<package>org.testng.xml</package>
</public-packages>
<class-path-extension>
- <runtime-relative-path>ext/testng-6.14.3.jar</runtime-relative-path>
- <binary-origin>external/testng-6.14.3.jar</binary-origin>
+ <runtime-relative-path>ext/testng-7.11.0.jar</runtime-relative-path>
+ <binary-origin>external/testng-7.11.0.jar</binary-origin>
</class-path-extension>
<class-path-extension>
- <runtime-relative-path>ext/jcommander-1.78.jar</runtime-relative-path>
- <binary-origin>external/jcommander-1.78.jar</binary-origin>
+ <runtime-relative-path>ext/jcommander-1.85.jar</runtime-relative-path>
+ <binary-origin>external/jcommander-1.85.jar</binary-origin>
+ </class-path-extension>
+ <class-path-extension>
+ <runtime-relative-path>ext/testng-ant-1.0.0.jar</runtime-relative-path>
+ <binary-origin>external/testng-ant-1.0.0.jar</binary-origin>
+ </class-path-extension>
+ <class-path-extension>
+ <runtime-relative-path>ext/slf4j-api-2.0.17.jar</runtime-relative-path>
+ <binary-origin>external/slf4j-api-2.0.17.jar</binary-origin>
</class-path-extension>
Review Comment:
ok - fair enough, but what logger is used by this? I don't see an implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Updating commons-lang3 and testng dependencies [netbeans]
Posted by "sid-srini (via GitHub)" <gi...@apache.org>.
sid-srini commented on PR #9254:
URL: https://github.com/apache/netbeans/pull/9254#issuecomment-4039574730
Thanks a lot @mbien for running all the CI tests, and, for going through the changes and dependencies.
You are right that the majority of the listed dependencies are optional ones. The libraries included: slf4j and jcommander, were the non-optional ones that are required. Also, the testng jar already contains the jquery js components for the HTML reports it generates.
Additionally, the testng-ant library is now included because it is now a separate library (also mentioned in the commit message of 8169a5c) and is used by NetBeans for running testng via ant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Updating commons-lang3 and testng dependencies [netbeans]
Posted by "sid-srini (via GitHub)" <gi...@apache.org>.
sid-srini commented on code in PR #9254:
URL: https://github.com/apache/netbeans/pull/9254#discussion_r3330220876
##########
platform/o.apache.commons.lang3/build.xml:
##########
@@ -21,5 +21,19 @@
-->
<project name="platform/o.apache.commons.lang3" default="build" basedir=".">
<import file="../../nbbuild/templates/projectized.xml"/>
- <target name="jar"/>
+ <!--
+ The NetBeans module org.apache.commons.lang3 is just a repackaging
+ of the original bundle, with problematic elements relating to OSGI
+ and Netbinox replaced in the MANIFEST.
+ -->
Review Comment:
- The commons-lang3 jar versions >= 3.18.0 are built with a newer OSGi `Bnd` tool which adds an `Import-Package` entry in the manifest containing references to jdk packages.
- This is allowed by OSGi >= 7.
- The Netbeans OSGi module has version 8.
- However, its loader uses the Netbinox module which has an older version of Equinox and OSGi.
- This causes a `ClassNotFoundException` even though the jar is on the classpath.
- The jar repackaging with a manifest containing a dummy `Import-Package` entry allows Netbinox to load the new jar.
- A similar fix had been done earlier in the commons-logging and commons-codec module too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Updating commons-lang3 and testng dependencies [netbeans]
Posted by "sid-srini (via GitHub)" <gi...@apache.org>.
sid-srini commented on code in PR #9254:
URL: https://github.com/apache/netbeans/pull/9254#discussion_r3330190668
##########
platform/libs.testng/nbproject/project.xml:
##########
@@ -37,12 +37,20 @@
<package>org.testng.xml</package>
</public-packages>
<class-path-extension>
- <runtime-relative-path>ext/testng-6.14.3.jar</runtime-relative-path>
- <binary-origin>external/testng-6.14.3.jar</binary-origin>
+ <runtime-relative-path>ext/testng-7.11.0.jar</runtime-relative-path>
+ <binary-origin>external/testng-7.11.0.jar</binary-origin>
</class-path-extension>
<class-path-extension>
- <runtime-relative-path>ext/jcommander-1.78.jar</runtime-relative-path>
- <binary-origin>external/jcommander-1.78.jar</binary-origin>
+ <runtime-relative-path>ext/jcommander-1.85.jar</runtime-relative-path>
+ <binary-origin>external/jcommander-1.85.jar</binary-origin>
+ </class-path-extension>
+ <class-path-extension>
+ <runtime-relative-path>ext/testng-ant-1.0.0.jar</runtime-relative-path>
+ <binary-origin>external/testng-ant-1.0.0.jar</binary-origin>
+ </class-path-extension>
+ <class-path-extension>
+ <runtime-relative-path>ext/slf4j-api-2.0.17.jar</runtime-relative-path>
+ <binary-origin>external/slf4j-api-2.0.17.jar</binary-origin>
</class-path-extension>
Review Comment:
The `ide/slf4j-api` module provides v1 whereas the newer testng references v2. Since the v1 module is used in some other unrelated modules, it would perhaps be better to include the necessary v2 api in this module itself.
Further, since testng is in the `platform` cluster, I would imagine that the isolation from the `ide` cluster would be beneficial for build tasks. The maven module also seems to keep its own copy of the slf4j-api perhaps in order to isolate itself from the global `ide` slf4j module.
Please let me know what you think. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Updating commons-lang3 and testng dependencies [netbeans]
Posted by "sid-srini (via GitHub)" <gi...@apache.org>.
sid-srini commented on PR #9254:
URL: https://github.com/apache/netbeans/pull/9254#issuecomment-4338105911
Hi @mbien. Please review this when you get a chance. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Updating commons-lang3 and testng dependencies [netbeans]
Posted by "sid-srini (via GitHub)" <gi...@apache.org>.
sid-srini commented on code in PR #9254:
URL: https://github.com/apache/netbeans/pull/9254#discussion_r3349043426
##########
platform/libs.testng/nbproject/project.xml:
##########
@@ -37,12 +37,20 @@
<package>org.testng.xml</package>
</public-packages>
<class-path-extension>
- <runtime-relative-path>ext/testng-6.14.3.jar</runtime-relative-path>
- <binary-origin>external/testng-6.14.3.jar</binary-origin>
+ <runtime-relative-path>ext/testng-7.11.0.jar</runtime-relative-path>
+ <binary-origin>external/testng-7.11.0.jar</binary-origin>
</class-path-extension>
<class-path-extension>
- <runtime-relative-path>ext/jcommander-1.78.jar</runtime-relative-path>
- <binary-origin>external/jcommander-1.78.jar</binary-origin>
+ <runtime-relative-path>ext/jcommander-1.85.jar</runtime-relative-path>
+ <binary-origin>external/jcommander-1.85.jar</binary-origin>
+ </class-path-extension>
+ <class-path-extension>
+ <runtime-relative-path>ext/testng-ant-1.0.0.jar</runtime-relative-path>
+ <binary-origin>external/testng-ant-1.0.0.jar</binary-origin>
+ </class-path-extension>
+ <class-path-extension>
+ <runtime-relative-path>ext/slf4j-api-2.0.17.jar</runtime-relative-path>
+ <binary-origin>external/slf4j-api-2.0.17.jar</binary-origin>
</class-path-extension>
Review Comment:
Yes, the logging implementation is typically added by the project which uses testng (and wants to introspect testng logs) and it would be incorrect to cause multiple slf4j implementations in such a project by adding one via this module.
Further the modules do not rely on the logger nor require it. Even the testng.ant module is able to provide verbose output using its own reporter implementation.
Thanks for the review and cross-checking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Updating commons-lang3 and testng dependencies [netbeans]
Posted by "sid-srini (via GitHub)" <gi...@apache.org>.
sid-srini commented on code in PR #9254:
URL: https://github.com/apache/netbeans/pull/9254#discussion_r3330190668
##########
platform/libs.testng/nbproject/project.xml:
##########
@@ -37,12 +37,20 @@
<package>org.testng.xml</package>
</public-packages>
<class-path-extension>
- <runtime-relative-path>ext/testng-6.14.3.jar</runtime-relative-path>
- <binary-origin>external/testng-6.14.3.jar</binary-origin>
+ <runtime-relative-path>ext/testng-7.11.0.jar</runtime-relative-path>
+ <binary-origin>external/testng-7.11.0.jar</binary-origin>
</class-path-extension>
<class-path-extension>
- <runtime-relative-path>ext/jcommander-1.78.jar</runtime-relative-path>
- <binary-origin>external/jcommander-1.78.jar</binary-origin>
+ <runtime-relative-path>ext/jcommander-1.85.jar</runtime-relative-path>
+ <binary-origin>external/jcommander-1.85.jar</binary-origin>
+ </class-path-extension>
+ <class-path-extension>
+ <runtime-relative-path>ext/testng-ant-1.0.0.jar</runtime-relative-path>
+ <binary-origin>external/testng-ant-1.0.0.jar</binary-origin>
+ </class-path-extension>
+ <class-path-extension>
+ <runtime-relative-path>ext/slf4j-api-2.0.17.jar</runtime-relative-path>
+ <binary-origin>external/slf4j-api-2.0.17.jar</binary-origin>
</class-path-extension>
Review Comment:
The `ide/slf4j-api` module provides v1 of slf4j whereas the newer testng references v2. Since the v1 module is used in some other unrelated modules, it would perhaps be better to include the necessary v2 api in this module itself.
Further, since testng is in the `platform` cluster, I would imagine that the isolation from the `ide` cluster would be beneficial for build tasks. The maven module also seems to keep its own copy of the slf4j-api perhaps in order to isolate itself from the global `ide` slf4j module.
Please let me know what you think. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Updating commons-lang3 and testng dependencies [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #9254:
URL: https://github.com/apache/netbeans/pull/9254#issuecomment-4605923083
I think this can be merged, @mbien could I get a second opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Updating commons-lang3 and testng dependencies [netbeans]
Posted by "sid-srini (via GitHub)" <gi...@apache.org>.
sid-srini commented on code in PR #9254:
URL: https://github.com/apache/netbeans/pull/9254#discussion_r3330220876
##########
platform/o.apache.commons.lang3/build.xml:
##########
@@ -21,5 +21,19 @@
-->
<project name="platform/o.apache.commons.lang3" default="build" basedir=".">
<import file="../../nbbuild/templates/projectized.xml"/>
- <target name="jar"/>
+ <!--
+ The NetBeans module org.apache.commons.lang3 is just a repackaging
+ of the original bundle, with problematic elements relating to OSGI
+ and Netbinox replaced in the MANIFEST.
+ -->
Review Comment:
- The commons-lang3 jar versions >= 3.18.0 are built with a newer OSGi `Bnd` tool which adds an `Import-Package` entry in the manifest containing references to jdk packages.
- This is allowed by OSGi >= 7.
- The Netbeans OSGi module has version 8.
- However, its loader uses the Netbinox module which has an older version of Equinox and OSGi.
- This causes a `ClassNotFoundException` even though the jar is on the classpath.
- The jar repackaging with a manifest containing a dummy `Import-Package` entry allows Netbinox to load the new jar.
- A similar fix had been done earlier in the commons-logging/commons-codec module too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Updating commons-lang3 and testng dependencies [netbeans]
Posted by "sid-srini (via GitHub)" <gi...@apache.org>.
sid-srini commented on code in PR #9254:
URL: https://github.com/apache/netbeans/pull/9254#discussion_r3330220876
##########
platform/o.apache.commons.lang3/build.xml:
##########
@@ -21,5 +21,19 @@
-->
<project name="platform/o.apache.commons.lang3" default="build" basedir=".">
<import file="../../nbbuild/templates/projectized.xml"/>
- <target name="jar"/>
+ <!--
+ The NetBeans module org.apache.commons.lang3 is just a repackaging
+ of the original bundle, with problematic elements relating to OSGI
+ and Netbinox replaced in the MANIFEST.
+ -->
Review Comment:
- The commons-lang3 jar versions >= 3.18.0 are built with a newer OSGi `Bnd` tool which adds an `Import-Package` entry in the manifest containing references to jdk packages.
- This is allowed by OSGi >= 7.
- The Netbeans OSGi module has version 8.
- However, its loader uses the Netbinox module which has an older version of Equinox and OSGi.
- This causes a `ClassNotFoundException` even though the jar is on the classpath.
- The jar repackaging with a manifest containing a dummy `Import-Package` entry allows Netbinox to load the new jar.
- A similar fix had been done earlier in the commons-logging module too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Updating commons-lang3 and testng dependencies [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #9254:
URL: https://github.com/apache/netbeans/pull/9254#issuecomment-5309011395
@sid-srini this change most probably broke ant project integration. Please have a look at #9561. The problem is reproducible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists