You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/10/30 20:30:43 UTC
[kudu-CR] [docs] fix broken links reported by 'site tool proof'
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14591
Change subject: [docs] fix broken links reported by 'site_tool proof'
......................................................................
[docs] fix broken links reported by 'site_tool proof'
While preparing to update the contents of the project site for 1.11.0
release, I found that the 'site_tool proof' reports many broken links.
This patch fixes that, so 'site_tool proof' returns clean.
Change-Id: I8c8e3a477dacf7dc304d138de7efedc1e6d93b65
---
M docs/developing.adoc
M docs/hive_metastore.adoc
M docs/installation.adoc
M docs/kudu_impala_integration.adoc
M docs/schema_design.adoc
M docs/security.adoc
6 files changed, 40 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/14591/1
--
To view, visit http://gerrit.cloudera.org:8080/14591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c8e3a477dacf7dc304d138de7efedc1e6d93b65
Gerrit-Change-Number: 14591
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [docs] fix broken links reported by 'site tool proof'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14591 )
Change subject: [docs] fix broken links reported by 'site_tool proof'
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14591/1/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/14591/1/docs/installation.adoc@a603
PS1, Line 603:
> I saw this was copied into the dev docs, but why remove it from here? Shoul
I dont think this piece is relevant at all in installation.adoc. I'm not sure we even need a link here.
By my understanding, this piece was put here when developing.adoc was not present.
--
To view, visit http://gerrit.cloudera.org:8080/14591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8e3a477dacf7dc304d138de7efedc1e6d93b65
Gerrit-Change-Number: 14591
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 30 Oct 2019 21:10:52 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] fix broken links reported by 'site tool proof'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [docs] fix broken links reported by 'site_tool proof'
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I8c8e3a477dacf7dc304d138de7efedc1e6d93b65
Gerrit-Change-Number: 14591
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] fix broken links reported by 'site tool proof'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [docs] fix broken links reported by 'site_tool proof'
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I8c8e3a477dacf7dc304d138de7efedc1e6d93b65
Gerrit-Change-Number: 14591
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] fix broken links reported by 'site tool proof'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14591 )
Change subject: [docs] fix broken links reported by 'site_tool proof'
......................................................................
[docs] fix broken links reported by 'site_tool proof'
While preparing to update the contents of the project site for 1.11.0
release, I found that the 'site_tool proof' reports many broken links.
This patch fixes that, so 'site_tool proof' returns clean.
I also updated the installation.adoc, moving the information on API
documentaion into developing.adoc. By my understanding, that piece
doesn't belong to installation-related topics. I also updated the
JDK requirements to reflect the fact of dropping support of Java 7
in prior release (i.e. 1.10.0).
Change-Id: I8c8e3a477dacf7dc304d138de7efedc1e6d93b65
Reviewed-on: http://gerrit.cloudera.org:8080/14591
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M docs/developing.adoc
M docs/hive_metastore.adoc
M docs/installation.adoc
M docs/kudu_impala_integration.adoc
M docs/schema_design.adoc
M docs/security.adoc
6 files changed, 46 insertions(+), 45 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c8e3a477dacf7dc304d138de7efedc1e6d93b65
Gerrit-Change-Number: 14591
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] fix broken links reported by 'site tool proof'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14591 )
Change subject: [docs] fix broken links reported by 'site_tool proof'
......................................................................
Patch Set 2: Verified+1
Unrelated test failures:
* MultiThreadedTabletTest/1.DeleteAndReinsert
--
To view, visit http://gerrit.cloudera.org:8080/14591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8e3a477dacf7dc304d138de7efedc1e6d93b65
Gerrit-Change-Number: 14591
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 31 Oct 2019 00:10:03 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] fix broken links reported by 'site tool proof'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14591
to look at the new patch set (#2).
Change subject: [docs] fix broken links reported by 'site_tool proof'
......................................................................
[docs] fix broken links reported by 'site_tool proof'
While preparing to update the contents of the project site for 1.11.0
release, I found that the 'site_tool proof' reports many broken links.
This patch fixes that, so 'site_tool proof' returns clean.
I also updated the installation.adoc, moving the information on API
documentaion into developing.adoc. By my understanding, that piece
doesn't belong to installation-related topics. I also updated the
JDK requirements to reflect the fact of dropping support of Java 7
in prior release (i.e. 1.10.0).
Change-Id: I8c8e3a477dacf7dc304d138de7efedc1e6d93b65
---
M docs/developing.adoc
M docs/hive_metastore.adoc
M docs/installation.adoc
M docs/kudu_impala_integration.adoc
M docs/schema_design.adoc
M docs/security.adoc
6 files changed, 46 insertions(+), 45 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/14591/2
--
To view, visit http://gerrit.cloudera.org:8080/14591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c8e3a477dacf7dc304d138de7efedc1e6d93b65
Gerrit-Change-Number: 14591
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] fix broken links reported by 'site tool proof'
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14591 )
Change subject: [docs] fix broken links reported by 'site_tool proof'
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8e3a477dacf7dc304d138de7efedc1e6d93b65
Gerrit-Change-Number: 14591
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 30 Oct 2019 23:44:59 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] fix broken links reported by 'site tool proof'
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14591 )
Change subject: [docs] fix broken links reported by 'site_tool proof'
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14591/1/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/14591/1/docs/installation.adoc@a603
PS1, Line 603:
I saw this was copied into the dev docs, but why remove it from here? Should we at least link to it?
--
To view, visit http://gerrit.cloudera.org:8080/14591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8e3a477dacf7dc304d138de7efedc1e6d93b65
Gerrit-Change-Number: 14591
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 30 Oct 2019 20:50:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] fix broken links reported by 'site tool proof'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14591 )
Change subject: [docs] fix broken links reported by 'site_tool proof'
......................................................................
Patch Set 1: Verified+1
Unrelated test failures:
* RaftConsensusQuorumTest.TestRequestVote
--
To view, visit http://gerrit.cloudera.org:8080/14591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8e3a477dacf7dc304d138de7efedc1e6d93b65
Gerrit-Change-Number: 14591
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 30 Oct 2019 22:02:33 +0000
Gerrit-HasComments: No