You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "unikdahal (via GitHub)" <gi...@apache.org> on 2026/10/05 18:02:59 UTC
[PR] feat(iceberg): plan WriteDelta in the split write path and keep it on the JVM DeltaWriter [datafusion-comet]
unikdahal opened a new pull request, #6693:
URL: https://github.com/apache/datafusion-comet/pull/6693
## Which issue does this PR close?
Closes #6692.
Part of #6240.
## Rationale for this change
On Spark 3.5+, Iceberg merge-on-read `DELETE`, `UPDATE` and `MERGE` write through `WriteDelta`, which the split Iceberg write path does not model. The native position-delta writer planned in #6240 needs a recognised, tested dispatch point first. This keeps behaviour unchanged for users and makes the later native work a writer swap rather than a planner change.
## What changes are included in this PR?
- Recognise Iceberg `WriteDelta` on Spark 3.5+; Spark 3.4 keeps the stock plan.
- Carry only the operation and Spark projection state the JVM delta path needs, using Spark's `RowDeltaUtils` operation constants instead of copies of the numeric ids.
- Run position-delta rows through Iceberg's JVM `DeltaWriter`. The native Iceberg writer stays out of the delta path (`CometIcebergWriteExec` is never used for them).
- Keep row-level write summaries, writer reporting, AQE behaviour and failure cleanup the same as the stock Iceberg path.
- Fall back with a reason when the version-specific logical-plan extraction cannot be done.
- Update the Iceberg writes user and contributor guides.
Out of scope, for later items in #6240: a native delta operator or protobuf, a native position-delete writer or file layout contract, loading previous deletes, and a native feature flag. There are no Rust changes or dependencies.
## How are these changes tested?
- `DELETE`, `UPDATE` and `MERGE` results match the stock Iceberg JVM path.
- Position-delta dispatch plans without `CometIcebergWriteExec`.
- Copy-on-write and merge-on-read `MERGE` plans match the stock path with AQE on and off.
- Row-level snapshot summaries match where Spark exposes them.
- Writer reporting classifies the intercepted JVM `WriteDelta`.
- Task commit location extraction covers position-delta data and delete files.
- A reflection test covers the version-specific logical-plan extraction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat(iceberg): plan WriteDelta in the split write path and keep it on the JVM DeltaWriter [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #6693:
URL: https://github.com/apache/datafusion-comet/pull/6693#issuecomment-6018608883
@unikdahal could you fix the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat(iceberg): plan WriteDelta in the split write path and keep it on the JVM DeltaWriter [datafusion-comet]
Posted by "unikdahal (via GitHub)" <gi...@apache.org>.
unikdahal commented on PR #6693:
URL: https://github.com/apache/datafusion-comet/pull/6693#issuecomment-6020345587
Thanks @andygrove @sunchao . I have resolved the conflicts you can trigger CI now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat(iceberg): plan WriteDelta in the split write path and keep it on the JVM DeltaWriter [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #6693:
URL: https://github.com/apache/datafusion-comet/pull/6693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org