[jira] Closed: (LANG-443) DateUtils should test with the extremes

["Henri Yandell (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LANG-443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell closed LANG-443.
------------------------------

    Resolution: Fixed

This test is great Robert - many, many thanks.

svn ci -m "Applying Robert Scholte's excellent unit tests from LANG-443 and his second patch from LANG-440 fixing a discovered boundary case for AM_PM in round"

Sending        pom.xml
Sending        src/java/org/apache/commons/lang/time/DateUtils.java
Adding         src/test/org/apache/commons/lang/time/DateUtilsRoundingTest.java
Sending        src/test/org/apache/commons/lang/time/TimeTestSuite.java
Transmitting file data ....
Committed revision 711616.

Closing the ticket so it doesn't end up with more patches on a later version (painful bit in JIRA, having one issue in multiple versions).

> DateUtils should test with the extremes
> ---------------------------------------
>
>                 Key: LANG-443
>                 URL: https://issues.apache.org/jira/browse/LANG-443
>             Project: Commons Lang
>          Issue Type: Task
>    Affects Versions: 2.4
>            Reporter: Robert Scholte
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: LANG-443-rs.patch
>
>
> Current testdates are a bit to generic. Especially for truncating, ceiling and rounding you shuold test for the extremes. 
> So for rounding to hours you should test for 0:29 (rounding down); 0:30 (rounding up); 1:00 (no rounding required)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.