You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (JIRA)" <ji...@apache.org> on 2019/04/15 22:28:00 UTC
[jira] [Commented] (HIVE-21616) Implement JSON_VALUE, JSON_QUERY,
and IS [NOT] JSON
[ https://issues.apache.org/jira/browse/HIVE-21616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818438#comment-16818438 ]
Hive QA commented on HIVE-21616:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 3s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m 12s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 11s{color} | {color:blue} ql in master has 2265 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 39s{color} | {color:blue} hplsql in master has 157 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m 5s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 27s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 8m 4s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 51s{color} | {color:red} ql: The patch generated 681 new + 484 unchanged - 0 fixed = 1165 total (was 484) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m 16s{color} | {color:red} root: The patch generated 681 new + 484 unchanged - 0 fixed = 1165 total (was 484) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m 24s{color} | {color:red} ql generated 58 new + 2258 unchanged - 7 fixed = 2316 total (was 2265) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m 59s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 69m 45s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Dead store to KW_IN244 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.precedenceSimilarExpressionAtom(CommonTree) At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.precedenceSimilarExpressionAtom(CommonTree) At HiveParser_IdentifiersParser.java:[line 9680] |
| | Dead store to LPAREN234 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.subQueryExpression() At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.subQueryExpression() At HiveParser_IdentifiersParser.java:[line 9141] |
| | Dead store to RPAREN236 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.subQueryExpression() At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.subQueryExpression() At HiveParser_IdentifiersParser.java:[line 9148] |
| | Redundant nullcheck of nonReserved307, which is known to be non-null in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.identifier() Redundant null check at HiveParser_IdentifiersParser.java:is known to be non-null in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.identifier() Redundant null check at HiveParser_IdentifiersParser.java:[line 12146] |
| | org.apache.hadoop.hive.ql.udf.generic.JsonLexer.getModeNames() may expose internal representation by returning JsonLexer.modeNames At JsonLexer.java:by returning JsonLexer.modeNames At JsonLexer.java:[line 90] |
| | org.apache.hadoop.hive.ql.udf.generic.JsonLexer.getRuleNames() may expose internal representation by returning JsonLexer.ruleNames At JsonLexer.java:by returning JsonLexer.ruleNames At JsonLexer.java:[line 84] |
| | org.apache.hadoop.hive.ql.udf.generic.JsonLexer.getTokenNames() may expose internal representation by returning JsonLexer.tokenNames At JsonLexer.java:by returning JsonLexer.tokenNames At JsonLexer.java:[line 65] |
| | org.apache.hadoop.hive.ql.udf.generic.JsonLexer.modeNames should be both final and package protected At JsonLexer.java:and package protected At JsonLexer.java:[line 23] |
| | org.apache.hadoop.hive.ql.udf.generic.JsonLexer._decisionToDFA should be package protected At JsonLexer.java: At JsonLexer.java:[line 152] |
| | org.apache.hadoop.hive.ql.udf.generic.JsonLexer.ruleNames should be package protected At JsonLexer.java: At JsonLexer.java:[line 27] |
| | org.apache.hadoop.hive.ql.udf.generic.JsonLexer.tokenNames should be package protected At JsonLexer.java: At JsonLexer.java:[line 49] |
| | Unchecked/unconfirmed cast from org.antlr.v4.runtime.RuleContext to org.apache.hadoop.hive.ql.udf.generic.JsonParser$Array_listContext in org.apache.hadoop.hive.ql.udf.generic.JsonParser.sempred(RuleContext, int, int) At JsonParser.java:org.apache.hadoop.hive.ql.udf.generic.JsonParser$Array_listContext in org.apache.hadoop.hive.ql.udf.generic.JsonParser.sempred(RuleContext, int, int) At JsonParser.java:[line 814] |
| | Unchecked/unconfirmed cast from org.antlr.v4.runtime.RuleContext to org.apache.hadoop.hive.ql.udf.generic.JsonParser$Element_listContext in org.apache.hadoop.hive.ql.udf.generic.JsonParser.sempred(RuleContext, int, int) At JsonParser.java:org.apache.hadoop.hive.ql.udf.generic.JsonParser$Element_listContext in org.apache.hadoop.hive.ql.udf.generic.JsonParser.sempred(RuleContext, int, int) At JsonParser.java:[line 812] |
| | org.apache.hadoop.hive.ql.udf.generic.JsonParser.getRuleNames() may expose internal representation by returning JsonParser.ruleNames At JsonParser.java:by returning JsonParser.ruleNames At JsonParser.java:[line 78] |
| | org.apache.hadoop.hive.ql.udf.generic.JsonParser.getTokenNames() may expose internal representation by returning JsonParser.tokenNames At JsonParser.java:by returning JsonParser.tokenNames At JsonParser.java:[line 65] |
| | org.apache.hadoop.hive.ql.udf.generic.JsonParser._decisionToDFA should be package protected At JsonParser.java: At JsonParser.java:[line 858] |
| | org.apache.hadoop.hive.ql.udf.generic.JsonParser.ruleNames should be package protected At JsonParser.java: At JsonParser.java:[line 28] |
| | org.apache.hadoop.hive.ql.udf.generic.JsonParser.tokenNames should be package protected At JsonParser.java: At JsonParser.java:[line 49] |
| | Switch statement found in org.apache.hadoop.hive.ql.udf.generic.JsonParser.array() where default case is missing At JsonParser.java:where default case is missing At JsonParser.java:[lines 430-448] |
| | Switch statement found in org.apache.hadoop.hive.ql.udf.generic.JsonParser.object() where default case is missing At JsonParser.java:where default case is missing At JsonParser.java:[lines 120-138] |
| | org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathLexer.getModeNames() may expose internal representation by returning SqlJsonPathLexer.modeNames At SqlJsonPathLexer.java:by returning SqlJsonPathLexer.modeNames At SqlJsonPathLexer.java:[line 114] |
| | org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathLexer.getRuleNames() may expose internal representation by returning SqlJsonPathLexer.ruleNames At SqlJsonPathLexer.java:by returning SqlJsonPathLexer.ruleNames At SqlJsonPathLexer.java:[line 108] |
| | org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathLexer.getTokenNames() may expose internal representation by returning SqlJsonPathLexer.tokenNames At SqlJsonPathLexer.java:by returning SqlJsonPathLexer.tokenNames At SqlJsonPathLexer.java:[line 89] |
| | org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathLexer.modeNames should be both final and package protected At SqlJsonPathLexer.java:and package protected At SqlJsonPathLexer.java:[line 30] |
| | org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathLexer._decisionToDFA should be package protected At SqlJsonPathLexer.java: At SqlJsonPathLexer.java:[line 271] |
| | org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathLexer.ruleNames should be package protected At SqlJsonPathLexer.java: At SqlJsonPathLexer.java:[line 34] |
| | org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathLexer.tokenNames should be package protected At SqlJsonPathLexer.java: At SqlJsonPathLexer.java:[line 73] |
| | Unchecked/unconfirmed cast from org.antlr.v4.runtime.RuleContext to org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser$Accessor_expressionContext in org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.sempred(RuleContext, int, int) At SqlJsonPathParser.java:org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser$Accessor_expressionContext in org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.sempred(RuleContext, int, int) At SqlJsonPathParser.java:[line 3824] |
| | Unchecked/unconfirmed cast from org.antlr.v4.runtime.RuleContext to org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser$Additive_expressionContext in org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.sempred(RuleContext, int, int) At SqlJsonPathParser.java:org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser$Additive_expressionContext in org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.sempred(RuleContext, int, int) At SqlJsonPathParser.java:[line 3820] |
| | Unchecked/unconfirmed cast from org.antlr.v4.runtime.RuleContext to org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser$Boolean_conjunctionContext in org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.sempred(RuleContext, int, int) At SqlJsonPathParser.java:org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser$Boolean_conjunctionContext in org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.sempred(RuleContext, int, int) At SqlJsonPathParser.java:[line 3830] |
| | Unchecked/unconfirmed cast from org.antlr.v4.runtime.RuleContext to org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser$Boolean_disjunctionContext in org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.sempred(RuleContext, int, int) At SqlJsonPathParser.java:org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser$Boolean_disjunctionContext in org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.sempred(RuleContext, int, int) At SqlJsonPathParser.java:[line 3828] |
| | Unchecked/unconfirmed cast from org.antlr.v4.runtime.RuleContext to org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser$Multiplicative_expressionContext in org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.sempred(RuleContext, int, int) At SqlJsonPathParser.java:org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser$Multiplicative_expressionContext in org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.sempred(RuleContext, int, int) At SqlJsonPathParser.java:[line 3822] |
| | Unchecked/unconfirmed cast from org.antlr.v4.runtime.RuleContext to org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser$Subscript_listContext in org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.sempred(RuleContext, int, int) At SqlJsonPathParser.java:org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser$Subscript_listContext in org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.sempred(RuleContext, int, int) At SqlJsonPathParser.java:[line 3826] |
| | org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.getRuleNames() may expose internal representation by returning SqlJsonPathParser.ruleNames At SqlJsonPathParser.java:by returning SqlJsonPathParser.ruleNames At SqlJsonPathParser.java:[line 127] |
| | org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.getTokenNames() may expose internal representation by returning SqlJsonPathParser.tokenNames At SqlJsonPathParser.java:by returning SqlJsonPathParser.tokenNames At SqlJsonPathParser.java:[line 114] |
| | org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser._decisionToDFA should be package protected At SqlJsonPathParser.java: At SqlJsonPathParser.java:[line 4027] |
| | org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.ruleNames should be package protected At SqlJsonPathParser.java: At SqlJsonPathParser.java:[line 52] |
| | org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.tokenNames should be package protected At SqlJsonPathParser.java: At SqlJsonPathParser.java:[line 98] |
| | Switch statement found in org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.accessor_op() where default case is missing At SqlJsonPathParser.java:where default case is missing At SqlJsonPathParser.java:[lines 1016-1056] |
| | Switch statement found in org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.additive_expression(int) where default case is missing At SqlJsonPathParser.java:where default case is missing At SqlJsonPathParser.java:[lines 364-386] |
| | Switch statement found in org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.comparison_predicate() where default case is missing At SqlJsonPathParser.java:where default case is missing At SqlJsonPathParser.java:[lines 2855-2895] |
| | Switch statement found in org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.member_accessor() where default case is missing At SqlJsonPathParser.java:where default case is missing At SqlJsonPathParser.java:[lines 1103-1115] |
| | Switch statement found in org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.multiplicative_expression(int) where default case is missing At SqlJsonPathParser.java:where default case is missing At SqlJsonPathParser.java:[lines 467-501] |
| | Switch statement found in org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.nondelimited_predicate() where default case is missing At SqlJsonPathParser.java:where default case is missing At SqlJsonPathParser.java:[lines 2717-2743] |
| | Switch statement found in org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.path_variable() where default case is missing At SqlJsonPathParser.java:where default case is missing At SqlJsonPathParser.java:[lines 809-828] |
| | Switch statement found in org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.predicate_primary() where default case is missing At SqlJsonPathParser.java:where default case is missing At SqlJsonPathParser.java:[lines 2585-2597] |
| | Switch statement found in org.apache.hadoop.hive.ql.udf.generic.SqlJsonPathParser.subscript() where default case is missing At SqlJsonPathParser.java:where default case is missing At SqlJsonPathParser.java:[lines 1433-1445] |
| | org.apache.hadoop.hive.ql.udf.generic.sqljsonpath.JsonSequence defines equals and uses Object.hashCode() At JsonSequence.java:Object.hashCode() At JsonSequence.java:[lines 566-570] |
| | Possible doublecheck on org.apache.hadoop.hive.ql.udf.generic.sqljsonpath.JsonSequenceCache.singleton in org.apache.hadoop.hive.ql.udf.generic.sqljsonpath.JsonSequenceCache.get() At JsonSequenceCache.java:org.apache.hadoop.hive.ql.udf.generic.sqljsonpath.JsonSequenceCache.get() At JsonSequenceCache.java:[lines 71-73] |
| | Found reliance on default encoding in org.apache.hadoop.hive.ql.udf.generic.sqljsonpath.JsonSequenceCache.hash(String):in org.apache.hadoop.hive.ql.udf.generic.sqljsonpath.JsonSequenceCache.hash(String): String.getBytes() At JsonSequenceCache.java:[line 126] |
| | Switch statement found in org.apache.hadoop.hive.ql.udf.generic.sqljsonpath.JsonSequenceCache$ByteArrayWrapper.hashCode() where one case falls through to the next case At JsonSequenceCache.java:where one case falls through to the next case At JsonSequenceCache.java:[lines 152-153] |
| | Boxing/unboxing to parse a primitive org.apache.hadoop.hive.ql.udf.generic.sqljsonpath.JsonValueParser.visitInt_literal(JsonParser$Int_literalContext) At JsonValueParser.java:org.apache.hadoop.hive.ql.udf.generic.sqljsonpath.JsonValueParser.visitInt_literal(JsonParser$Int_literalContext) At JsonValueParser.java:[line 127] |
| | Found reliance on default encoding in org.apache.hadoop.hive.ql.udf.generic.sqljsonpath.JsonValueParser.doParse(String):in org.apache.hadoop.hive.ql.udf.generic.sqljsonpath.JsonValueParser.doParse(String): String.getBytes() At JsonValueParser.java:[line 69] |
| | Dead store to val in org.apache.hadoop.hive.ql.udf.generic.sqljsonpath.PathExecutor.visitExists_path_predicate(SqlJsonPathParser$Exists_path_predicateContext) At PathExecutor.java:org.apache.hadoop.hive.ql.udf.generic.sqljsonpath.PathExecutor.visitExists_path_predicate(SqlJsonPathParser$Exists_path_predicateContext) At PathExecutor.java:[line 585] |
| | Boxing/unboxing to parse a primitive org.apache.hadoop.hive.ql.udf.generic.sqljsonpath.PathExecutor.visitMethod_int(SqlJsonPathParser$Method_intContext) At PathExecutor.java:org.apache.hadoop.hive.ql.udf.generic.sqljsonpath.PathExecutor.visitMethod_int(SqlJsonPathParser$Method_intContext) At PathExecutor.java:[line 443] |
| | Boxing/unboxing to parse a primitive org.apache.hadoop.hive.ql.udf.generic.sqljsonpath.PathExecutor.visitPath_integer_literal(SqlJsonPathParser$Path_integer_literalContext) At PathExecutor.java:org.apache.hadoop.hive.ql.udf.generic.sqljsonpath.PathExecutor.visitPath_integer_literal(SqlJsonPathParser$Path_integer_literalContext) At PathExecutor.java:[line 188] |
| | Found reliance on default encoding in org.apache.hadoop.hive.ql.udf.generic.sqljsonpath.PathExecutor.visitLike_regex_predicate(SqlJsonPathParser$Like_regex_predicateContext):in org.apache.hadoop.hive.ql.udf.generic.sqljsonpath.PathExecutor.visitLike_regex_predicate(SqlJsonPathParser$Like_regex_predicateContext): String.getBytes() At PathExecutor.java:[line 637] |
| | Found reliance on default encoding in org.apache.hadoop.hive.ql.udf.generic.sqljsonpath.PathParser.parse(String):in org.apache.hadoop.hive.ql.udf.generic.sqljsonpath.PathParser.parse(String): String.getBytes() At PathParser.java:[line 40] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc xml compile findbugs checkstyle |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-16959/dev-support/hive-personality.sh |
| git revision | master / cc8ba3a |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-16959/yetus/diff-checkstyle-ql.txt |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-16959/yetus/diff-checkstyle-root.txt |
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-16959/yetus/whitespace-eol.txt |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-16959/yetus/new-findbugs-ql.html |
| modules | C: ql hplsql . U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-16959/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Implement JSON_VALUE, JSON_QUERY, and IS [NOT] JSON
> ---------------------------------------------------
>
> Key: HIVE-21616
> URL: https://issues.apache.org/jira/browse/HIVE-21616
> Project: Hive
> Issue Type: Sub-task
> Components: UDF
> Affects Versions: 4.0.0
> Reporter: Alan Gates
> Assignee: Alan Gates
> Priority: Major
> Attachments: HIVE-21615.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)