You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whimsical.apache.org by Craig L Russell <cr...@oracle.com> on 2015/11/30 23:46:54 UTC
Patch for secmail.py
Please review this patch. It should allow gpg-signed icla.pdf forms to be properly accepted.
Thanks,
Craig
Index: secmail.py
===================================================================
--- secmail.py (revision 972524)
+++ secmail.py (working copy)
@@ -46,7 +46,7 @@
# attachment file names which always are saved, even if they come in
# with one of the 'skip' mime types.
-forms = ['pgp.txt', 'icla.txt', 'icla.txt.asc', 'membership-application.txt']
+forms = ['pgp.txt', 'icla.txt', 'icla.txt.asc', 'icla.pdf', 'icla.pdf.asc', 'membership-application.txt']
# mime types for pgp signatures
sigs = ['application/pkcs7-signature', 'application/pgp-signature']
Index: vagrant/Vagrantfile
Re: Patch for secmail.py
Posted by Sam Ruby <ru...@intertwingly.net>.
On Mon, Nov 30, 2015 at 7:45 PM, Craig L Russell
<cr...@oracle.com> wrote:
> So I committed this. How will it be put into production?
I've deployed the change by copying it to
minotaur.apache.org:/home/apmail/bin/secmail.py
See https://svn.apache.org/repos/infra/infrastructure/trunk/docs/services/secmail.txt
for details.
Note: this is the same minotaur.apache.org that is scheduled to be
retired sometime next year. One possibility is that in the future,
this code will be run on whimsy-vm, and will rsync mbox files and then
process them locally. If that is done, deployment will be done via
gitpubsub or equivalent (i.e., will happen automatically as a
consequence of a commit).
> Craig
- Sam Ruby
>> On Nov 30, 2015, at 2:59 PM, Sam Ruby <ru...@intertwingly.net> wrote:
>>
>> On Mon, Nov 30, 2015 at 5:46 PM, Craig L Russell
>> <cr...@oracle.com> wrote:
>>> Please review this patch. It should allow gpg-signed icla.pdf forms to be properly accepted.
>>
>> LGTM.
>>
>>> Thanks,
>>>
>>> Craig
>>
>> - Sam Ruby
>>
>>> Index: secmail.py
>>> ===================================================================
>>> --- secmail.py (revision 972524)
>>> +++ secmail.py (working copy)
>>> @@ -46,7 +46,7 @@
>>>
>>> # attachment file names which always are saved, even if they come in
>>> # with one of the 'skip' mime types.
>>> -forms = ['pgp.txt', 'icla.txt', 'icla.txt.asc', 'membership-application.txt']
>>> +forms = ['pgp.txt', 'icla.txt', 'icla.txt.asc', 'icla.pdf', 'icla.pdf.asc', 'membership-application.txt']
>>>
>>> # mime types for pgp signatures
>>> sigs = ['application/pkcs7-signature', 'application/pgp-signature']
>>> Index: vagrant/Vagrantfile
>>>
>>>
>>>
>>> Craig L Russell
>>> Architect, Oracle
>>> http://db.apache.org/jdo
>>> 408 276-5638 mailto:Craig.Russell@oracle.com
>>> P.S. A good JDO? O, Gasp!
>>>
>>>
>
> Craig L Russell
> Architect, Oracle
> http://db.apache.org/jdo
> 408 276-5638 mailto:Craig.Russell@oracle.com
> P.S. A good JDO? O, Gasp!
>
Re: Patch for secmail.py
Posted by Craig L Russell <cr...@oracle.com>.
So I committed this. How will it be put into production?
Craig
> On Nov 30, 2015, at 2:59 PM, Sam Ruby <ru...@intertwingly.net> wrote:
>
> On Mon, Nov 30, 2015 at 5:46 PM, Craig L Russell
> <cr...@oracle.com> wrote:
>> Please review this patch. It should allow gpg-signed icla.pdf forms to be properly accepted.
>
> LGTM.
>
>> Thanks,
>>
>> Craig
>
> - Sam Ruby
>
>> Index: secmail.py
>> ===================================================================
>> --- secmail.py (revision 972524)
>> +++ secmail.py (working copy)
>> @@ -46,7 +46,7 @@
>>
>> # attachment file names which always are saved, even if they come in
>> # with one of the 'skip' mime types.
>> -forms = ['pgp.txt', 'icla.txt', 'icla.txt.asc', 'membership-application.txt']
>> +forms = ['pgp.txt', 'icla.txt', 'icla.txt.asc', 'icla.pdf', 'icla.pdf.asc', 'membership-application.txt']
>>
>> # mime types for pgp signatures
>> sigs = ['application/pkcs7-signature', 'application/pgp-signature']
>> Index: vagrant/Vagrantfile
>>
>>
>>
>> Craig L Russell
>> Architect, Oracle
>> http://db.apache.org/jdo
>> 408 276-5638 mailto:Craig.Russell@oracle.com
>> P.S. A good JDO? O, Gasp!
>>
>>
Craig L Russell
Architect, Oracle
http://db.apache.org/jdo
408 276-5638 mailto:Craig.Russell@oracle.com
P.S. A good JDO? O, Gasp!
Re: Patch for secmail.py
Posted by Sam Ruby <ru...@intertwingly.net>.
On Mon, Nov 30, 2015 at 5:46 PM, Craig L Russell
<cr...@oracle.com> wrote:
> Please review this patch. It should allow gpg-signed icla.pdf forms to be properly accepted.
LGTM.
> Thanks,
>
> Craig
- Sam Ruby
> Index: secmail.py
> ===================================================================
> --- secmail.py (revision 972524)
> +++ secmail.py (working copy)
> @@ -46,7 +46,7 @@
>
> # attachment file names which always are saved, even if they come in
> # with one of the 'skip' mime types.
> -forms = ['pgp.txt', 'icla.txt', 'icla.txt.asc', 'membership-application.txt']
> +forms = ['pgp.txt', 'icla.txt', 'icla.txt.asc', 'icla.pdf', 'icla.pdf.asc', 'membership-application.txt']
>
> # mime types for pgp signatures
> sigs = ['application/pkcs7-signature', 'application/pgp-signature']
> Index: vagrant/Vagrantfile
>
>
>
> Craig L Russell
> Architect, Oracle
> http://db.apache.org/jdo
> 408 276-5638 mailto:Craig.Russell@oracle.com
> P.S. A good JDO? O, Gasp!
>
>