You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2014/04/01 17:32:35 UTC

Re: Review Request 19791: gmond.master.conf files are generated by Ganglia Server

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19791/
-----------------------------------------------------------

(Updated April 1, 2014, 3:32 p.m.)


Review request for Ambari and Andrew Onischuk.


Changes
-------

Fixed listed issues with tests


Bugs: AMBARI-5245
    https://issues.apache.org/jira/browse/AMBARI-5245


Repository: ambari


Description
-------

Fixed jira, also refactored RMFTestCase.py a bit 


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_monitor.py 8c63b23 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_server.py 030a627 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/params.py 65d5e66 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py f257f83 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 2cf8e7b 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/params.py d7f6e41 
  ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_monitor.py 85fceca 
  ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_server.py db48ceb 
  ambari-server/src/test/python/stacks/1.3.2/configs/default.non_gmetad_host.json PRE-CREATION 
  ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 8a21873 
  ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py 02694bc 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json c835c94 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json  
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_rest_api_service.py 8983882 
  ambari-server/src/test/python/stacks/utils/RMFTestCase.py b5adcbd 

Diff: https://reviews.apache.org/r/19791/diff/


Testing
-------

Tried installing 1.3.2 and 2.1 stacks, also tried 2-node cluster setup.

----------------------------------------------------------------------
Ran 190 tests in 0.460s

OK
----------------------------------------------------------------------
Total run:506
Total errors:0
Total failures:0
OK


Thanks,

Dmitro Lisnichenko


Re: Review Request 19791: gmond.master.conf files are generated by Ganglia Server

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19791/#review39163
-----------------------------------------------------------

Ship it!


Ship It!

- Andrew Onischuk


On April 1, 2014, 3:32 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19791/
> -----------------------------------------------------------
> 
> (Updated April 1, 2014, 3:32 p.m.)
> 
> 
> Review request for Ambari and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-5245
>     https://issues.apache.org/jira/browse/AMBARI-5245
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixed jira, also refactored RMFTestCase.py a bit 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_monitor.py 8c63b23 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_server.py 030a627 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/params.py 65d5e66 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py f257f83 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 2cf8e7b 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/params.py d7f6e41 
>   ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_monitor.py 85fceca 
>   ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_server.py db48ceb 
>   ambari-server/src/test/python/stacks/1.3.2/configs/default.non_gmetad_host.json PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 8a21873 
>   ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py 02694bc 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json c835c94 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json  
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_rest_api_service.py 8983882 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py b5adcbd 
> 
> Diff: https://reviews.apache.org/r/19791/diff/
> 
> 
> Testing
> -------
> 
> Tried installing 1.3.2 and 2.1 stacks, also tried 2-node cluster setup.
> 
> ----------------------------------------------------------------------
> Ran 190 tests in 0.460s
> 
> OK
> ----------------------------------------------------------------------
> Total run:506
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>