You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/21 08:33:20 UTC
[jira] [Commented] (CB-11694) hardwareback value persists across
usages
[ https://issues.apache.org/jira/browse/CB-11694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509207#comment-15509207 ]
ASF GitHub Bot commented on CB-11694:
-------------------------------------
GitHub user matrosovN opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/188
CB-11694 Android: Set hadwareBackButton value according option in cor…
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
HadwareBackButton value persists across usages. By default hardwareBack value is null. In this case we should set hadwareBackButton to default value.
### What testing has been done on this change?
Manual test
### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secretary@apache.org.
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosovN/cordova-plugin-inappbrowser CB-11694
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/188.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #188
----
commit 71cf378af0a111e94fa4c94f2deb092ca65d3cf4
Author: Nikita Matrosov <ni...@rp.ru>
Date: 2016-09-20T07:23:37Z
CB-11694 Android: Set hadwareBackButton value according option in cordova.InAppBrowser.open
HadwareBackButton value persists across usages. By default hardwareBack value is null. In this case we should set hadwareBackButton to default value.
----
> hardwareback value persists across usages
> -----------------------------------------
>
> Key: CB-11694
> URL: https://issues.apache.org/jira/browse/CB-11694
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin InAppBrowser
> Affects Versions: 1.4.0
> Reporter: Jacob Weber
> Priority: Minor
> Labels: Android, android, triaged
>
> 1. Open an InAppBrowser without passing hardwareback. It will use the default value ("yes"), so the hardware Back button will take you back in history.
> 2. Open an InAppBrowser and pass hardwareback=no. The hardware Back button will close the browser.
> 3. Open an InAppBrowser without passing hardwareback. It will now use the previous value ("no"), so the hardware Back button will take you back in history. It should go back to the default value ("yes").
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org