[GitHub] [superset] suddjian commented on a change in pull request #18682: feat: It is possible to pass attributes to embedded iframe

[GitBox <gi...@apache.org>]

suddjian commented on a change in pull request #18682:
URL: https://github.com/apache/superset/pull/18682#discussion_r807333731



##########
File path: superset-embedded-sdk/src/index.ts
##########
@@ -36,6 +36,8 @@ export type EmbedDashboardParams = {
   supersetDomain: string
   /** The html element within which to mount the iframe */
   mountPoint: HTMLElement
+  /** An id to identify the create iframe that will embed Superset */
+  iframeAttributes: Map<string, string> 

Review comment:
       This will require instantiating a `Map()` object. We should probably allow passing key-value pairs such as `{ class: "some-class" }`. Let's change the type to use `Record` which represents this. (This will also require changing the `forEach` construction below)
   
   ```suggestion
     iframeAttributes: Record<string, string> 
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org