You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "amanraj2520 (via GitHub)" <gi...@apache.org> on 2024/01/24 06:55:39 UTC
[PR] Branch 3 hive 24808 new [hive]
amanraj2520 opened a new pull request, #5029:
URL: https://github.com/apache/hive/pull/5029
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### Is the change a dependency upgrade?
<!--
If yes, please attach a file with output from mvn dependency:tree to validate a complete upgrade of dependency.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28068 : Backport of HIVE-24808, HIVE-24811, HIVE-22476, HIVE-25299, HIVE-22200, HIVE-21544, HIVE-22841, HIVE-20292, HIVE-17040, HIVE-20718, HIVE-20193 [hive]
Posted by "sankarh (via GitHub)" <gi...@apache.org>.
sankarh commented on code in PR #5029:
URL: https://github.com/apache/hive/pull/5029#discussion_r1485824426
##########
ql/src/test/results/clientpositive/llap/vector_case_when_2.q.out:
##########
@@ -272,49 +272,49 @@ ctimestamp1 ctimestamp2 ctimestamp2_description ctimestamp2_description_2 ctimes
1815-05-06 00:12:37.543584705 1815-05-04 22:09:33.543584705 1900s Old Old 1815 2018-03-08 23:04:59 12 NULL 1816-05-05
1883-04-17 04:14:34.647766229 1883-04-16 02:11:30.647766229 1900s Old Old 1883 2018-03-08 23:04:59 14 NULL 1884-04-16
1966-08-16 13:36:50.183618031 1966-08-15 11:33:46.183618031 Early 2010s Old Old 1966 1966-08-16 13:36:50.183618031 36 NULL 1967-08-16
-1973-04-17 06:30:38.596784156 1973-04-16 04:27:34.596784156 Early 2010s Old Old 1973 1973-04-17 06:30:38.596784156 30 NULL 1973-04-18
+1973-04-17 06:30:38.596784156 1973-04-16 04:27:34.596784156 Early 2010s Old Old 1973 1973-04-17 06:30:38.596784156 30 NULL 1974-04-17
Review Comment:
Why these outputs are different from original patch?
##########
ql/src/test/results/clientpositive/spark/timestamp_1.q.out:
##########
@@ -257,7 +329,7 @@ POSTHOOK: query: select cast(t as double) from timestamp_1 limit 1
POSTHOOK: type: QUERY
POSTHOOK: Input: default@timestamp_1
#### A masked pattern was here ####
-1.2938436611E9
+1.293843661E9
Review Comment:
Why is this output changed? Apparently not in original patches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28068 : Backport of HIVE-24808, HIVE-24811, HIVE-22476, HIVE-25299, HIVE-22200, HIVE-21544, HIVE-22841, HIVE-20292, HIVE-17040, HIVE-20718, HIVE-20193 [hive]
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on code in PR #5029:
URL: https://github.com/apache/hive/pull/5029#discussion_r1487201730
##########
ql/src/test/results/clientpositive/spark/timestamp_1.q.out:
##########
@@ -257,7 +329,7 @@ POSTHOOK: query: select cast(t as double) from timestamp_1 limit 1
POSTHOOK: type: QUERY
POSTHOOK: Input: default@timestamp_1
#### A masked pattern was here ####
-1.2938436611E9
+1.293843661E9
Review Comment:
This is because is oss master this test did not run in spark cli driver. This output was changed in llap therefore required in spark as well. This was done to make both q.out same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28068 : Backport of HIVE-24808, HIVE-24811, HIVE-22476, HIVE-25299, HIVE-22200, HIVE-21544, HIVE-22841, HIVE-20292, HIVE-17040, HIVE-20718, HIVE-20193 [hive]
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on code in PR #5029:
URL: https://github.com/apache/hive/pull/5029#discussion_r1489300129
##########
ql/src/test/results/clientpositive/llap/vector_case_when_2.q.out:
##########
@@ -272,49 +272,49 @@ ctimestamp1 ctimestamp2 ctimestamp2_description ctimestamp2_description_2 ctimes
1815-05-06 00:12:37.543584705 1815-05-04 22:09:33.543584705 1900s Old Old 1815 2018-03-08 23:04:59 12 NULL 1816-05-05
1883-04-17 04:14:34.647766229 1883-04-16 02:11:30.647766229 1900s Old Old 1883 2018-03-08 23:04:59 14 NULL 1884-04-16
1966-08-16 13:36:50.183618031 1966-08-15 11:33:46.183618031 Early 2010s Old Old 1966 1966-08-16 13:36:50.183618031 36 NULL 1967-08-16
-1973-04-17 06:30:38.596784156 1973-04-16 04:27:34.596784156 Early 2010s Old Old 1973 1973-04-17 06:30:38.596784156 30 NULL 1973-04-18
+1973-04-17 06:30:38.596784156 1973-04-16 04:27:34.596784156 Early 2010s Old Old 1973 1973-04-17 06:30:38.596784156 30 NULL 1974-04-17
Review Comment:
The commit HIVE-20007 was ported after this commit in OSS master. If we see the diff before that commit in oss master, it is the same as in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28068 : Backport of HIVE-24808, HIVE-24811, HIVE-22476, HIVE-25299, HIVE-22200, HIVE-21544, HIVE-22841, HIVE-20292, HIVE-17040, HIVE-20718, HIVE-20193 [hive]
Posted by "sankarh (via GitHub)" <gi...@apache.org>.
sankarh merged PR #5029:
URL: https://github.com/apache/hive/pull/5029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org