You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/10/07 01:40:00 UTC
[jira] [Commented] (IMPALA-10862) Optimization of the code
structure of TmpDir
[ https://issues.apache.org/jira/browse/IMPALA-10862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425309#comment-17425309 ]
ASF subversion and git services commented on IMPALA-10862:
----------------------------------------------------------
Commit 5e3d4391906b09adb97ba6d036811aaf81f5a403 in impala's branch refs/heads/master from Yida Wu
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=5e3d439 ]
IMPALA-10862 Optimization of the code structure of TmpDir
Currently the logic of initialization of TmpFileMgr is a bit tedious.
This patch simplifies TmpFileMgr::InitCustom() by refactoring parsing
and validation logic.
The patch adds TmpDirLocal, TmpDirHdfs and TmpDirS3 to inherit TmpDir
to implement their own logic to parse and validate. It enables easier
addition of custom logic for future filesystems.
All changes only affect the interfaces within the TmpFileMgr module,
and the main logic of the scratch directory parsing and verification
doesn't change.
Tests:
Ran the Core tests and exhaustive e2e tests.
Because the current testcases of TmpFileMgrTest already cover the
TmpDir parsing and verification, no testcases may need to be added
for this structure optimization. Added some S3 directory parsing
failure testcases.
Change-Id: I52971238d5841a1cdfee06b38750f9dc99a6a2be
Reviewed-on: http://gerrit.cloudera.org:8080/17778
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Optimization of the code structure of TmpDir
> --------------------------------------------
>
> Key: IMPALA-10862
> URL: https://issues.apache.org/jira/browse/IMPALA-10862
> Project: IMPALA
> Issue Type: Improvement
> Reporter: Yida Wu
> Assignee: Yida Wu
> Priority: Minor
>
> Currently the logic of Initialization of TmpFileMgr is a bit tedious, we can have the TmpDir to parse and validate, and also be inherited by TmpDirHdfs and TmpDirS3 to have their own logic to parse and validate, in this way, the code could have a better structure and be easier to add more custom logic for other filesystems in future.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org