You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2023/04/03 16:55:05 UTC

[GitHub] [arrow-datafusion-python] andygrove commented on a diff in pull request #312: Try fix ci

andygrove commented on code in PR #312:
URL: https://github.com/apache/arrow-datafusion-python/pull/312#discussion_r1156217932


##########
Cargo.toml:
##########
@@ -35,12 +35,13 @@ default = ["mimalloc"]
 tokio = { version = "1.24", features = ["macros", "rt", "rt-multi-thread", "sync"] }
 rand = "0.8"
 pyo3 = { version = "0.18.1", features = ["extension-module", "abi3", "abi3-py37"] }
-datafusion = { git = "https://github.com/apache/arrow-datafusion.git", rev = "c09edad", features = ["pyarrow", "avro"] }
-datafusion-common = { git = "https://github.com/apache/arrow-datafusion.git", rev = "c09edad", features = ["pyarrow"] }
-datafusion-expr = { git = "https://github.com/apache/arrow-datafusion.git", rev = "c09edad" }
-datafusion-optimizer = { git = "https://github.com/apache/arrow-datafusion.git", rev = "c09edad" }
-datafusion-sql = { git = "https://github.com/apache/arrow-datafusion.git", rev = "c09edad" }
-datafusion-substrait = { git = "https://github.com/apache/arrow-datafusion.git", rev = "c09edad" }
+# point to my branch for testing, but will point to apache repo once the PR is merged
+datafusion = { git = "https://github.com/andygrove/arrow-datafusion.git", branch = "substrait-protoc", features = ["pyarrow", "avro"] }
+datafusion-common = { git = "https://github.com/andygrove/arrow-datafusion.git", branch = "substrait-protoc", features = ["pyarrow"] }
+datafusion-expr = { git = "https://github.com/andygrove/arrow-datafusion.git", branch = "substrait-protoc" }
+datafusion-optimizer = { git = "https://github.com/andygrove/arrow-datafusion.git", branch = "substrait-protoc" }
+datafusion-sql = { git = "https://github.com/andygrove/arrow-datafusion.git", branch = "substrait-protoc" }
+datafusion-substrait = { git = "https://github.com/andygrove/arrow-datafusion.git", branch = "substrait-protoc", features = ["protoc"] }

Review Comment:
   The main change is enabling the `protoc` feature here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org