You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by GitBox <gi...@apache.org> on 2020/09/21 10:44:54 UTC
[GitHub] [karaf] rmannibucau opened a new pull request #1198: rewrite the CicularBuffer to reduce logservice overhead
rmannibucau opened a new pull request #1198:
URL: https://github.com/apache/karaf/pull/1198
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] rmannibucau commented on pull request #1198: rewrite the CicularBuffer to reduce logservice overhead
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #1198:
URL: https://github.com/apache/karaf/pull/1198#issuecomment-707519338
@wborn can you test https://github.com/apache/karaf/pull/1221 please ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] wborn edited a comment on pull request #1198: rewrite the CicularBuffer to reduce logservice overhead
Posted by GitBox <gi...@apache.org>.
wborn edited a comment on pull request #1198:
URL: https://github.com/apache/karaf/pull/1198#issuecomment-707387167
I just did some testing with Karaf 4.2.10 and it seems that `log:tail` command now often does not show any history. Also if you specify the number of lines e.g. with `log:tail -n 10` it doesn't show logging. Only if I increase the count to a high number e.g. `log:tail -n 1000` it shows logging. Perhaps it's caused by this change. I tested using the [apache-karaf-4.2.10.tar.gz](http://www.apache.org/dyn/closer.lua/karaf/4.2.10/apache-karaf-4.2.10.tar.gz). It does seem to work as expected with Karaf 4.2.9.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre commented on pull request #1198: rewrite the CicularBuffer to reduce logservice overhead
Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #1198:
URL: https://github.com/apache/karaf/pull/1198#issuecomment-707474222
Thanks, I'm reverting the change then for investigation (I didn't see the issue).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre merged pull request #1198: rewrite the CicularBuffer to reduce logservice overhead
Posted by GitBox <gi...@apache.org>.
jbonofre merged pull request #1198:
URL: https://github.com/apache/karaf/pull/1198
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre commented on pull request #1198: rewrite the CicularBuffer to reduce logservice overhead
Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #1198:
URL: https://github.com/apache/karaf/pull/1198#issuecomment-707860885
I will do the quick fix for line count. Thanks !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] wborn edited a comment on pull request #1198: rewrite the CicularBuffer to reduce logservice overhead
Posted by GitBox <gi...@apache.org>.
wborn edited a comment on pull request #1198:
URL: https://github.com/apache/karaf/pull/1198#issuecomment-707387167
I just did some testing with Karaf 4.2.10 and it seems that the `log:tail` command now often does not show any history (it should show 50 lines by default). Also if you specify the number of lines e.g. with `log:tail -n 10` it doesn't show logging. Only if I increase the count to a high number e.g. `log:tail -n 1000` it shows logging. Perhaps it's caused by this change. I tested using the [apache-karaf-4.2.10.tar.gz](http://www.apache.org/dyn/closer.lua/karaf/4.2.10/apache-karaf-4.2.10.tar.gz). It does seem to work as expected with Karaf 4.2.9.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] wborn edited a comment on pull request #1198: rewrite the CicularBuffer to reduce logservice overhead
Posted by GitBox <gi...@apache.org>.
wborn edited a comment on pull request #1198:
URL: https://github.com/apache/karaf/pull/1198#issuecomment-707387167
I just did some testing with Karaf 4.2.10 and it seems that `log:tail` command now often does not show any history. Also if you specific the number of lines e.g. with `log:tail -n 10` it doesn't show logging. Only if I increase the count to a high number e.g. `log:tail -n 1000` it shows logging. Perhaps it's caused by this change. I tested using the [apache-karaf-4.2.10.tar.gz](http://www.apache.org/dyn/closer.lua/karaf/4.2.10/apache-karaf-4.2.10.tar.gz). It does seem to work as expected with Karaf 4.2.9.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] wborn commented on pull request #1198: rewrite the CicularBuffer to reduce logservice overhead
Posted by GitBox <gi...@apache.org>.
wborn commented on pull request #1198:
URL: https://github.com/apache/karaf/pull/1198#issuecomment-707859801
I gave the fix a test on the 4.2.x branch and it seems to work well again! :+1:
A minor issue is that the line count doesn't match the parameter:
```
karaf@root()> log:tail -n 1
18:24:01.071 INFO [CM Configuration Updater (Update: pid=org.ops4j.pax.logging)] Sending Event Admin notification (configuration successful) to org/ops4j/pax/logging/Configuration
18:24:11.917 INFO [CM Configuration Updater (Update: pid=org.ops4j.pax.logging)] Sending Event Admin notification (configuration successful) to org/ops4j/pax/logging/Configuration
^C~
karaf@root()> log:tail -n 2
18:24:11.917 INFO [CM Configuration Updater (Update: pid=org.ops4j.pax.logging)] Sending Event Admin notification (configuration successful) to org/ops4j/pax/logging/Configuration
18:24:12.936 INFO [CM Configuration Updater (Update: pid=org.ops4j.pax.logging)] Sending Event Admin notification (configuration successful) to org/ops4j/pax/logging/Configuration
18:24:15.769 INFO [CM Configuration Updater (Update: pid=org.ops4j.pax.logging)] Sending Event Admin notification (configuration successful) to org/ops4j/pax/logging/Configuration
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] wborn edited a comment on pull request #1198: rewrite the CicularBuffer to reduce logservice overhead
Posted by GitBox <gi...@apache.org>.
wborn edited a comment on pull request #1198:
URL: https://github.com/apache/karaf/pull/1198#issuecomment-707387167
I just did some testing with Karaf 4.2.10 and it seems that the `log:tail` command now often does not show any history. Also if you specify the number of lines e.g. with `log:tail -n 10` it doesn't show logging. Only if I increase the count to a high number e.g. `log:tail -n 1000` it shows logging. Perhaps it's caused by this change. I tested using the [apache-karaf-4.2.10.tar.gz](http://www.apache.org/dyn/closer.lua/karaf/4.2.10/apache-karaf-4.2.10.tar.gz). It does seem to work as expected with Karaf 4.2.9.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre merged pull request #1198: rewrite the CicularBuffer to reduce logservice overhead
Posted by GitBox <gi...@apache.org>.
jbonofre merged pull request #1198:
URL: https://github.com/apache/karaf/pull/1198
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] wborn commented on pull request #1198: rewrite the CicularBuffer to reduce logservice overhead
Posted by GitBox <gi...@apache.org>.
wborn commented on pull request #1198:
URL: https://github.com/apache/karaf/pull/1198#issuecomment-707387167
I just did some testing with Karaf 4.2.10 and it seems that that `log:tail` command now often does not show any history. Also if you specific the number of lines e.g. with `log:tail -n 10` it doesn't show logging. Only if I increase the count to a high number e.g. `log:tail -n 1000` it shows logging. Perhaps it's caused by this change. I tested using the [apache-karaf-4.2.10.tar.gz](http://www.apache.org/dyn/closer.lua/karaf/4.2.10/apache-karaf-4.2.10.tar.gz). It does seem to work as expected with Karaf 4.2.9.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org