[GitHub] [sqoop] szvasas commented on issue #81: SQOOP-3441 Prepare Sqoop for Java 11 support

[GitBox <gi...@apache.org>]

szvasas commented on issue #81: SQOOP-3441 Prepare Sqoop for Java 11 support
URL: https://github.com/apache/sqoop/pull/81#issuecomment-499135494
 
 
   Hi Feró,
   
   Thanks for submitting this improvement, unfortunately I don't have time to post a full review just had one comment on the Gradle upgrade.
   Since we have the following wrapper task defined in build.gradle I think it would be good to maintain the version number in it:
   ```
   wrapper {
       gradleVersion = '4.9'
   }
   ```
   Then running `./gradlew wrapper` to make sure everything is fully updated to the version specified.
   There are also some guidelines provided here: https://docs.gradle.org/current/userguide/gradle_wrapper.html#sec:upgrading_wrapper
   
   (We could also remove the wrapper task and just run `./gradlew wrapper --gradle-version <version>` in the future.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services