You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/06/09 03:00:38 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3871: arch: adjust idle stack offset to reserve space of stack info

xiaoxiang781216 commented on pull request #3871:
URL: https://github.com/apache/incubator-nuttx/pull/3871#issuecomment-857333901


   > @anchao - I think the arguments go something like this:
   > 
   > 1 ) "If we change internals, the users configuration should not be broken"
   > 2) "Be consistent".
   > 
   > That said the call stack penetration on idle has grown a LOT since joining ASF.
   > 
   > I not a fan of not wasting peoples time trying to guess how to size the stacks. If a user asks for 4096 for the stack it should be 4096 (or rounded up) as it has always been.
   > 
   > So yes I do insist (as I did on the original PR) but I am open to hearing the counter argument.
   
   The additional size cost come from other PR, this PR just try to fix the regression introduced by that PR. Let's dissuss it in a new issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org