You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/15 01:53:14 UTC

[GitHub] [pulsar] mans2singh opened a new pull request, #16067: [hotfix][docs] Corrected comment in shared consumer section

mans2singh opened a new pull request, #16067:
URL: https://github.com/apache/pulsar/pull/16067

   
   ### Motivation
   
   * The shared consumer example comment indicates <code>Both consumer1 and **consumer 2 is** active consumers</code>
   
   ### Modifications
   
   * Updated comment section to refer to the proper variable <code>Both consumer1 and **consumer2 are** active consumers</code>
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: no
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: no
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [ ] `doc-not-needed` 
   (Please explain why)
     
   - [x] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #16067: [fix][docs] Corrected comment in shared consumer section

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #16067:
URL: https://github.com/apache/pulsar/pull/16067#issuecomment-1156093828

   @mans2singh thanks for your contribution! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mans2singh commented on pull request #16067: [fix][docs] Corrected comment in shared consumer section

Posted by GitBox <gi...@apache.org>.
mans2singh commented on PR #16067:
URL: https://github.com/apache/pulsar/pull/16067#issuecomment-1155916388

   Thanks @Anonymitaet for your time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet merged pull request #16067: [fix][docs] Corrected comment in shared consumer section

Posted by GitBox <gi...@apache.org>.
Anonymitaet merged PR #16067:
URL: https://github.com/apache/pulsar/pull/16067


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org