[jira] [Commented] (BIGTOP-1048) ZooKeeper installation use "zookeeper-server.pid" as default while ZooKeeper expects zookeeper_server.pid

["Sean Mackrory (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737193#comment-13737193 ] 

Sean Mackrory commented on BIGTOP-1048:
---------------------------------------

The change seems safe enough and consistency would be good, but for the sake of testing, could you elaborate on whether or not this caused any functional problems? As far as I can see, ZooKeeper's scripts also expect the PID file to be in the data directory, which we set to /var/lib/zookeeper (whereas currently the PID file is stored under /var/run/zookeeper), so I'm curious to know how this patch changes the behavior of ZooKeeper.
                
> ZooKeeper installation use "zookeeper-server.pid" as default while ZooKeeper expects zookeeper_server.pid
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: BIGTOP-1048
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1048
>             Project: Bigtop
>          Issue Type: Bug
>    Affects Versions: 0.5.0
>            Reporter: Jeffrey Zhong
>         Attachments: bigtop-1048.patch
>
>
> In ZooKeeper file ./bin/zkServer.sh, it uses 'zookeeper_server.pid' as default pid file name like the following:
> {code}
> ZOOPIDFILE="$ZOO_DATADIR/zookeeper_server.pid"
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira