[jira] [Comment Edited] (WICKET-6485) IllegalArgumentException: Argument 'pageClass' may not be null

["Andrea Del Bene (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-6485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212328#comment-16212328 ] 

Andrea Del Bene edited comment on WICKET-6485 at 10/20/17 8:10 AM:
-------------------------------------------------------------------

Hi all,

the problem is that after WICKET-4201 neither PageProvider#getPageInstance nor PageProvider#getPageClass check if page has been expired. This check has been moved in ListenerRequestHandler#getPage() but this is not enough. We should add a similar check also in RenderPageRequestHandler#respond. This fixes the issue but I'm not completely sure this is the right way to go. I haven't followed the development of WICKET-4201 so I'm not sure about its initial goal.

PS: to reproduce the error it's enough to start a Wicket application and then type 'http://localhost:8080/wicket/page?1'. The page with the given id (might be > 1) is not found (it's expired) but we get the IllegalArgumentException instead.


was (Author: bitstorm):
Hi all,

the problem is that after WICKET-4201 neither PageProvider#getPageInstance nor PageProvider#getPageClass check if page has been expired. This check has been moved in ListenerRequestHandler#getPage() but this is not enough. We should add a similar check also in RenderPageRequestHandler#respond. This fixes the issue but I'm not completely sure this is the right way to go. I haven't followed the development of WICKET-4201 so I'm not sure about its initial goal.

> IllegalArgumentException: Argument 'pageClass' may not be null
> --------------------------------------------------------------
>
>                 Key: WICKET-6485
>                 URL: https://issues.apache.org/jira/browse/WICKET-6485
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 8.0.0-M7
>            Reporter: Francois
>            Assignee: Andrea Del Bene
>            Priority: Minor
>         Attachments: quickstart.zip
>
>
> If I bookmark a stateful page, close the browser, reopen it and click on the bookmark
> I get an IllegalArgumentException
> java.lang.IllegalArgumentException: Argument 'pageClass' may not be null.
>      at org.apache.wicket.util.lang.Args.notNull(Args.java:41)
>      at org.apache.wicket.core.request.mapper.AbstractBookmarkableMapper$UrlInfo.<init>(AbstractBookmarkableMapper.java:90)
>      at org.apache.wicket.core.request.mapper.AbstractBookmarkableMapper.mapHandler(AbstractBookmarkableMapper.java:410)
>      at org.apache.wicket.request.mapper.CompoundRequestMapper.mapHandler(CompoundRequestMapper.java:210)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)