You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "KeDeng (Code Review)" <ge...@cloudera.org> on 2022/12/19 03:47:29 UTC

[kudu-CR] [log] Reduce prompt log printing frequency

KeDeng has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19375


Change subject: [log] Reduce prompt log printing frequency
......................................................................

[log] Reduce prompt log printing frequency

I notice the UpdateStats() function print too frequently
for the trash table. If we can reduce the frequency of
these duplicate logs, it will help us solve the problem
better.

Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
---
M src/kudu/tablet/tablet_mm_ops.cc
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/19375/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19375 )

Change subject: [log] Reduce prompt log printing frequency
......................................................................

[log] Reduce prompt log printing frequency

I notice the UpdateStats() function prints too frequently
for the soft-deleted tables, or the tables that compaction
disabled manually. If we can reduce the frequency of these
duplicate logs, it will help us find useful information in
the log more quickly.

So I added a new flag '--update_stats_log_throttling_interval_sec'
to control the printing frequency in UpdateStats() function.

Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Reviewed-on: http://gerrit.cloudera.org:8080/19375
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/tablet/tablet_mm_ops.cc
M src/kudu/tablet/tablet_replica_mm_ops.cc
2 files changed, 15 insertions(+), 7 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 12
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19375

to look at the new patch set (#3).

Change subject: [log] Reduce prompt log printing frequency
......................................................................

[log] Reduce prompt log printing frequency

I notice the UpdateStats() function print too frequently
for the trash table. If we can reduce the frequency of
these duplicate logs, it will help us solve the problem
better.
So I added a new flag '--update_stats_print_prompt_log_interval_s'
to control the printing frequency in UpdateStats() function.

Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
---
M src/kudu/tablet/tablet_mm_ops.cc
1 file changed, 7 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/19375/3
-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19375 )

Change subject: [log] Reduce prompt log printing frequency
......................................................................


Patch Set 9:

(5 comments)

Thanks for your reviews.

http://gerrit.cloudera.org:8080/#/c/19375/7//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19375/7//COMMIT_MSG@9
PS7, Line 9: print
> prints
Done


http://gerrit.cloudera.org:8080/#/c/19375/7//COMMIT_MSG@10
PS7, Line 10: tables tha
> Could you be more specific here: what type of compaction was disabled?
I means those tables with compaction disabled manually.


http://gerrit.cloudera.org:8080/#/c/19375/7//COMMIT_MSG@10
PS7, Line 10: mpactio
> disabled
Done


http://gerrit.cloudera.org:8080/#/c/19375/7//COMMIT_MSG@12
PS7, Line 12: l help us find use
> What problem are we talking about here?
I mean, the problems that affect our ability to find useful information.


http://gerrit.cloudera.org:8080/#/c/19375/7/src/kudu/tablet/tablet_mm_ops.cc
File src/kudu/tablet/tablet_mm_ops.cc:

http://gerrit.cloudera.org:8080/#/c/19375/7/src/kudu/tablet/tablet_mm_ops.cc@93
PS7, Line 93: thrott
> I'm not sure I understand what you meant by 'prompt' here.  From what I can
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 9
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Tue, 20 Dec 2022 07:24:25 +0000
Gerrit-HasComments: Yes

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19375 )

Change subject: [log] Reduce prompt log printing frequency
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19375/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19375/1//COMMIT_MSG@9
PS1, Line 9: too frequently
           : for the trash table
> I'd think that printing every 5 minutes might be more rarely than printing 
Do you mean that I continue to use the function, just adjust the time frequency? This is one way. However, I found that when the system is normal, the printing here may occur every ten minutes, but there is hardly any other printing during this period. Therefore, I want to adjust the basis of printing to count, not time.



-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 19 Dec 2022 06:32:53 +0000
Gerrit-HasComments: Yes

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19375 )

Change subject: [log] Reduce prompt log printing frequency
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19375/5/src/kudu/tablet/tablet_mm_ops.cc
File src/kudu/tablet/tablet_mm_ops.cc:

http://gerrit.cloudera.org:8080/#/c/19375/5/src/kudu/tablet/tablet_mm_ops.cc@92
PS5, Line 92: 600
> I guess Alexey meant change it to a flag in minute unit? I agree that we do
I meant exactly what's been done: round the default value of the flag to minutes, 500 --> 600.  So, this piece looks good to me as of PS7.

Thanks!



-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 7
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Tue, 20 Dec 2022 05:19:12 +0000
Gerrit-HasComments: Yes

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19375 )

Change subject: [log] Reduce prompt log printing frequency
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19375/7//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19375/7//COMMIT_MSG@14
PS7, Line 14: update_stats_print_prompt_log_interval_s
There are some more cases in src/kudu/tablet/tablet_replica_mm_ops.cc we have to deal with?


http://gerrit.cloudera.org:8080/#/c/19375/5/src/kudu/tablet/tablet_mm_ops.cc
File src/kudu/tablet/tablet_mm_ops.cc:

http://gerrit.cloudera.org:8080/#/c/19375/5/src/kudu/tablet/tablet_mm_ops.cc@92
PS5, Line 92: 600
> Done
I guess Alexey meant change it to a flag in minute unit? I agree that we don't need such a accurate control in seconds.



-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 7
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Tue, 20 Dec 2022 04:50:16 +0000
Gerrit-HasComments: Yes

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19375 )

Change subject: [log] Reduce prompt log printing frequency
......................................................................


Patch Set 2:

(1 comment)

Thanks for your reviews.

http://gerrit.cloudera.org:8080/#/c/19375/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19375/1//COMMIT_MSG@9
PS1, Line 9: too frequently
           : for the trash table
> If there are too many trashed tablets, KLOG_EVERY_N will print more frequen
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Mon, 19 Dec 2022 08:14:01 +0000
Gerrit-HasComments: Yes

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19375 )

Change subject: [log] Reduce prompt log printing frequency
......................................................................


Patch Set 7:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/19375/7//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19375/7//COMMIT_MSG@9
PS7, Line 9: print
prints


http://gerrit.cloudera.org:8080/#/c/19375/7//COMMIT_MSG@10
PS7, Line 10: compaction
Could you be more specific here: what type of compaction was disabled?


http://gerrit.cloudera.org:8080/#/c/19375/7//COMMIT_MSG@10
PS7, Line 10: disable
disabled


http://gerrit.cloudera.org:8080/#/c/19375/7//COMMIT_MSG@12
PS7, Line 12: the problem better
What problem are we talking about here?


http://gerrit.cloudera.org:8080/#/c/19375/7/src/kudu/tablet/tablet_mm_ops.cc
File src/kudu/tablet/tablet_mm_ops.cc:

http://gerrit.cloudera.org:8080/#/c/19375/7/src/kudu/tablet/tablet_mm_ops.cc@93
PS7, Line 93: prompt
I'm not sure I understand what you meant by 'prompt' here.  From what I can see in this patch, I'd think of the following description for this flag:

  Log throttling interval for messages on disabled compaction emitted by UpdateStats method.



-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 7
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Tue, 20 Dec 2022 06:36:11 +0000
Gerrit-HasComments: Yes

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19375

to look at the new patch set (#11).

Change subject: [log] Reduce prompt log printing frequency
......................................................................

[log] Reduce prompt log printing frequency

I notice the UpdateStats() function prints too frequently
for the soft-deleted tables, or the tables that compaction
disabled manually. If we can reduce the frequency of these
duplicate logs, it will help us find useful information in
the log more quickly.

So I added a new flag '--update_stats_log_throttling_interval_sec'
to control the printing frequency in UpdateStats() function.

Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
---
M src/kudu/tablet/tablet_mm_ops.cc
M src/kudu/tablet/tablet_replica_mm_ops.cc
2 files changed, 15 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/19375/11
-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 11
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19375

to look at the new patch set (#4).

Change subject: [log] Reduce prompt log printing frequency
......................................................................

[log] Reduce prompt log printing frequency

I notice the UpdateStats() function print too frequently
for the trash table. If we can reduce the frequency of
these duplicate logs, it will help us solve the problem
better.
So I added a new flag '--update_stats_print_prompt_log_interval_s'
to control the printing frequency in UpdateStats() function.

Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
---
M src/kudu/tablet/tablet_mm_ops.cc
1 file changed, 7 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/19375/4
-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 4
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19375

to look at the new patch set (#5).

Change subject: [log] Reduce prompt log printing frequency
......................................................................

[log] Reduce prompt log printing frequency

I notice the UpdateStats() function print too frequently
for the trash table. If we can reduce the frequency of
these duplicate logs, it will help us solve the problem
better.
So I added a new flag '--update_stats_print_prompt_log_interval_s'
to control the printing frequency in UpdateStats() function.

Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
---
M src/kudu/tablet/tablet_mm_ops.cc
1 file changed, 7 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/19375/5
-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 5
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19375 )

Change subject: [log] Reduce prompt log printing frequency
......................................................................


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/19375/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19375/1//COMMIT_MSG@9
PS1, Line 9: too frequently
           : for the trash table
> Do you mean that I continue to use the function, just adjust the time frequ
If the inputs for the UpdateStats() changes, it might start printing much more often that you'd expect (by default the interval to re-check compaction ops by the maintenance manager is 250ms).  Also, printing based on the count might backfire, as Yuingchun mentioned.


http://gerrit.cloudera.org:8080/#/c/19375/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19375/5//COMMIT_MSG@9
PS5, Line 9: UpdateStats() function print too frequently
But that's only in case of disabling particular type of compaction, isn't it?


http://gerrit.cloudera.org:8080/#/c/19375/5//COMMIT_MSG@10
PS5, Line 10: trash table
What is 'trash table'?


http://gerrit.cloudera.org:8080/#/c/19375/5/src/kudu/tablet/tablet_mm_ops.cc
File src/kudu/tablet/tablet_mm_ops.cc:

http://gerrit.cloudera.org:8080/#/c/19375/5/src/kudu/tablet/tablet_mm_ops.cc@92
PS5, Line 92: 
Maybe, make it something to be round in the number of minutes?  If you don't like 300, then 600 might be a good option.


http://gerrit.cloudera.org:8080/#/c/19375/5/src/kudu/tablet/tablet_mm_ops.cc@380
PS5, Line 380: 
Don't you want to update this to be configurable as well?



-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Mon, 19 Dec 2022 18:14:07 +0000
Gerrit-HasComments: Yes

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19375 )

Change subject: [log] Reduce prompt log printing frequency
......................................................................


Patch Set 9: Code-Review+1

(2 comments)

Overall looks good, just a nit on the naming of the flag.

Thanks!

http://gerrit.cloudera.org:8080/#/c/19375/9//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19375/9//COMMIT_MSG@15
PS9, Line 15: update_stats_print_prompt_log_interval_s
nit: since 'prompt' doesn't seem to be very relevant to what the flag is doing, maybe rename it into --update_stats_log_throttling_interval_sec ?


http://gerrit.cloudera.org:8080/#/c/19375/9/src/kudu/tablet/tablet_mm_ops.cc
File src/kudu/tablet/tablet_mm_ops.cc:

http://gerrit.cloudera.org:8080/#/c/19375/9/src/kudu/tablet/tablet_mm_ops.cc@92
PS9, Line 92: update_stats_print_prompt_log_interval_s
Whoops, it seems I forgot to point to the fact that 'prompt' in the name of this flag didn't look relevant.

Could you rename this into something like 

  update_stats_log_throttling_interval_sec

?



-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 9
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Fri, 30 Dec 2022 18:39:55 +0000
Gerrit-HasComments: Yes

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19375

to look at the new patch set (#10).

Change subject: [log] Reduce prompt log printing frequency
......................................................................

[log] Reduce prompt log printing frequency

I notice the UpdateStats() function prints too frequently
for the soft-deleted tables, or the tables that compaction
disabled manually. If we can reduce the frequency of these
duplicate logs, it will help us find useful information in
the log more quickly.

So I added a new flag '--update_stats_log_throttling_interval_sec'
to control the printing frequency in UpdateStats() function.

Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
---
M src/kudu/tablet/tablet_mm_ops.cc
M src/kudu/tablet/tablet_replica_mm_ops.cc
2 files changed, 15 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/19375/10
-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 10
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19375 )

Change subject: [log] Reduce prompt log printing frequency
......................................................................


Patch Set 11: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 11
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Tue, 03 Jan 2023 19:21:31 +0000
Gerrit-HasComments: No

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19375 )

Change subject: [log] Reduce prompt log printing frequency
......................................................................


Patch Set 10:

(2 comments)

Thanks for your reviews. I have changed the flag according to your suggestion.

http://gerrit.cloudera.org:8080/#/c/19375/9//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19375/9//COMMIT_MSG@15
PS9, Line 15: update_stats_log_throttling_interval_sec
> nit: since 'prompt' doesn't seem to be very relevant to what the flag is do
Done


http://gerrit.cloudera.org:8080/#/c/19375/9/src/kudu/tablet/tablet_mm_ops.cc
File src/kudu/tablet/tablet_mm_ops.cc:

http://gerrit.cloudera.org:8080/#/c/19375/9/src/kudu/tablet/tablet_mm_ops.cc@92
PS9, Line 92: update_stats_log_throttling_interval_sec
> Whoops, it seems I forgot to point to the fact that 'prompt' in the name of
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 10
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Tue, 03 Jan 2023 01:55:03 +0000
Gerrit-HasComments: Yes

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19375

to look at the new patch set (#9).

Change subject: [log] Reduce prompt log printing frequency
......................................................................

[log] Reduce prompt log printing frequency

I notice the UpdateStats() function prints too frequently
for the soft-deleted tables, or the tables that compaction
disabled manually. If we can reduce the frequency of these
duplicate logs, it will help us find useful information in
the log more quickly.

So I added a new flag '--update_stats_print_prompt_log_interval_s'
to control the printing frequency in UpdateStats() function.

Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
---
M src/kudu/tablet/tablet_mm_ops.cc
M src/kudu/tablet/tablet_replica_mm_ops.cc
2 files changed, 15 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/19375/9
-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 9
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19375 )

Change subject: [log] Reduce prompt log printing frequency
......................................................................


Patch Set 6:

(5 comments)

Thanks for your reviews.

http://gerrit.cloudera.org:8080/#/c/19375/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19375/5//COMMIT_MSG@9
PS5, Line 9: UpdateStats() function print too frequently
> But that's only in case of disabling particular type of compaction, isn't i
Yes, you're right and I will add this supplement.


http://gerrit.cloudera.org:8080/#/c/19375/5//COMMIT_MSG@10
PS5, Line 10: soft-delete
> What is 'trash table'?
Sorry, I meant the soft-deleted table.


http://gerrit.cloudera.org:8080/#/c/19375/5/src/kudu/tablet/tablet_mm_ops.cc
File src/kudu/tablet/tablet_mm_ops.cc:

http://gerrit.cloudera.org:8080/#/c/19375/5/src/kudu/tablet/tablet_mm_ops.cc@92
PS5, Line 92: 600
> Maybe, make it something to be round in the number of minutes?  If you don'
Done


http://gerrit.cloudera.org:8080/#/c/19375/5/src/kudu/tablet/tablet_mm_ops.cc@94
PS5, Line 94: TAG_FLAG(update_stats_print_prompt_log_interval_s, runtime);
> I guess it make makes sense adding the 'experimental' tag as well.
Done


http://gerrit.cloudera.org:8080/#/c/19375/5/src/kudu/tablet/tablet_mm_ops.cc@380
PS5, Line 380: f (PREDICT_FALSE(!FLAGS_enable_u
> Don't you want to update this to be configurable as well?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 6
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Tue, 20 Dec 2022 02:01:38 +0000
Gerrit-HasComments: Yes

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19375

to look at the new patch set (#6).

Change subject: [log] Reduce prompt log printing frequency
......................................................................

[log] Reduce prompt log printing frequency

I notice the UpdateStats() function print too frequently
for the soft-deleted table when the compaction is disable.
If we can reduce the frequency of these duplicate logs,
it will help us solve the problem better.

So I added a new flag '--update_stats_print_prompt_log_interval_s'
to control the printing frequency in UpdateStats() function.

Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
---
M src/kudu/tablet/tablet_mm_ops.cc
1 file changed, 9 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/19375/6
-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 6
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19375 )

Change subject: [log] Reduce prompt log printing frequency
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19375/7//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19375/7//COMMIT_MSG@14
PS7, Line 14: update_stats_print_prompt_log_interval_s
> There are some more cases in src/kudu/tablet/tablet_replica_mm_ops.cc we ha
Done


http://gerrit.cloudera.org:8080/#/c/19375/5/src/kudu/tablet/tablet_mm_ops.cc
File src/kudu/tablet/tablet_mm_ops.cc:

http://gerrit.cloudera.org:8080/#/c/19375/5/src/kudu/tablet/tablet_mm_ops.cc@92
PS5, Line 92: 600
> I meant exactly what's been done: round the default value of the flag to mi
Thank you for your reply.



-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 8
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Tue, 20 Dec 2022 06:20:14 +0000
Gerrit-HasComments: Yes

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19375 )

Change subject: [log] Reduce prompt log printing frequency
......................................................................


Patch Set 11:

> (2 comments)
 > 
 > Thanks for your reviews. I have changed the flag according to your
 > suggestion.

Thanks a lot!


-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 11
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Tue, 03 Jan 2023 19:21:27 +0000
Gerrit-HasComments: No

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19375 )

Change subject: [log] Reduce prompt log printing frequency
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19375/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19375/1//COMMIT_MSG@9
PS1, Line 9: too frequently
           : for the trash table
> Do you mean that I continue to use the function, just adjust the time frequ
If there are too many trashed tablets, KLOG_EVERY_N will print more frequently than KLOG_EVERY_N_SEC. How about set the interval seconds as a flag so that you can adjust it to a large value if you don't want see it too frequently?



-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Mon, 19 Dec 2022 07:18:37 +0000
Gerrit-HasComments: Yes

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19375

to look at the new patch set (#2).

Change subject: [log] Reduce prompt log printing frequency
......................................................................

[log] Reduce prompt log printing frequency

I notice the UpdateStats() function print too frequently
for the trash table. If we can reduce the frequency of
these duplicate logs, it will help us solve the problem
better.
So I added a new flag '--update_stats_print_prompt_log_interval_s'
to control the printing frequency in UpdateStats() function.

Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
---
M src/kudu/tablet/tablet_mm_ops.cc
1 file changed, 7 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/19375/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19375

to look at the new patch set (#8).

Change subject: [log] Reduce prompt log printing frequency
......................................................................

[log] Reduce prompt log printing frequency

I notice the UpdateStats() function print too frequently
for the soft-deleted table when the compaction is disable.
If we can reduce the frequency of these duplicate logs,
it will help us solve the problem better.

So I added a new flag '--update_stats_print_prompt_log_interval_s'
to control the printing frequency in UpdateStats() function.

Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
---
M src/kudu/tablet/tablet_mm_ops.cc
M src/kudu/tablet/tablet_replica_mm_ops.cc
2 files changed, 14 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/19375/8
-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 8
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19375 )

Change subject: [log] Reduce prompt log printing frequency
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19375/5/src/kudu/tablet/tablet_mm_ops.cc
File src/kudu/tablet/tablet_mm_ops.cc:

http://gerrit.cloudera.org:8080/#/c/19375/5/src/kudu/tablet/tablet_mm_ops.cc@94
PS5, Line 94: TAG_FLAG(update_stats_print_prompt_log_interval_s, runtime);
I guess it make makes sense adding the 'experimental' tag as well.



-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 5
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Mon, 19 Dec 2022 18:15:22 +0000
Gerrit-HasComments: Yes

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19375 )

Change subject: [log] Reduce prompt log printing frequency
......................................................................


Patch Set 9: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 9
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 29 Dec 2022 16:30:42 +0000
Gerrit-HasComments: No

[kudu-CR] [log] Reduce prompt log printing frequency

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19375 )

Change subject: [log] Reduce prompt log printing frequency
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19375/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19375/1//COMMIT_MSG@9
PS1, Line 9: too frequently
           : for the trash table
I'd think that printing every 5 minutes might be more rarely than printing one out of twenty times if CompactRowSetsOp::UpdateStats() might be called as often as once in 250ms?



-- 
To view, visit http://gerrit.cloudera.org:8080/19375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03
Gerrit-Change-Number: 19375
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 19 Dec 2022 05:51:52 +0000
Gerrit-HasComments: Yes