You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2013/09/04 22:08:51 UTC

[jira] [Updated] (HBASE-9411) Increment / decrement of rpcCount in RpcServer#Connection is not protected by synchronization

     [ https://issues.apache.org/jira/browse/HBASE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HBASE-9411:
--------------------------

    Attachment: 9411-v1.txt
    
> Increment / decrement of rpcCount in RpcServer#Connection is not protected by synchronization
> ---------------------------------------------------------------------------------------------
>
>                 Key: HBASE-9411
>                 URL: https://issues.apache.org/jira/browse/HBASE-9411
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: 9411-v1.txt
>
>
> Here is related code:
> {code}
>     /* Decrement the outstanding RPC count */
>     protected void decRpcCount() {
>       rpcCount--;
>     }
>     /* Increment the outstanding RPC count */
>     protected void incRpcCount() {
>       rpcCount++;
>     }
> {code}
> Even though rpcCount is volatile, in non atomic operations (increment / decrement) different threads may get unexpected result.
> See http://stackoverflow.com/questions/7805192/is-a-volatile-int-in-java-thread-safe

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira