You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by John Roesler <jo...@confluent.io> on 2019/03/27 19:55:05 UTC
[VOTE] KIP-422: Use the default value of max.poll.interval in Streams
Hi all,
Since the KIP is so small, I'm going to optimistically start the vote for
KIP-422 to remove our "max int" default max.poll.interval.ms in Streams and
fall back to the Consumer default of five minutes.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-442%3A+Return+to+default+max+poll+interval+in+Streams
Permalink: https://cwiki.apache.org/confluence/x/1COGBg
See also: https://issues.apache.org/jira/browse/KAFKA-6399
Please let me know if you have any objections and wish to return to the
discussion phase!
Thanks,
-John
Re: [VOTE] KIP-422: Use the default value of max.poll.interval in Streams
Posted by John Roesler <jo...@confluent.io>.
You're absolutely right. I realized that at some point after the initial
message and just tried to play it cool.
Sorry about that.
-John
On Mon, Apr 15, 2019 at 11:59 AM Jun Rao <ju...@confluent.io> wrote:
> The voting thread seems to be referring to the wrong KIP number. It should
> be KIP-442 instead of KIP-422.
>
> Thanks,
>
> Jun
>
> On Wed, Apr 3, 2019 at 7:03 PM John Roesler <jo...@confluent.io> wrote:
>
> > Thanks all. The KIP-442 vote has passed with 3 binding votes (Guozhang,
> > Bill, and Damian) and one non-binding vote (me) in favor and none
> against.
> >
> > I'll update the KIP page.
> >
> > -John
> >
> > On Fri, Mar 29, 2019 at 10:29 AM Damian Guy <da...@gmail.com>
> wrote:
> >
> > > +1
> > >
> > > On Wed, 27 Mar 2019 at 21:38, John Roesler <jo...@confluent.io> wrote:
> > >
> > > > Ah, good point, Guozhang. I'll remove that mention from the KIP.
> > > >
> > > > On Wed, Mar 27, 2019 at 3:30 PM Bill Bejeck <bb...@gmail.com>
> wrote:
> > > >
> > > > > +1 for me,
> > > > >
> > > > > Thanks,
> > > > > Bill
> > > > >
> > > > > On Wed, Mar 27, 2019 at 4:13 PM Guozhang Wang <wa...@gmail.com>
> > > > wrote:
> > > > >
> > > > > > +1 from me.
> > > > > >
> > > > > > Though note that we cannot make such changes in older versions
> > since
> > > > even
> > > > > > if we release new versions out of those branches they are
> > considered
> > > > > > bug-fix only and hence should not have any interface impacting
> > > changes.
> > > > > >
> > > > > >
> > > > > > Guozhang
> > > > > >
> > > > > > On Wed, Mar 27, 2019 at 12:55 PM John Roesler <john@confluent.io
> >
> > > > wrote:
> > > > > >
> > > > > > > Hi all,
> > > > > > >
> > > > > > > Since the KIP is so small, I'm going to optimistically start
> the
> > > vote
> > > > > for
> > > > > > > KIP-422 to remove our "max int" default max.poll.interval.ms
> in
> > > > > Streams
> > > > > > > and
> > > > > > > fall back to the Consumer default of five minutes.
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-442%3A+Return+to+default+max+poll+interval+in+Streams
> > > > > > >
> > > > > > > Permalink: https://cwiki.apache.org/confluence/x/1COGBg
> > > > > > >
> > > > > > > See also: https://issues.apache.org/jira/browse/KAFKA-6399
> > > > > > >
> > > > > > > Please let me know if you have any objections and wish to
> return
> > to
> > > > the
> > > > > > > discussion phase!
> > > > > > >
> > > > > > > Thanks,
> > > > > > > -John
> > > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > -- Guozhang
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] KIP-422: Use the default value of max.poll.interval in Streams
Posted by Jun Rao <ju...@confluent.io>.
The voting thread seems to be referring to the wrong KIP number. It should
be KIP-442 instead of KIP-422.
Thanks,
Jun
On Wed, Apr 3, 2019 at 7:03 PM John Roesler <jo...@confluent.io> wrote:
> Thanks all. The KIP-442 vote has passed with 3 binding votes (Guozhang,
> Bill, and Damian) and one non-binding vote (me) in favor and none against.
>
> I'll update the KIP page.
>
> -John
>
> On Fri, Mar 29, 2019 at 10:29 AM Damian Guy <da...@gmail.com> wrote:
>
> > +1
> >
> > On Wed, 27 Mar 2019 at 21:38, John Roesler <jo...@confluent.io> wrote:
> >
> > > Ah, good point, Guozhang. I'll remove that mention from the KIP.
> > >
> > > On Wed, Mar 27, 2019 at 3:30 PM Bill Bejeck <bb...@gmail.com> wrote:
> > >
> > > > +1 for me,
> > > >
> > > > Thanks,
> > > > Bill
> > > >
> > > > On Wed, Mar 27, 2019 at 4:13 PM Guozhang Wang <wa...@gmail.com>
> > > wrote:
> > > >
> > > > > +1 from me.
> > > > >
> > > > > Though note that we cannot make such changes in older versions
> since
> > > even
> > > > > if we release new versions out of those branches they are
> considered
> > > > > bug-fix only and hence should not have any interface impacting
> > changes.
> > > > >
> > > > >
> > > > > Guozhang
> > > > >
> > > > > On Wed, Mar 27, 2019 at 12:55 PM John Roesler <jo...@confluent.io>
> > > wrote:
> > > > >
> > > > > > Hi all,
> > > > > >
> > > > > > Since the KIP is so small, I'm going to optimistically start the
> > vote
> > > > for
> > > > > > KIP-422 to remove our "max int" default max.poll.interval.ms in
> > > > Streams
> > > > > > and
> > > > > > fall back to the Consumer default of five minutes.
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-442%3A+Return+to+default+max+poll+interval+in+Streams
> > > > > >
> > > > > > Permalink: https://cwiki.apache.org/confluence/x/1COGBg
> > > > > >
> > > > > > See also: https://issues.apache.org/jira/browse/KAFKA-6399
> > > > > >
> > > > > > Please let me know if you have any objections and wish to return
> to
> > > the
> > > > > > discussion phase!
> > > > > >
> > > > > > Thanks,
> > > > > > -John
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > -- Guozhang
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] KIP-422: Use the default value of max.poll.interval in Streams
Posted by John Roesler <jo...@confluent.io>.
Thanks all. The KIP-442 vote has passed with 3 binding votes (Guozhang,
Bill, and Damian) and one non-binding vote (me) in favor and none against.
I'll update the KIP page.
-John
On Fri, Mar 29, 2019 at 10:29 AM Damian Guy <da...@gmail.com> wrote:
> +1
>
> On Wed, 27 Mar 2019 at 21:38, John Roesler <jo...@confluent.io> wrote:
>
> > Ah, good point, Guozhang. I'll remove that mention from the KIP.
> >
> > On Wed, Mar 27, 2019 at 3:30 PM Bill Bejeck <bb...@gmail.com> wrote:
> >
> > > +1 for me,
> > >
> > > Thanks,
> > > Bill
> > >
> > > On Wed, Mar 27, 2019 at 4:13 PM Guozhang Wang <wa...@gmail.com>
> > wrote:
> > >
> > > > +1 from me.
> > > >
> > > > Though note that we cannot make such changes in older versions since
> > even
> > > > if we release new versions out of those branches they are considered
> > > > bug-fix only and hence should not have any interface impacting
> changes.
> > > >
> > > >
> > > > Guozhang
> > > >
> > > > On Wed, Mar 27, 2019 at 12:55 PM John Roesler <jo...@confluent.io>
> > wrote:
> > > >
> > > > > Hi all,
> > > > >
> > > > > Since the KIP is so small, I'm going to optimistically start the
> vote
> > > for
> > > > > KIP-422 to remove our "max int" default max.poll.interval.ms in
> > > Streams
> > > > > and
> > > > > fall back to the Consumer default of five minutes.
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-442%3A+Return+to+default+max+poll+interval+in+Streams
> > > > >
> > > > > Permalink: https://cwiki.apache.org/confluence/x/1COGBg
> > > > >
> > > > > See also: https://issues.apache.org/jira/browse/KAFKA-6399
> > > > >
> > > > > Please let me know if you have any objections and wish to return to
> > the
> > > > > discussion phase!
> > > > >
> > > > > Thanks,
> > > > > -John
> > > > >
> > > >
> > > >
> > > > --
> > > > -- Guozhang
> > > >
> > >
> >
>
Re: [VOTE] KIP-422: Use the default value of max.poll.interval in Streams
Posted by Damian Guy <da...@gmail.com>.
+1
On Wed, 27 Mar 2019 at 21:38, John Roesler <jo...@confluent.io> wrote:
> Ah, good point, Guozhang. I'll remove that mention from the KIP.
>
> On Wed, Mar 27, 2019 at 3:30 PM Bill Bejeck <bb...@gmail.com> wrote:
>
> > +1 for me,
> >
> > Thanks,
> > Bill
> >
> > On Wed, Mar 27, 2019 at 4:13 PM Guozhang Wang <wa...@gmail.com>
> wrote:
> >
> > > +1 from me.
> > >
> > > Though note that we cannot make such changes in older versions since
> even
> > > if we release new versions out of those branches they are considered
> > > bug-fix only and hence should not have any interface impacting changes.
> > >
> > >
> > > Guozhang
> > >
> > > On Wed, Mar 27, 2019 at 12:55 PM John Roesler <jo...@confluent.io>
> wrote:
> > >
> > > > Hi all,
> > > >
> > > > Since the KIP is so small, I'm going to optimistically start the vote
> > for
> > > > KIP-422 to remove our "max int" default max.poll.interval.ms in
> > Streams
> > > > and
> > > > fall back to the Consumer default of five minutes.
> > > >
> > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-442%3A+Return+to+default+max+poll+interval+in+Streams
> > > >
> > > > Permalink: https://cwiki.apache.org/confluence/x/1COGBg
> > > >
> > > > See also: https://issues.apache.org/jira/browse/KAFKA-6399
> > > >
> > > > Please let me know if you have any objections and wish to return to
> the
> > > > discussion phase!
> > > >
> > > > Thanks,
> > > > -John
> > > >
> > >
> > >
> > > --
> > > -- Guozhang
> > >
> >
>
Re: [VOTE] KIP-422: Use the default value of max.poll.interval in Streams
Posted by John Roesler <jo...@confluent.io>.
Ah, good point, Guozhang. I'll remove that mention from the KIP.
On Wed, Mar 27, 2019 at 3:30 PM Bill Bejeck <bb...@gmail.com> wrote:
> +1 for me,
>
> Thanks,
> Bill
>
> On Wed, Mar 27, 2019 at 4:13 PM Guozhang Wang <wa...@gmail.com> wrote:
>
> > +1 from me.
> >
> > Though note that we cannot make such changes in older versions since even
> > if we release new versions out of those branches they are considered
> > bug-fix only and hence should not have any interface impacting changes.
> >
> >
> > Guozhang
> >
> > On Wed, Mar 27, 2019 at 12:55 PM John Roesler <jo...@confluent.io> wrote:
> >
> > > Hi all,
> > >
> > > Since the KIP is so small, I'm going to optimistically start the vote
> for
> > > KIP-422 to remove our "max int" default max.poll.interval.ms in
> Streams
> > > and
> > > fall back to the Consumer default of five minutes.
> > >
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-442%3A+Return+to+default+max+poll+interval+in+Streams
> > >
> > > Permalink: https://cwiki.apache.org/confluence/x/1COGBg
> > >
> > > See also: https://issues.apache.org/jira/browse/KAFKA-6399
> > >
> > > Please let me know if you have any objections and wish to return to the
> > > discussion phase!
> > >
> > > Thanks,
> > > -John
> > >
> >
> >
> > --
> > -- Guozhang
> >
>
Re: [VOTE] KIP-422: Use the default value of max.poll.interval in Streams
Posted by Bill Bejeck <bb...@gmail.com>.
+1 for me,
Thanks,
Bill
On Wed, Mar 27, 2019 at 4:13 PM Guozhang Wang <wa...@gmail.com> wrote:
> +1 from me.
>
> Though note that we cannot make such changes in older versions since even
> if we release new versions out of those branches they are considered
> bug-fix only and hence should not have any interface impacting changes.
>
>
> Guozhang
>
> On Wed, Mar 27, 2019 at 12:55 PM John Roesler <jo...@confluent.io> wrote:
>
> > Hi all,
> >
> > Since the KIP is so small, I'm going to optimistically start the vote for
> > KIP-422 to remove our "max int" default max.poll.interval.ms in Streams
> > and
> > fall back to the Consumer default of five minutes.
> >
> >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-442%3A+Return+to+default+max+poll+interval+in+Streams
> >
> > Permalink: https://cwiki.apache.org/confluence/x/1COGBg
> >
> > See also: https://issues.apache.org/jira/browse/KAFKA-6399
> >
> > Please let me know if you have any objections and wish to return to the
> > discussion phase!
> >
> > Thanks,
> > -John
> >
>
>
> --
> -- Guozhang
>
Re: [VOTE] KIP-422: Use the default value of max.poll.interval in Streams
Posted by Guozhang Wang <wa...@gmail.com>.
+1 from me.
Though note that we cannot make such changes in older versions since even
if we release new versions out of those branches they are considered
bug-fix only and hence should not have any interface impacting changes.
Guozhang
On Wed, Mar 27, 2019 at 12:55 PM John Roesler <jo...@confluent.io> wrote:
> Hi all,
>
> Since the KIP is so small, I'm going to optimistically start the vote for
> KIP-422 to remove our "max int" default max.poll.interval.ms in Streams
> and
> fall back to the Consumer default of five minutes.
>
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-442%3A+Return+to+default+max+poll+interval+in+Streams
>
> Permalink: https://cwiki.apache.org/confluence/x/1COGBg
>
> See also: https://issues.apache.org/jira/browse/KAFKA-6399
>
> Please let me know if you have any objections and wish to return to the
> discussion phase!
>
> Thanks,
> -John
>
--
-- Guozhang