[jira] [Commented] (SAMZA-550) Remove dead code in SerializerConfig

["Benjamin Fradet (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355745#comment-14355745 ] 

Benjamin Fradet commented on SAMZA-550:
---------------------------------------

It is used in [KafkaSerdeConfig|https://github.com/apache/samza/blob/master/samza-kafka/src/main/scala/org/apache/samza/config/KafkaSerdeConfig.scala#L24], do you mean to move it there?
Or to simply have:
{code}
val subconf = config.subset(SERIALIZER_PREFIX format "", true)
{code}

> Remove dead code in SerializerConfig
> ------------------------------------
>
>                 Key: SAMZA-550
>                 URL: https://issues.apache.org/jira/browse/SAMZA-550
>             Project: Samza
>          Issue Type: Bug
>          Components: container
>    Affects Versions: 0.8.1
>            Reporter: Yan Fang
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 0.10.0
>
>
> In [SerializerConfig|https://github.com/apache/samza/blob/master/samza-core/src/main/scala/org/apache/samza/config/SerializerConfig.scala], "SERIALIZER_PREFIX" is not used. Remove it or use it to replace "serializers.registry." in 
> {code}
> val subConf = config.subset("serializers.registry.", true)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)