You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/05/11 02:31:19 UTC
[GitHub] [zeppelin] zjffdu opened a new pull request #4113: [ZEPPELIN-5343] Zeppelin Interface becomes unresponsive
zjffdu opened a new pull request #4113:
URL: https://github.com/apache/zeppelin/pull/4113
### What is this PR for?
This is experimental PR for fixing the zeppelin unresponsive issue. Regarding the jstack, it seems blocked in `NotebookSocket#send` method, this PR change it from sync call to async call.
### What type of PR is it?
[Bug Fix ]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-5343
### How should this be tested?
* CI
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4113: [ZEPPELIN-5343] Zeppelin Interface becomes unresponsive
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4113:
URL: https://github.com/apache/zeppelin/pull/4113#issuecomment-839471034
@cuspymd I am not sure whether this is the right fix, as I mentioned in the PR, it is an experimental PR. As it is hard to reproduce this issue, it is not easy to verify the fix. Do you have any idea on what might be the root cause ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] cuspymd commented on pull request #4113: [ZEPPELIN-5343] Zeppelin Interface becomes unresponsive
Posted by GitBox <gi...@apache.org>.
cuspymd commented on pull request #4113:
URL: https://github.com/apache/zeppelin/pull/4113#issuecomment-839468105
Are you sure this change fix a client hang? Blocking of `send` might be the result of a client hang not the cause of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4113: [ZEPPELIN-5343] Zeppelin Interface becomes unresponsive
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4113:
URL: https://github.com/apache/zeppelin/pull/4113#issuecomment-850299078
Does it make a difference in your environment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] cuspymd commented on pull request #4113: [ZEPPELIN-5343] Zeppelin Interface becomes unresponsive
Posted by GitBox <gi...@apache.org>.
cuspymd commented on pull request #4113:
URL: https://github.com/apache/zeppelin/pull/4113#issuecomment-839839289
> @cuspymd I am not sure whether this is the right fix, as I mentioned in the PR, it is an experimental PR. As it is hard to reproduce this issue, it is not easy to verify the fix. Do you have any idea on what might be the root cause ?
Sorry, I haven't seen this issue yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] chillinger commented on pull request #4113: [ZEPPELIN-5343] Zeppelin Interface becomes unresponsive
Posted by GitBox <gi...@apache.org>.
chillinger commented on pull request #4113:
URL: https://github.com/apache/zeppelin/pull/4113#issuecomment-860400795
@zjffdu I can verify that the proposed Fix completely eliminated the deadlocks of zeppelin experienced before.
We built a patched version of Zeppelin 0.9 with the change in this MR and deployed in on all stages of our environment, 100+ Users on PROD. With vanilla 0.9 we had about one restart per day. Since the deployment of the patched version not a single restart.
+1 for merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4113: [ZEPPELIN-5343] Zeppelin Interface becomes unresponsive
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4113:
URL: https://github.com/apache/zeppelin/pull/4113#issuecomment-849327181
Will merge if no more comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4113: [ZEPPELIN-5343] Zeppelin Interface becomes unresponsive
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4113:
URL: https://github.com/apache/zeppelin/pull/4113#issuecomment-861123437
Thanks @chillinger for the verification, will merge it soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4113: [ZEPPELIN-5343] Zeppelin Interface becomes unresponsive
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4113:
URL: https://github.com/apache/zeppelin/pull/4113#issuecomment-851397091
Thank @chillinger for the help. Regarding `synchronized`, it is done in https://issues.apache.org/jira/browse/ZEPPELIN-1480.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] chillinger commented on pull request #4113: [ZEPPELIN-5343] Zeppelin Interface becomes unresponsive
Posted by GitBox <gi...@apache.org>.
chillinger commented on pull request #4113:
URL: https://github.com/apache/zeppelin/pull/4113#issuecomment-851379000
@zjffdu based on your MR we built the zeppelin-server jar for our environment and will test it - I will share the results as soon as we have solid feedback.
One question to the org.apache.zeppelin.socket.NotebookSocket.send() method: we could not find any reason for the "synchronized" marking of the method - is there a reason for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org