[GitHub] [druid] LakshSingla commented on a diff in pull request #12862: Adding withName implementation to AggregatorFactory

[GitBox <gi...@apache.org>]

LakshSingla commented on code in PR #12862:
URL: https://github.com/apache/druid/pull/12862#discussion_r938398663


##########
processing/src/main/java/org/apache/druid/query/aggregation/AggregatorFactory.java:
##########
@@ -347,6 +350,21 @@ public AggregatorFactory optimizeForSegment(PerSegmentQueryOptimizationContext o
     return this;
   }
 
+  /**
+   * Used in cases where we want to change the output name of the aggregator to something else. For eg: if we have
+   * a query "select a , sum(b) as total group by table" the aggregator returned from the native group by query is "a0" set in

Review Comment:
   I think this query is slightly misformed here. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org