You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/06/08 11:35:25 UTC
[GitHub] [phoenix-connectors] richardantal opened a new pull request #54: PHOENIX-6490 Fix shaded phoenix hive connector jar name and reduce th…
richardantal opened a new pull request #54:
URL: https://github.com/apache/phoenix-connectors/pull/54
…e size
Change-Id: I59fc910134f9a6401036bdcf8345f79d5b68d9ec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] stoty commented on a change in pull request #54: PHOENIX-6490 Fix shaded phoenix hive connector jar name and reduce th…
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #54:
URL: https://github.com/apache/phoenix-connectors/pull/54#discussion_r647548201
##########
File path: phoenix-hive-base/phoenix4-hive-shaded/pom.xml
##########
@@ -48,6 +48,62 @@
<artifactId>phoenix-hbase-compat-${hbase.compat.version}</artifactId>
<scope>runtime</scope>
</dependency>
+ <!-- maven-shade-plugin doesn't ingerit dependency settings, we must duplocate them to avoid
Review comment:
please fix the typos before commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] richardantal merged pull request #54: PHOENIX-6490 Fix shaded phoenix hive connector jar name and reduce th…
Posted by GitBox <gi...@apache.org>.
richardantal merged pull request #54:
URL: https://github.com/apache/phoenix-connectors/pull/54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] stoty commented on pull request #54: PHOENIX-6490 Fix shaded phoenix hive connector jar name and reduce th…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #54:
URL: https://github.com/apache/phoenix-connectors/pull/54#issuecomment-856918468
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 6m 52s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 11m 21s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 17m 54s | root in master failed. |
| -1 :x: | compile | 0m 30s | phoenix-hive-base in master failed. |
| -1 :x: | compile | 0m 10s | phoenix4-hive-shaded in master failed. |
| -1 :x: | javadoc | 0m 11s | phoenix-hive-base in master failed. |
| -1 :x: | javadoc | 0m 9s | phoenix4-connectors-assembly in master failed. |
| -1 :x: | javadoc | 0m 7s | phoenix4-hive-shaded in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 16m 9s | root in the patch failed. |
| -1 :x: | compile | 0m 30s | phoenix-hive-base in the patch failed. |
| -1 :x: | compile | 0m 9s | phoenix4-hive-shaded in the patch failed. |
| -1 :x: | javac | 0m 30s | phoenix-hive-base in the patch failed. |
| -1 :x: | javac | 0m 9s | phoenix4-hive-shaded in the patch failed. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 5s | The patch has no ill-formed XML file. |
| -1 :x: | javadoc | 0m 11s | phoenix-hive-base in the patch failed. |
| -1 :x: | javadoc | 0m 8s | phoenix4-connectors-assembly in the patch failed. |
| -1 :x: | javadoc | 0m 9s | phoenix4-hive-shaded in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 10m 54s | phoenix-hive-base in the patch failed. |
| +1 :green_heart: | unit | 3m 3s | phoenix5-hive-shaded in the patch passed. |
| -1 :x: | unit | 0m 8s | phoenix4-connectors-assembly in the patch failed. |
| -1 :x: | unit | 0m 10s | phoenix4-hive-shaded in the patch failed. |
| -1 :x: | asflicense | 0m 28s | The patch generated 1 ASF License warnings. |
| | | 72m 11s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-54/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/54 |
| Optional Tests | dupname asflicense xml javac javadoc unit compile |
| uname | Linux f8632884e00c 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / eaf5adf |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-54/2/artifact/yetus-general-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-54/2/artifact/yetus-general-check/output/branch-compile-phoenix-hive-base.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-54/2/artifact/yetus-general-check/output/branch-compile-phoenix-hive-base_phoenix4-hive-shaded.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-54/2/artifact/yetus-general-check/output/branch-javadoc-phoenix-hive-base.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-54/2/artifact/yetus-general-check/output/branch-javadoc-phoenix4-connectors-assembly.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-54/2/artifact/yetus-general-check/output/branch-javadoc-phoenix-hive-base_phoenix4-hive-shaded.txt |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-54/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-54/2/artifact/yetus-general-check/output/patch-compile-phoenix-hive-base.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-54/2/artifact/yetus-general-check/output/patch-compile-phoenix-hive-base_phoenix4-hive-shaded.txt |
| javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-54/2/artifact/yetus-general-check/output/patch-compile-phoenix-hive-base.txt |
| javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-54/2/artifact/yetus-general-check/output/patch-compile-phoenix-hive-base_phoenix4-hive-shaded.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-54/2/artifact/yetus-general-check/output/patch-javadoc-phoenix-hive-base.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-54/2/artifact/yetus-general-check/output/patch-javadoc-phoenix4-connectors-assembly.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-54/2/artifact/yetus-general-check/output/patch-javadoc-phoenix-hive-base_phoenix4-hive-shaded.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-54/2/artifact/yetus-general-check/output/patch-unit-phoenix-hive-base.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-54/2/artifact/yetus-general-check/output/patch-unit-phoenix4-connectors-assembly.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-54/2/artifact/yetus-general-check/output/patch-unit-phoenix-hive-base_phoenix4-hive-shaded.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-54/2/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-54/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 1585 (vs. ulimit of 30000) |
| modules | C: phoenix-hive-base phoenix-hive-base/phoenix5-hive-shaded phoenix4-connectors-assembly phoenix-hive-base/phoenix4-hive-shaded U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-54/2/console |
| versions | git=2.7.4 maven=3.3.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org