You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/17 16:33:43 UTC
[GitHub] [arrow] nevi-me commented on a change in pull request #7767: ARROW-9453: [Rust] Wasm32 compilation support
nevi-me commented on a change in pull request #7767:
URL: https://github.com/apache/arrow/pull/7767#discussion_r506960006
##########
File path: rust/arrow/src/util/bit_util.rs
##########
@@ -366,13 +371,13 @@ mod tests {
assert_eq!(ceil(8, 8), 1);
assert_eq!(ceil(9, 8), 2);
assert_eq!(ceil(9, 9), 1);
- assert_eq!(ceil(10000000000, 10), 1000000000);
- assert_eq!(ceil(10, 10000000000), 1);
- assert_eq!(ceil(10000000000, 1000000000), 10);
+ assert_eq!(ceil(10000000, 10), 1000000);
Review comment:
The numbers are 64-bit, which won't be supported in wasm32
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org