You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ws.apache.org by ve...@apache.org on 2013/01/26 12:06:21 UTC

svn commit: r1438877 - in /webservices/axiom/trunk/modules: axiom-api/src/test/resources/soap/soap11/ axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/ axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap11/ axiom-dom/src/test/java/org/apa...

Author: veithen
Date: Sat Jan 26 11:06:20 2013
New Revision: 1438877

URL: http://svn.apache.org/viewvc?rev=1438877&view=rev
Log:
Correctly serialize SOAPFaults that contain comments in their child elements.

Added:
    webservices/axiom/trunk/modules/axiom-api/src/test/resources/soap/soap11/faultelements-with-comment.xml
      - copied, changed from r1438189, webservices/axiom/trunk/modules/axiom-api/src/test/resources/soap/soap11/faultstring-with-comment.xml
Removed:
    webservices/axiom/trunk/modules/axiom-api/src/test/resources/soap/soap11/faultstring-with-comment.xml
Modified:
    webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/SOAPFaultNodeImpl.java
    webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/SOAPFaultRoleImpl.java
    webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap11/SOAP11FaultCodeImpl.java
    webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap11/SOAP11FaultReasonImpl.java
    webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap11/SOAP11FaultRoleImpl.java
    webservices/axiom/trunk/modules/axiom-dom/src/test/java/org/apache/axiom/soap/impl/dom/SOAPImplementationTest.java
    webservices/axiom/trunk/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap11/SOAP11FaultCodeImpl.java
    webservices/axiom/trunk/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap11/SOAP11FaultReasonImpl.java
    webservices/axiom/trunk/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap11/SOAP11FaultRoleImpl.java
    webservices/axiom/trunk/modules/axiom-impl/src/test/java/org/apache/axiom/soap/impl/llom/SOAPImplementationTest.java
    webservices/axiom/trunk/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/SOAPTestSuiteBuilder.java

Copied: webservices/axiom/trunk/modules/axiom-api/src/test/resources/soap/soap11/faultelements-with-comment.xml (from r1438189, webservices/axiom/trunk/modules/axiom-api/src/test/resources/soap/soap11/faultstring-with-comment.xml)
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/modules/axiom-api/src/test/resources/soap/soap11/faultelements-with-comment.xml?p2=webservices/axiom/trunk/modules/axiom-api/src/test/resources/soap/soap11/faultelements-with-comment.xml&p1=webservices/axiom/trunk/modules/axiom-api/src/test/resources/soap/soap11/faultstring-with-comment.xml&r1=1438189&r2=1438877&rev=1438877&view=diff
==============================================================================
--- webservices/axiom/trunk/modules/axiom-api/src/test/resources/soap/soap11/faultstring-with-comment.xml (original)
+++ webservices/axiom/trunk/modules/axiom-api/src/test/resources/soap/soap11/faultelements-with-comment.xml Sat Jan 26 11:06:20 2013
@@ -1,8 +1,9 @@
 <SOAP-ENV:Envelope xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/">
    <SOAP-ENV:Body>
        <SOAP-ENV:Fault>
-           <faultcode>SOAP-ENV:MustUnderstand</faultcode>
+           <faultcode><!-- some comment -->SOAP-ENV:MustUnderstand</faultcode>
            <faultstring><!-- some comment -->SOAP Must Understand Error</faultstring>
+           <faultactor><!-- some comment -->http://schemas.xmlsoap.org/soap/envelope/actor/ultimateReceiver</faultactor>
        </SOAP-ENV:Fault>
    </SOAP-ENV:Body>
 </SOAP-ENV:Envelope>
\ No newline at end of file

Modified: webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/SOAPFaultNodeImpl.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/SOAPFaultNodeImpl.java?rev=1438877&r1=1438876&r2=1438877&view=diff
==============================================================================
--- webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/SOAPFaultNodeImpl.java (original)
+++ webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/SOAPFaultNodeImpl.java Sat Jan 26 11:06:20 2013
@@ -23,16 +23,12 @@ import org.apache.axiom.om.OMFactory;
 import org.apache.axiom.om.OMNamespace;
 import org.apache.axiom.om.OMXMLParserWrapper;
 import org.apache.axiom.om.impl.dom.ParentNode;
-import org.apache.axiom.om.impl.util.OMSerializerUtil;
 import org.apache.axiom.soap.SOAP12Constants;
 import org.apache.axiom.soap.SOAPFactory;
 import org.apache.axiom.soap.SOAPFault;
 import org.apache.axiom.soap.SOAPFaultNode;
 import org.apache.axiom.soap.SOAPProcessingException;
 
-import javax.xml.stream.XMLStreamException;
-import javax.xml.stream.XMLStreamWriter;
-
 public abstract class SOAPFaultNodeImpl extends SOAPElement implements SOAPFaultNode {
 
     public SOAPFaultNodeImpl(SOAPFault parent, SOAPFactory factory)
@@ -60,31 +56,4 @@ public abstract class SOAPFaultNodeImpl 
     public String getNodeValue() {
         return getFaultNodeValue();
     }
-
-    public void internalSerialize(
-            XMLStreamWriter writer, boolean cache)
-            throws XMLStreamException {
-        if (!cache) {
-            //No caching
-            if (this.firstChild != null) {
-                OMSerializerUtil.serializeStartpart(this, writer);
-                firstChild.internalSerialize(writer, false);
-                OMSerializerUtil.serializeEndpart(writer);
-            } else if (state == INCOMPLETE) {
-                OMSerializerUtil.serializeByPullStream(this, writer);
-            } else {
-                OMSerializerUtil.serializeNormal(this, writer, cache);
-            }
-            // do not serialise the siblings
-
-
-        } else {
-            //Cached
-            OMSerializerUtil.serializeNormal(this, writer, cache);
-
-            // do not serialise the siblings
-        }
-
-
-    }
 }

Modified: webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/SOAPFaultRoleImpl.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/SOAPFaultRoleImpl.java?rev=1438877&r1=1438876&r2=1438877&view=diff
==============================================================================
--- webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/SOAPFaultRoleImpl.java (original)
+++ webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/SOAPFaultRoleImpl.java Sat Jan 26 11:06:20 2013
@@ -23,15 +23,11 @@ import org.apache.axiom.om.OMFactory;
 import org.apache.axiom.om.OMNamespace;
 import org.apache.axiom.om.OMXMLParserWrapper;
 import org.apache.axiom.om.impl.dom.ParentNode;
-import org.apache.axiom.om.impl.util.OMSerializerUtil;
 import org.apache.axiom.soap.SOAPFactory;
 import org.apache.axiom.soap.SOAPFault;
 import org.apache.axiom.soap.SOAPFaultRole;
 import org.apache.axiom.soap.SOAPProcessingException;
 
-import javax.xml.stream.XMLStreamException;
-import javax.xml.stream.XMLStreamWriter;
-
 public abstract class SOAPFaultRoleImpl extends SOAPElement implements
         SOAPFaultRole {
 
@@ -57,28 +53,4 @@ public abstract class SOAPFaultRoleImpl 
     public String getRoleValue() {
         return this.getText();
     }
-
-    public void internalSerialize(XMLStreamWriter writer, boolean cache)
-            throws XMLStreamException {
-        if (!cache) {
-            //No caching
-            if (this.firstChild != null) {
-                OMSerializerUtil.serializeStartpart(this, writer);
-                firstChild.internalSerialize(writer, false);
-                OMSerializerUtil.serializeEndpart(writer);
-            } else if (state == INCOMPLETE) {
-                OMSerializerUtil.serializeByPullStream(this, writer);
-            } else {
-                OMSerializerUtil.serializeNormal(this, writer, cache);
-            }
-            // do not serialise the siblings
-
-
-        } else {
-            //Cached
-            OMSerializerUtil.serializeNormal(this, writer, cache);
-
-            // do not serialise the siblings
-        }
-    }
 }

Modified: webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap11/SOAP11FaultCodeImpl.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap11/SOAP11FaultCodeImpl.java?rev=1438877&r1=1438876&r2=1438877&view=diff
==============================================================================
--- webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap11/SOAP11FaultCodeImpl.java (original)
+++ webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap11/SOAP11FaultCodeImpl.java Sat Jan 26 11:06:20 2013
@@ -25,7 +25,6 @@ import org.apache.axiom.om.OMFactory;
 import org.apache.axiom.om.OMNamespace;
 import org.apache.axiom.om.OMXMLParserWrapper;
 import org.apache.axiom.om.impl.dom.ParentNode;
-import org.apache.axiom.om.impl.util.OMSerializerUtil;
 import org.apache.axiom.soap.SOAP11Constants;
 import org.apache.axiom.soap.SOAPFactory;
 import org.apache.axiom.soap.SOAPFault;
@@ -35,8 +34,6 @@ import org.apache.axiom.soap.SOAPProcess
 import org.apache.axiom.soap.impl.dom.SOAPFaultCodeImpl;
 
 import javax.xml.namespace.QName;
-import javax.xml.stream.XMLStreamException;
-import javax.xml.stream.XMLStreamWriter;
 
 public class SOAP11FaultCodeImpl extends SOAPFaultCodeImpl {
     public SOAP11FaultCodeImpl(ParentNode parentNode, OMNamespace ns, OMXMLParserWrapper builder,
@@ -77,18 +74,6 @@ public class SOAP11FaultCodeImpl extends
         }
     }
 
-    public void internalSerialize(
-            XMLStreamWriter writer, boolean cache)
-            throws XMLStreamException {
-
-        OMSerializerUtil.serializeStartpart(this,
-                                            SOAP11Constants.SOAP_FAULT_CODE_LOCAL_NAME,
-                                            writer);
-
-        writer.writeCharacters(this.getText());
-        writer.writeEndElement();
-    }
-
     public String getLocalName() {
         return SOAP11Constants.SOAP_FAULT_CODE_LOCAL_NAME;
     }

Modified: webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap11/SOAP11FaultReasonImpl.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap11/SOAP11FaultReasonImpl.java?rev=1438877&r1=1438876&r2=1438877&view=diff
==============================================================================
--- webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap11/SOAP11FaultReasonImpl.java (original)
+++ webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap11/SOAP11FaultReasonImpl.java Sat Jan 26 11:06:20 2013
@@ -25,7 +25,6 @@ import org.apache.axiom.om.OMFactory;
 import org.apache.axiom.om.OMNamespace;
 import org.apache.axiom.om.OMXMLParserWrapper;
 import org.apache.axiom.om.impl.dom.ParentNode;
-import org.apache.axiom.om.impl.util.OMSerializerUtil;
 import org.apache.axiom.soap.SOAP11Constants;
 import org.apache.axiom.soap.SOAPFactory;
 import org.apache.axiom.soap.SOAPFault;
@@ -33,9 +32,6 @@ import org.apache.axiom.soap.SOAPFaultTe
 import org.apache.axiom.soap.SOAPProcessingException;
 import org.apache.axiom.soap.impl.dom.SOAPFaultReasonImpl;
 
-import javax.xml.stream.XMLStreamException;
-import javax.xml.stream.XMLStreamWriter;
-
 public class SOAP11FaultReasonImpl extends SOAPFaultReasonImpl {
     public SOAP11FaultReasonImpl(ParentNode parentNode, OMNamespace ns, OMXMLParserWrapper builder,
             OMFactory factory, boolean generateNSDecl) {
@@ -61,17 +57,6 @@ public class SOAP11FaultReasonImpl exten
         }
     }
 
-    public void internalSerialize(XMLStreamWriter writer, boolean cache)
-            throws XMLStreamException {
-
-        OMSerializerUtil.serializeStartpart(this,
-                                            SOAP11Constants.SOAP_FAULT_STRING_LOCAL_NAME,
-                                            writer);
-
-        writer.writeCharacters(this.getText());
-        writer.writeEndElement();
-    }
-
     public String getLocalName() {
         return SOAP11Constants.SOAP_FAULT_STRING_LOCAL_NAME;
     }

Modified: webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap11/SOAP11FaultRoleImpl.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap11/SOAP11FaultRoleImpl.java?rev=1438877&r1=1438876&r2=1438877&view=diff
==============================================================================
--- webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap11/SOAP11FaultRoleImpl.java (original)
+++ webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/soap11/SOAP11FaultRoleImpl.java Sat Jan 26 11:06:20 2013
@@ -25,16 +25,12 @@ import org.apache.axiom.om.OMFactory;
 import org.apache.axiom.om.OMNamespace;
 import org.apache.axiom.om.OMXMLParserWrapper;
 import org.apache.axiom.om.impl.dom.ParentNode;
-import org.apache.axiom.om.impl.util.OMSerializerUtil;
 import org.apache.axiom.soap.SOAP11Constants;
 import org.apache.axiom.soap.SOAPFactory;
 import org.apache.axiom.soap.SOAPFault;
 import org.apache.axiom.soap.SOAPProcessingException;
 import org.apache.axiom.soap.impl.dom.SOAPFaultRoleImpl;
 
-import javax.xml.stream.XMLStreamException;
-import javax.xml.stream.XMLStreamWriter;
-
 public class SOAP11FaultRoleImpl extends SOAPFaultRoleImpl {
 
     public SOAP11FaultRoleImpl(SOAPFault parent, SOAPFactory factory)
@@ -56,17 +52,6 @@ public class SOAP11FaultRoleImpl extends
         }
     }
 
-    public void internalSerialize(XMLStreamWriter writer, boolean cache)
-            throws XMLStreamException {
-
-        OMSerializerUtil.serializeStartpart(this,
-                                            SOAP11Constants.SOAP_FAULT_ACTOR_LOCAL_NAME,
-                                            writer);
-
-        writer.writeCharacters(this.getText());
-        writer.writeEndElement();
-    }
-
     protected OMElement createClone(OMCloneOptions options, ParentNode targetParent,
             boolean generateNSDecl) {
         return new SOAP11FaultRoleImpl(targetParent, namespace, null, factory, generateNSDecl);

Modified: webservices/axiom/trunk/modules/axiom-dom/src/test/java/org/apache/axiom/soap/impl/dom/SOAPImplementationTest.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/modules/axiom-dom/src/test/java/org/apache/axiom/soap/impl/dom/SOAPImplementationTest.java?rev=1438877&r1=1438876&r2=1438877&view=diff
==============================================================================
--- webservices/axiom/trunk/modules/axiom-dom/src/test/java/org/apache/axiom/soap/impl/dom/SOAPImplementationTest.java (original)
+++ webservices/axiom/trunk/modules/axiom-dom/src/test/java/org/apache/axiom/soap/impl/dom/SOAPImplementationTest.java Sat Jan 26 11:06:20 2013
@@ -54,9 +54,6 @@ public class SOAPImplementationTest exte
         // TODO: AXIOM-430
         builder.exclude(TestSerialize.class, "(&(file=*/empty-header.xml)(|(serializationStrategy=OutputStream)(serializationStrategy=Writer)(serializationStrategy=XMLStreamWriter))(|(cache=true)(expand=fully)))");
         
-        // TODO
-        builder.exclude(TestSerialize.class, "(&(file=*/faultstring-with-comment.xml)(|(serializationStrategy=OutputStream)(serializationStrategy=Writer)(serializationStrategy=XMLStreamWriter))(|(cache=true)(expand=fully)))");
-        
         return builder.build();
     }
 }

Modified: webservices/axiom/trunk/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap11/SOAP11FaultCodeImpl.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap11/SOAP11FaultCodeImpl.java?rev=1438877&r1=1438876&r2=1438877&view=diff
==============================================================================
--- webservices/axiom/trunk/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap11/SOAP11FaultCodeImpl.java (original)
+++ webservices/axiom/trunk/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap11/SOAP11FaultCodeImpl.java Sat Jan 26 11:06:20 2013
@@ -21,7 +21,6 @@ package org.apache.axiom.soap.impl.llom.
 
 import org.apache.axiom.om.OMElement;
 import org.apache.axiom.om.OMXMLParserWrapper;
-import org.apache.axiom.om.impl.util.OMSerializerUtil;
 import org.apache.axiom.soap.SOAP11Constants;
 import org.apache.axiom.soap.SOAPFactory;
 import org.apache.axiom.soap.SOAPFault;
@@ -31,8 +30,6 @@ import org.apache.axiom.soap.SOAPProcess
 import org.apache.axiom.soap.impl.llom.SOAPFaultCodeImpl;
 
 import javax.xml.namespace.QName;
-import javax.xml.stream.XMLStreamException;
-import javax.xml.stream.XMLStreamWriter;
 
 public class SOAP11FaultCodeImpl extends SOAPFaultCodeImpl {
 
@@ -73,16 +70,6 @@ public class SOAP11FaultCodeImpl extends
         }
     }
 
-    public void internalSerialize(XMLStreamWriter writer, boolean cache)
-            throws XMLStreamException {
-        OMSerializerUtil.serializeStartpart(this,
-                                            SOAP11Constants.SOAP_FAULT_CODE_LOCAL_NAME,
-                                            writer);
-
-        writer.writeCharacters(this.getText());
-        writer.writeEndElement();
-    }
-
     public String getLocalName() {
         return SOAP11Constants.SOAP_FAULT_CODE_LOCAL_NAME;
     }

Modified: webservices/axiom/trunk/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap11/SOAP11FaultReasonImpl.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap11/SOAP11FaultReasonImpl.java?rev=1438877&r1=1438876&r2=1438877&view=diff
==============================================================================
--- webservices/axiom/trunk/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap11/SOAP11FaultReasonImpl.java (original)
+++ webservices/axiom/trunk/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap11/SOAP11FaultReasonImpl.java Sat Jan 26 11:06:20 2013
@@ -21,7 +21,6 @@ package org.apache.axiom.soap.impl.llom.
 
 import org.apache.axiom.om.OMElement;
 import org.apache.axiom.om.OMXMLParserWrapper;
-import org.apache.axiom.om.impl.util.OMSerializerUtil;
 import org.apache.axiom.soap.SOAP11Constants;
 import org.apache.axiom.soap.SOAPFactory;
 import org.apache.axiom.soap.SOAPFault;
@@ -29,9 +28,6 @@ import org.apache.axiom.soap.SOAPFaultTe
 import org.apache.axiom.soap.SOAPProcessingException;
 import org.apache.axiom.soap.impl.llom.SOAPFaultReasonImpl;
 
-import javax.xml.stream.XMLStreamException;
-import javax.xml.stream.XMLStreamWriter;
-
 public class SOAP11FaultReasonImpl extends SOAPFaultReasonImpl {
     public SOAP11FaultReasonImpl(SOAPFactory factory) {
         super(null, factory);
@@ -64,17 +60,6 @@ public class SOAP11FaultReasonImpl exten
         }
     }
 
-    public void internalSerialize(XMLStreamWriter writer, boolean cache)
-            throws XMLStreamException {
-        // Special syntax
-        OMSerializerUtil.serializeStartpart(this,
-                                            SOAP11Constants.SOAP_FAULT_STRING_LOCAL_NAME,
-                                            writer);
-
-        writer.writeCharacters(this.getText());
-        writer.writeEndElement();
-    }
-
     public String getLocalName() {
         return SOAP11Constants.SOAP_FAULT_STRING_LOCAL_NAME;
     }

Modified: webservices/axiom/trunk/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap11/SOAP11FaultRoleImpl.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap11/SOAP11FaultRoleImpl.java?rev=1438877&r1=1438876&r2=1438877&view=diff
==============================================================================
--- webservices/axiom/trunk/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap11/SOAP11FaultRoleImpl.java (original)
+++ webservices/axiom/trunk/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/soap11/SOAP11FaultRoleImpl.java Sat Jan 26 11:06:20 2013
@@ -21,16 +21,11 @@ package org.apache.axiom.soap.impl.llom.
 
 import org.apache.axiom.om.OMElement;
 import org.apache.axiom.om.OMXMLParserWrapper;
-import org.apache.axiom.om.impl.util.OMSerializerUtil;
-import org.apache.axiom.soap.SOAP11Constants;
 import org.apache.axiom.soap.SOAPFactory;
 import org.apache.axiom.soap.SOAPFault;
 import org.apache.axiom.soap.SOAPProcessingException;
 import org.apache.axiom.soap.impl.llom.SOAPFaultRoleImpl;
 
-import javax.xml.stream.XMLStreamException;
-import javax.xml.stream.XMLStreamWriter;
-
 public class SOAP11FaultRoleImpl extends SOAPFaultRoleImpl {
 
     public SOAP11FaultRoleImpl(SOAPFault parent, SOAPFactory factory)
@@ -53,17 +48,4 @@ public class SOAP11FaultRoleImpl extends
                     "Expecting SOAP11FaultImpl, got " + parent.getClass());
         }
     }
-
-    public void internalSerialize(XMLStreamWriter writer, boolean cache)
-            throws XMLStreamException {
-
-        OMSerializerUtil.serializeStartpart(this,
-                                            SOAP11Constants.SOAP_FAULT_ACTOR_LOCAL_NAME,
-                                            writer);
-
-        writer.writeCharacters(this.getText());
-        writer.writeEndElement();
-    }
-
-
 }

Modified: webservices/axiom/trunk/modules/axiom-impl/src/test/java/org/apache/axiom/soap/impl/llom/SOAPImplementationTest.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/modules/axiom-impl/src/test/java/org/apache/axiom/soap/impl/llom/SOAPImplementationTest.java?rev=1438877&r1=1438876&r2=1438877&view=diff
==============================================================================
--- webservices/axiom/trunk/modules/axiom-impl/src/test/java/org/apache/axiom/soap/impl/llom/SOAPImplementationTest.java (original)
+++ webservices/axiom/trunk/modules/axiom-impl/src/test/java/org/apache/axiom/soap/impl/llom/SOAPImplementationTest.java Sat Jan 26 11:06:20 2013
@@ -32,9 +32,6 @@ public class SOAPImplementationTest exte
         // TODO: AXIOM-430
         builder.exclude(TestSerialize.class, "(&(file=*/empty-header.xml)(|(serializationStrategy=OutputStream)(serializationStrategy=Writer)(serializationStrategy=XMLStreamWriter))(|(cache=true)(expand=fully)))");
         
-        // TODO
-        builder.exclude(TestSerialize.class, "(&(file=*/faultstring-with-comment.xml)(|(serializationStrategy=OutputStream)(serializationStrategy=Writer)(serializationStrategy=XMLStreamWriter))(|(cache=true)(expand=fully)))");
-        
         return builder.build();
     }
 }

Modified: webservices/axiom/trunk/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/SOAPTestSuiteBuilder.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/SOAPTestSuiteBuilder.java?rev=1438877&r1=1438876&r2=1438877&view=diff
==============================================================================
--- webservices/axiom/trunk/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/SOAPTestSuiteBuilder.java (original)
+++ webservices/axiom/trunk/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/SOAPTestSuiteBuilder.java Sat Jan 26 11:06:20 2013
@@ -42,7 +42,7 @@ public class SOAPTestSuiteBuilder extend
     private static final String[] goodSOAPFiles = { TestConstants.WHITESPACE_MESSAGE,
         TestConstants.MINIMAL_MESSAGE, TestConstants.REALLY_BIG_MESSAGE,
         TestConstants.EMPTY_BODY_MESSAGE, "soap/soap11/soapfault.xml", "soap/soap11/bodyNotQualified.xml",
-        "soap/soap11/faultstring-with-comment.xml", "soap/soap11/additional-element-after-body.xml",
+        "soap/soap11/faultelements-with-comment.xml", "soap/soap11/additional-element-after-body.xml",
         "soap/soap11/message_without_header.xml", "soap/soap12/message_without_header.xml",
         "soap/soap11/empty-header.xml", "soap/soap12/empty-header.xml" };