You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Konstantin Boudnik (JIRA)" <ji...@apache.org> on 2010/10/30 08:10:20 UTC

[jira] Created: (HDFS-1486) Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)

Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)
-------------------------------------------------------------------------------------------------

                 Key: HDFS-1486
                 URL: https://issues.apache.org/jira/browse/HDFS-1486
             Project: Hadoop HDFS
          Issue Type: Improvement
            Reporter: Konstantin Boudnik
            Assignee: Konstantin Boudnik


HDFS part of HADOOP-7014. HDFS side of TestCLI doesn't require any special changes but needs to be aligned with Common

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] [Commented] (HDFS-1486) Generalize CLITest structure and interfaces to facilitate upstream adoption (e.g. for web testing)

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020706#comment-13020706 ] 

Hudson commented on HDFS-1486:
------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #597 (See [https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/597/])
    HDFS-1486. Generalize CLITest structure and interfaces to facilitate upstream
adoption (e.g. for web testing). Contributed by Konstantin Boudnik.


> Generalize CLITest structure and interfaces to facilitate upstream adoption (e.g. for web testing)
> --------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1486
>                 URL: https://issues.apache.org/jira/browse/HDFS-1486
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch
>
>
> HDFS part of HADOOP-7014. HDFS side of TestCLI doesn't require any special changes but needs to be aligned with Common

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (HDFS-1486) Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HDFS-1486:
-------------------------------------

    Attachment:     (was: HADOOP-7014.patch)

> Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1486
>                 URL: https://issues.apache.org/jira/browse/HDFS-1486
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-1486.patch, HDFS-1486.patch
>
>
> HDFS part of HADOOP-7014. HDFS side of TestCLI doesn't require any special changes but needs to be aligned with Common

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] [Commented] (HDFS-1486) Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020498#comment-13020498 ] 

Konstantin Boudnik commented on HDFS-1486:
------------------------------------------

I have also ran full test cycle and see only 
{noformat}
    [junit] Tests run: 7, Failures: 0, Errors: 2, Time elapsed: 14.762 sec
    [junit] Test org.apache.hadoop.hdfs.TestFileConcurrentReader FAILED
{noformat}

with {{java.io.IOException: Too many open files}}. Apparently isn't caused by the change in question.


> Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1486
>                 URL: https://issues.apache.org/jira/browse/HDFS-1486
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch
>
>
> HDFS part of HADOOP-7014. HDFS side of TestCLI doesn't require any special changes but needs to be aligned with Common

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-1486) Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020704#comment-13020704 ] 

Konstantin Boudnik commented on HDFS-1486:
------------------------------------------

Well, waiting for test-patch does't make sense. Test-patch won't be able to complete because the very first step of the validation will always fail because the compilation will be failing (current HDFS won't compile against new Common because of the API incompatibility). Thus, the testing I have done above seems to be sufficient and the only possible in this situation. 

I am going to commit this patch to fix the build.



> Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1486
>                 URL: https://issues.apache.org/jira/browse/HDFS-1486
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch
>
>
> HDFS part of HADOOP-7014. HDFS side of TestCLI doesn't require any special changes but needs to be aligned with Common

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (HDFS-1486) Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HDFS-1486:
-------------------------------------

    Attachment: HDFS-1486.patch

Aligning names with last downstream patch

> Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1486
>                 URL: https://issues.apache.org/jira/browse/HDFS-1486
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch
>
>
> HDFS part of HADOOP-7014. HDFS side of TestCLI doesn't require any special changes but needs to be aligned with Common

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] [Updated] (HDFS-1486) Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HDFS-1486:
-------------------------------------

    Status: Patch Available  (was: Open)

ready to roll.

> Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1486
>                 URL: https://issues.apache.org/jira/browse/HDFS-1486
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch
>
>
> HDFS part of HADOOP-7014. HDFS side of TestCLI doesn't require any special changes but needs to be aligned with Common

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-1486) Generalize CLITest structure and interfaces to facilitate upstream adoption (e.g. for web testing)

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HDFS-1486:
-------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I have just committed this.

> Generalize CLITest structure and interfaces to facilitate upstream adoption (e.g. for web testing)
> --------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1486
>                 URL: https://issues.apache.org/jira/browse/HDFS-1486
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch
>
>
> HDFS part of HADOOP-7014. HDFS side of TestCLI doesn't require any special changes but needs to be aligned with Common

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (HDFS-1486) Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931976#action_12931976 ] 

Eli Collins commented on HDFS-1486:
-----------------------------------

Hey Cos,

In CmdFactoryDFS seems like getCommandExecutor should be a method of CLICommand, this way you don't need to check cmd instanceof CLITestData.CLITestCmd, and saves you from having CLITestCmd specific implementation code in the abstract CmdFactoryDFS class?   Otherwise looks great.

Thanks,
Eli


> Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1486
>                 URL: https://issues.apache.org/jira/browse/HDFS-1486
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch
>
>
> HDFS part of HADOOP-7014. HDFS side of TestCLI doesn't require any special changes but needs to be aligned with Common

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] [Updated] (HDFS-1486) Generalize CLITest structure and interfaces to facilitate upstream adoption (e.g. for web testing)

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HDFS-1486:
-------------------------------------

    Summary: Generalize CLITest structure and interfaces to facilitate upstream adoption (e.g. for web testing)  (was: Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing))

> Generalize CLITest structure and interfaces to facilitate upstream adoption (e.g. for web testing)
> --------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1486
>                 URL: https://issues.apache.org/jira/browse/HDFS-1486
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch
>
>
> HDFS part of HADOOP-7014. HDFS side of TestCLI doesn't require any special changes but needs to be aligned with Common

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (HDFS-1486) Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HDFS-1486:
-------------------------------------

    Affects Version/s:     (was: 0.22.0)
                       0.23.0

> Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1486
>                 URL: https://issues.apache.org/jira/browse/HDFS-1486
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch
>
>
> HDFS part of HADOOP-7014. HDFS side of TestCLI doesn't require any special changes but needs to be aligned with Common

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HDFS-1486) Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931987#action_12931987 ] 

Konstantin Boudnik commented on HDFS-1486:
------------------------------------------

I like the idea! It won't free me from casting CLICommand to CLITestData.CLITestCmd but we won't need to have factory classes whatsoever, I think.

This will actually require to change HADOOP-7014 first though. I'll publish new patch shortly.

> Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1486
>                 URL: https://issues.apache.org/jira/browse/HDFS-1486
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch
>
>
> HDFS part of HADOOP-7014. HDFS side of TestCLI doesn't require any special changes but needs to be aligned with Common

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HDFS-1486) Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931988#action_12931988 ] 

Eli Collins commented on HDFS-1486:
-----------------------------------

If you override getCommandExecutor it should save you the cast, ie the appropriate method will be called.

> Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1486
>                 URL: https://issues.apache.org/jira/browse/HDFS-1486
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch
>
>
> HDFS part of HADOOP-7014. HDFS side of TestCLI doesn't require any special changes but needs to be aligned with Common

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] [Updated] (HDFS-1486) Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HDFS-1486:
-------------------------------------

    Attachment: HDFS-1486.patch

Rebasing against current trunk

> Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1486
>                 URL: https://issues.apache.org/jira/browse/HDFS-1486
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch
>
>
> HDFS part of HADOOP-7014. HDFS side of TestCLI doesn't require any special changes but needs to be aligned with Common

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-1486) Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020397#comment-13020397 ] 

Konstantin Boudnik commented on HDFS-1486:
------------------------------------------

Running commit tests:
{noformat}
% ant run-commit-test  -Dresolvers=internal
Buildfile: /home/cos/work/H0.23/git/hdfs/build.xml
...
[ivy:resolve] downloading /home/xxx/.m2/repository/org/apache/hadoop/hadoop-common/0.23.0-SNAPSHOT/hadoop-common-0.23.0-SNAPSHOT.jar ...
[ivy:resolve] ....................... (1401kB)
[ivy:resolve]   [SUCCESSFUL ] org.apache.hadoop#hadoop-common;0.23.0-SNAPSHOT!hadoop-common.jar (34ms)
...
    [junit] Running org.apache.hadoop.cli.TestHDFSCLI
    [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 53.218 sec
...
checkfailure:

BUILD SUCCESSFUL
Total time: 16 minutes 47 seconds
{noformat}

As I mentioned in the parent JIRA it is difficult to run test-patch for cross-projects change like this one.


> Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1486
>                 URL: https://issues.apache.org/jira/browse/HDFS-1486
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch
>
>
> HDFS part of HADOOP-7014. HDFS side of TestCLI doesn't require any special changes but needs to be aligned with Common

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-1486) Generalize CLITest structure and interfaces to facilitate upstream adoption (e.g. for web testing)

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022447#comment-13022447 ] 

Hudson commented on HDFS-1486:
------------------------------

Integrated in Hadoop-Hdfs-trunk #643 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/])
    

> Generalize CLITest structure and interfaces to facilitate upstream adoption (e.g. for web testing)
> --------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1486
>                 URL: https://issues.apache.org/jira/browse/HDFS-1486
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.23.0
>
>         Attachments: HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch
>
>
> HDFS part of HADOOP-7014. HDFS side of TestCLI doesn't require any special changes but needs to be aligned with Common

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (HDFS-1486) Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HDFS-1486:
-------------------------------------

    Attachment: HADOOP-7014.patch

Well, renamed files were missed from the patch. Fixed.

> Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1486
>                 URL: https://issues.apache.org/jira/browse/HDFS-1486
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-1486.patch, HDFS-1486.patch
>
>
> HDFS part of HADOOP-7014. HDFS side of TestCLI doesn't require any special changes but needs to be aligned with Common

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HDFS-1486) Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HDFS-1486:
-------------------------------------

    Attachment: HDFS-1486.patch

Renaming interface as per latest changes of the downstream JIRA.

> Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1486
>                 URL: https://issues.apache.org/jira/browse/HDFS-1486
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-1486.patch, HDFS-1486.patch
>
>
> HDFS part of HADOOP-7014. HDFS side of TestCLI doesn't require any special changes but needs to be aligned with Common

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HDFS-1486) Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HDFS-1486:
-------------------------------------

          Component/s: test
    Affects Version/s: 0.22.0

> Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1486
>                 URL: https://issues.apache.org/jira/browse/HDFS-1486
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-1486.patch, HDFS-1486.patch
>
>
> HDFS part of HADOOP-7014. HDFS side of TestCLI doesn't require any special changes but needs to be aligned with Common

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HDFS-1486) Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HDFS-1486:
-------------------------------------

    Attachment: HDFS-1486.patch

Corresponding fix.

> Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1486
>                 URL: https://issues.apache.org/jira/browse/HDFS-1486
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-1486.patch
>
>
> HDFS part of HADOOP-7014. HDFS side of TestCLI doesn't require any special changes but needs to be aligned with Common

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] [Updated] (HDFS-1486) Generalize CLITest structure and interfaces to facilitate upstream adoption (e.g. for web testing)

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HDFS-1486:
-------------------------------------

    Fix Version/s: 0.23.0

> Generalize CLITest structure and interfaces to facilitate upstream adoption (e.g. for web testing)
> --------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1486
>                 URL: https://issues.apache.org/jira/browse/HDFS-1486
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.23.0
>
>         Attachments: HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch
>
>
> HDFS part of HADOOP-7014. HDFS side of TestCLI doesn't require any special changes but needs to be aligned with Common

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (HDFS-1486) Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931994#action_12931994 ] 

Konstantin Boudnik commented on HDFS-1486:
------------------------------------------

Eli, I was looking deeper into this code structure optimisation after our off-line conversation. While the code structure is in apparent need to be refactored/cleaned it seems like it is a much bigger problem than this little generalisation.

If you suggest that this particular effort is being postponed until the overall code structure is improved - it is fine with me. It is just a bigger task.

> Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1486
>                 URL: https://issues.apache.org/jira/browse/HDFS-1486
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch
>
>
> HDFS part of HADOOP-7014. HDFS side of TestCLI doesn't require any special changes but needs to be aligned with Common

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HDFS-1486) Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HDFS-1486:
-------------------------------------

    Attachment: HDFS-1486.patch

Changes corresponding to the latest HADOOP-7014. TestStorageRestore is failing because of HDFS-1496

> Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1486
>                 URL: https://issues.apache.org/jira/browse/HDFS-1486
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch
>
>
> HDFS part of HADOOP-7014. HDFS side of TestCLI doesn't require any special changes but needs to be aligned with Common

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.