You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by ijokarumawak <gi...@git.apache.org> on 2017/04/03 07:02:47 UTC
[GitHub] nifi pull request #1646: NIFI-3668: Fix purging expired replicate requests.
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/1646
NIFI-3668: Fix purging expired replicate requests.
Newly created async response is added before checking map size nor
purging expired ones. If there are already 100 remaining requests,
the added request will not be executed nor removed.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-3668
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1646.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1646
----
commit e6955f01fdc6af73adbfd846b488083ca5ee672a
Author: Koji Kawamura <ij...@apache.org>
Date: 2017-04-03T06:56:21Z
NIFI-3668: Fix purging expired replicate requests.
Newly created async response is added before checking map size nor
purging expired ones. If there are already 100 remaining requests,
the added request will not be executed nor removed.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1646: NIFI-3668: Fix purging expired replicate requests.
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1646
Thanks @ijokarumawak - that's a great catch! Glad you noticed it before this was released. The code looks good. Building to test now. If all looks good, will merge in a few mins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1646: NIFI-3668: Fix purging expired replicate requests.
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1646
@markap14 Would you review this fix since you originally worked on NIFI-3636.
I've reproduced the issue with following test method which sends lots of S2S client requests concurrently against a NiFi cluster. The issue was reproducible before this patch and confirmed it's addressed by this patch:
```java
@Test
public void test() throws Exception {
final ExecutorService executors = Executors.newFixedThreadPool(100);
final AtomicInteger processed = new AtomicInteger();
final AtomicInteger error = new AtomicInteger();
for (int i = 0; i < 1000; i++) {
executors.submit(() -> {
try (final SiteToSiteClient client = new SiteToSiteClient.Builder()
.transportProtocol(SiteToSiteTransportProtocol.HTTP)
.url("http://localhost:9011/nifi/")
.portName("input")
.build()) {
final Transaction transaction = client.createTransaction(TransferDirection.SEND);
transaction.send("test".getBytes(), new HashMap<>());
transaction.confirm();
transaction.complete();
processed.incrementAndGet();
} catch (Exception e) {
logger.error("ERR!", e);
error.incrementAndGet();
}
});
}
executors.shutdown();
executors.awaitTermination(1, TimeUnit.DAYS);
logger.warn("processed={}, err={}", new Object[]{processed.get(), error.get()});
}
```
On Mac OS X Sierra, I had to increase file descriptor limit to make above test works by creating limit.maxfiles.plist and limit.maxproc.plist as described in these web pages:
- https://www.chrissearle.org/2016/10/01/too-many-open-files-on-osx-macos/
- https://superuser.com/questions/830149/os-x-yosemite-too-many-files-open
I hope the fix still preserve the performance gain in clustered environment that have been added by NIFI-3636. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1646: NIFI-3668: Fix purging expired replicate requests.
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1646
@ijokarumawak all still seems to work as expected. +1 merged to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1646: NIFI-3668: Fix purging expired replicate requests.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1646
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---