You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "jerqi (via GitHub)" <gi...@apache.org> on 2023/05/16 03:03:14 UTC
[GitHub] [incubator-uniffle] jerqi opened a new pull request, #883: [MINOR] Remove unused code of shuffle upload
jerqi opened a new pull request, #883:
URL: https://github.com/apache/incubator-uniffle/pull/883
### What changes were proposed in this pull request?
1. Remove the meta lock, this lock is used for upload shuffle function.
2. Remove the meta of upload shuffle function.
### Why are the changes needed?
Simplify our logic
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
GA passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi merged pull request #883: [MINOR] Remove unused code of shuffle upload
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #883:
URL: https://github.com/apache/incubator-uniffle/pull/883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #883: [MINOR] Remove unused code of shuffle upload
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #883:
URL: https://github.com/apache/incubator-uniffle/pull/883#issuecomment-1549040900
Merged to master. thanks @zuston
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #883: [MINOR] Remove unused code of shuffle upload
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #883:
URL: https://github.com/apache/incubator-uniffle/pull/883#issuecomment-1548915090
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/883?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#883](https://app.codecov.io/gh/apache/incubator-uniffle/pull/883?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0d83601) into [master](https://app.codecov.io/gh/apache/incubator-uniffle/commit/e1e5fa8ed65b71d4b1ef49684704d01d8e5bc949?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e1e5fa8) will **increase** coverage by `1.72%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 0d83601 differs from pull request most recent head 5b4d101. Consider uploading reports for the commit 5b4d101 to get more accurate results
```diff
@@ Coverage Diff @@
## master #883 +/- ##
============================================
+ Coverage 56.60% 58.32% +1.72%
+ Complexity 2184 2149 -35
============================================
Files 327 307 -20
Lines 15983 13545 -2438
Branches 1258 1247 -11
============================================
- Hits 9047 7900 -1147
+ Misses 6425 5214 -1211
+ Partials 511 431 -80
```
| [Impacted Files](https://app.codecov.io/gh/apache/incubator-uniffle/pull/883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/uniffle/server/storage/SingleStorageManager.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9zdG9yYWdlL1NpbmdsZVN0b3JhZ2VNYW5hZ2VyLmphdmE=) | `74.19% <ø> (+3.60%)` | :arrow_up: |
| [...org/apache/uniffle/storage/common/HdfsStorage.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2NvbW1vbi9IZGZzU3RvcmFnZS5qYXZh) | `0.00% <ø> (ø)` | |
| [...rg/apache/uniffle/storage/common/LocalStorage.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2NvbW1vbi9Mb2NhbFN0b3JhZ2UuamF2YQ==) | `50.00% <0.00%> (-10.77%)` | :arrow_down: |
| [...pache/uniffle/storage/common/LocalStorageMeta.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2NvbW1vbi9Mb2NhbFN0b3JhZ2VNZXRhLmphdmE=) | `13.46% <ø> (-71.24%)` | :arrow_down: |
... and [25 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-uniffle/pull/883/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #883: [MINOR] Remove unused code of shuffle upload
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #883:
URL: https://github.com/apache/incubator-uniffle/pull/883#issuecomment-1548917283
cc @awdavidson. It will be easier to fix #881 after this pr. Because I simplify the unused logic of meta in this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org