You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/01/08 22:50:19 UTC

[GitHub] [nifi] alopresto commented on a change in pull request #3968: NIFI-3383 Implemented encrypted flowfile repository

alopresto commented on a change in pull request #3968: NIFI-3383 Implemented encrypted flowfile repository
URL: https://github.com/apache/nifi/pull/3968#discussion_r364482716
 
 

 ##########
 File path: nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java
 ##########
 @@ -44,6 +46,7 @@
  * over time.
  */
 public abstract class NiFiProperties {
+    private static final Logger logger = LoggerFactory.getLogger(NiFiProperties.class);
 
 Review comment:
   I understand introducing logging into this module may be undesirable. I feel that there are certain scenarios which are detected internal to logic here which dictate logging a warning, but if there are impactful side-effects, this can be removed. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services