You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/12/19 08:28:13 UTC
[GitHub] [commons-lang] aviProgrammer opened a new pull request #677: Javadoc correction for RandomStringUtils.random()
aviProgrammer opened a new pull request #677:
URL: https://github.com/apache/commons-lang/pull/677
Javadoc correction for RandomStringUtils.random() letters and numbers parameters to make it consistent with other overloaded random() method Javadoc for the same parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] kinow commented on a change in pull request #677: LANG-1628: Javadoc correction for RandomStringUtils.random()
Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #677:
URL: https://github.com/apache/commons-lang/pull/677#discussion_r546215376
##########
File path: src/main/java/org/apache/commons/lang3/RandomStringUtils.java
##########
@@ -309,8 +309,10 @@ public static String random(final int count, final int start, final int end, fin
* @param count the length of random string to create
* @param start the position in set of chars to start at
* @param end the position in set of chars to end before
- * @param letters only allow letters?
- * @param numbers only allow numbers?
+ * @param letters if {@code true}, generated string may include
+ * alphabetic characters
+ * @param numbers if {@code true}, generated string may include
+ * numeric characters
Review comment:
Hi @aviProgrammer , thanks for your pull request.
It looks like a good contribution! And I was ready to approve it, but I noticed we can fix it in another line further down, where the same comments appear.
If you are using the GitHub UI to read this reply, you can click on the blue arrow here twice, and on lines 348 and 349 you should find these same parameters I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] kinow commented on pull request #677: LANG-1628: Javadoc correction for RandomStringUtils.random()
Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #677:
URL: https://github.com/apache/commons-lang/pull/677#issuecomment-748517477
Merged. Thanks for your contribution @aviProgrammer !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] kinow closed pull request #677: LANG-1628: Javadoc correction for RandomStringUtils.random()
Posted by GitBox <gi...@apache.org>.
kinow closed pull request #677:
URL: https://github.com/apache/commons-lang/pull/677
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] aviProgrammer commented on a change in pull request #677: LANG-1628: Javadoc correction for RandomStringUtils.random()
Posted by GitBox <gi...@apache.org>.
aviProgrammer commented on a change in pull request #677:
URL: https://github.com/apache/commons-lang/pull/677#discussion_r546249952
##########
File path: src/main/java/org/apache/commons/lang3/RandomStringUtils.java
##########
@@ -309,8 +309,10 @@ public static String random(final int count, final int start, final int end, fin
* @param count the length of random string to create
* @param start the position in set of chars to start at
* @param end the position in set of chars to end before
- * @param letters only allow letters?
- * @param numbers only allow numbers?
+ * @param letters if {@code true}, generated string may include
+ * alphabetic characters
+ * @param numbers if {@code true}, generated string may include
+ * numeric characters
Review comment:
Hi @kinow , Thanks for your observation.
The same fix of Javadoc has been applied at line 348 and 349.
Let me know in case you find any other improvements that can be done in the same Javadoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #677: LANG-1628: Javadoc correction for RandomStringUtils.random()
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #677:
URL: https://github.com/apache/commons-lang/pull/677#issuecomment-748488490
[](https://coveralls.io/builds/35838292)
Coverage remained the same at 95.016% when pulling **b73f25baaef7aacf08f4c38fb96e7be282e90b89 on aviProgrammer:LANG-1628-RandomStringUtils.random()-JavaDoc-Correction** into **55570e8ef7fe5eedc91d0eaa81f306401fafd5c3 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org