You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Paul Querna <ch...@force-elite.com> on 2005/01/23 20:44:09 UTC

[PATCH] Synchronize requests_this_child

Attached ia a patch for the Worker MPM that uses APR Atomics to change 
the value of requests_this_child.

I changed it around to count *up*, instead of counting down... So I 
would like someone else to look at it before I commit it.

Thanks,

-Paul

Re: [PATCH] Synchronize requests_this_child

Posted by Greg Ames <gr...@remulak.net>.
Paul Querna wrote:
> Attached ia a patch for the Worker MPM that uses APR Atomics to change 
> the value of requests_this_child.
> 
> I changed it around to count *up*, instead of counting down... So I 
> would like someone else to look at it before I commit it.

-0.5

What's the point?  This slows down the server for no good purpose.  Atomic 
operations are more expensive than their non-atomic counterparts.  Plus, 
switching from decrement to increment makes the loop test slightly more complex.

Yes, we will loose a few updates now and then on SMP systems.  All this variable 
does is cause child processes to exit after a while, mostly as a defense 
mechanism against memory leaks.  Mostly I see it set to 0 or something like 
10000.  I have yet to hear a complaint from a user that in the latter case a 
child process actually handled 10003 connections before exiting.

Greg