[GitHub] [hadoop-ozone] bshashikant commented on pull request #1523: HDDS-4320. Let Ozone input streams implement CanUnbuffer

[GitBox <gi...@apache.org>]

bshashikant commented on pull request #1523:
URL: https://github.com/apache/hadoop-ozone/pull/1523#issuecomment-717257127


   Thanks @adoroszlai . I am still reviewing this, however, i have couple of questions:
   1) In unbuffer, do we need to remove the corresponding blockInputStreams and chunkInputStreams which are already read?
   2) While the connection to datanode is closed, connection to OM still is kept open, do we need to close this as well?
   3) As i see the last position is cached, so after unbuffer is called, it will go into corresponding blockInputStream and chunkInputStream and starts reading again. What if the pipelne is not valid anymore i.e, the datanodes containing the blocks is replicated to a different set of datanodes? Do we need to handle this?
   
   As far as i remember , we only refresh the pipeline during initialisation of blockInputStream only.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org