You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/23 16:21:14 UTC
[GitHub] [superset] jinghua-qa opened a new issue #16403: [explore][save as ] rename a chart in explore and do 'save as' also change the name of original chart
jinghua-qa opened a new issue #16403:
URL: https://github.com/apache/superset/issues/16403
Rename a chart in explore and do 'save as' also change the name of original chart
### Expected results
When save as, will save as a new chart with name change, original chart did not change
### Actual results
When do save as, original chart also change for new the chart name
#### Screenshots
https://user-images.githubusercontent.com/81597121/130482129-a1570b7d-1b80-482b-a65d-28be34ce7e12.mov
#### How to reproduce the bug
1. open a chart in explore
2. change name and save as a new chart
3. go to chart list and observe the new chart name
4. See error
### Environment
(please complete the following information):
- superset version: lastest master
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [ ] I have reproduced the issue with at least the latest released version of superset.
- [ ] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on issue #16403: [explore][save as ] rename a chart in explore and do 'save as' also change the name of original chart
Posted by GitBox <gi...@apache.org>.
geido commented on issue #16403:
URL: https://github.com/apache/superset/issues/16403#issuecomment-904490684
@jinghua-qa @junlincc I might be missing the point but I don't see any bug in the flow that you are presenting.
First, you changed the name of the current chart by editing its properties. Then you went to save it again, but this time saving it as a new chart. However, you already changed the name while editing the properties, that is why the names of the original and new chart are now the same.
To show you what I mean, I recorded the following flow where I first edit the name by editing the properties of the original chart, then I change the name again and save it as a new chart. As you will see, the behavior works as expected.
https://user-images.githubusercontent.com/60598000/130594661-af0433e5-e171-4cdc-bf75-2e84208e846b.mp4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #16403: [explore][save as ] rename a chart in explore and do 'save as' also change the name of original chart
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16403:
URL: https://github.com/apache/superset/issues/16403#issuecomment-903955288
@geido if this seems to be an easy fix, let's prioritize it 🙏 thank you, Diego and Jinghua! @jinghua-qa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc closed issue #16403: [explore][save as ] rename a chart in explore and do 'save as' also change the name of original chart
Posted by GitBox <gi...@apache.org>.
junlincc closed issue #16403:
URL: https://github.com/apache/superset/issues/16403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #16403: [explore][save as ] rename a chart in explore and do 'save as' also change the name of original chart
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16403:
URL: https://github.com/apache/superset/issues/16403#issuecomment-920191152
sorry the issue title was not clear.
expected behavior: if user change name from the edit properties modal, and click save to exit the modal, and click save as in Explore, original chart's name should be changed.
if name change happens in the Save chart modal, the original chart's name should stay the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on issue #16403: [explore][save as ] rename a chart in explore and do 'save as' also change the name of original chart
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on issue #16403:
URL: https://github.com/apache/superset/issues/16403#issuecomment-905760813
@geido I think your explaination make sense. But the part I feel confused is, we have 2 place can save chart change, chart property and SAVE button on data panel. In the chart property modal, name change reflected immediately but the ownership is not reflected on the SAVE modal on data panel (when I add myself as owner I am not able to overwrite and only can do 'Save as') and this PR https://github.com/apache/superset/pull/16437 can help to reduce the confusion for that.
Also I think it maybe more helpful if we can make SAVE button highlight when there is unsave changed for the chart to remind user to save before leave the page. @junlincc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on issue #16403: [explore][save as ] rename a chart in explore and do 'save as' also change the name of original chart
Posted by GitBox <gi...@apache.org>.
geido commented on issue #16403:
URL: https://github.com/apache/superset/issues/16403#issuecomment-906281901
@jinghua-qa I understand where the confusion is coming from. However, I'd rather save things granularly than all at once, especially when those changes happen in separate contexts such as the Modals. I think we might want to revisit how saving is done and make it consistent across the project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org