[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2531: Add iterator for FixedSizeBinaryArray

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #2531:
URL: https://github.com/apache/arrow-rs/pull/2531#discussion_r950368522


##########
arrow/src/array/array_fixed_size_binary.rs:
##########
@@ -362,6 +368,27 @@ impl Array for FixedSizeBinaryArray {
     }
 }
 
+impl<'a> ArrayAccessor for &'a FixedSizeBinaryArray {

Review Comment:
   I am very pleased with this trait



##########
arrow/src/array/array_binary.rs:
##########
@@ -225,12 +225,10 @@ impl<OffsetSize: OffsetSizeTrait> GenericBinaryArray<OffsetSize> {
     ) -> impl Iterator<Item = Option<&[u8]>> + 'a {
         indexes.map(|opt_index| opt_index.map(|index| self.value_unchecked(index)))
     }
-}
 
-impl<'a, T: OffsetSizeTrait> GenericBinaryArray<T> {
     /// constructs a new iterator
-    pub fn iter(&'a self) -> GenericBinaryIter<'a, T> {
-        GenericBinaryIter::<'a, T>::new(self)
+    pub fn iter(&self) -> GenericBinaryIter<'_, OffsetSize> {

Review Comment:
   Drive by cleanup



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org