You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Fokko Driesprong (JIRA)" <ji...@apache.org> on 2018/08/06 09:24:00 UTC
[jira] [Resolved] (AIRFLOW-2845) Remove asserts from the contrib
code (change to legal exceptions)
[ https://issues.apache.org/jira/browse/AIRFLOW-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fokko Driesprong resolved AIRFLOW-2845.
---------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0
> Remove asserts from the contrib code (change to legal exceptions)
> ------------------------------------------------------------------
>
> Key: AIRFLOW-2845
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2845
> Project: Apache Airflow
> Issue Type: Improvement
> Components: contrib
> Affects Versions: 1.9.0
> Reporter: Iuliia Volkova
> Assignee: Iuliia Volkova
> Priority: Minor
> Labels: easyfix
> Fix For: 2.0.0
>
>
> Hi guys. `asserts` is used in Airflow contrib package code . And from point of view for which purposes asserts are really is, it's not correct.
> If we look at documentation we could find information what asserts is debug tool: [https://docs.python.org/3/reference/simple_stmts.html#the-assert-statement] and also it is could be disabled globally by default.
> If you do not mind, I will be happy to prepare PR for remove asserts from the contrib module with changing it to raising errors with correct Exceptions and messages and not just "Assertion Error".
> I talk only about src (not about asserts in tests).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)