You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2017/03/22 18:25:38 UTC
Re: Review Request 57834: Config is not shown on comparison mode if it
doesn't exist in the latest version
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57834/#review169759
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On March 22, 2017, 9:46 a.m., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57834/
> -----------------------------------------------------------
>
> (Updated March 22, 2017, 9:46 a.m.)
>
>
> Review request for Ambari and Jaimin Jetly.
>
>
> Bugs: AMBARI-20526
> https://issues.apache.org/jira/browse/AMBARI-20526
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Add custom config and save configs
> * Remove this custom config and save configs
> * Compare this to config versions
>
> *ER* Config is shown as "Undefined"
> *AR* Config is not shown
>
>
> Diffs
> -----
>
> ambari-web/app/mixins/common/configs/configs_comparator.js e9fb942
> ambari-web/test/mappers/configs/service_config_version_mapper_test.js d99864a
> ambari-web/test/mappers/configs/themes_mapper_test.js b869109
> ambari-web/test/mixins/common/configs/configs_comparator_test.js dc7534c
>
>
> Diff: https://reviews.apache.org/r/57834/diff/1/
>
>
> Testing
> -------
>
> 20620 passing (21s)
> 128 pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>