You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/02/17 14:38:27 UTC

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #1181: apps/blehci: Add full console option

andrzej-kaczmarek commented on a change in pull request #1181:
URL: https://github.com/apache/mynewt-nimble/pull/1181#discussion_r809118003



##########
File path: apps/blehci/syscfg.yml
##########
@@ -16,6 +16,15 @@
 # under the License.
 #
 
+syscfg.defs:
+    CONSOLE_MODE:
+        description: Which console to use
+        value: stub
+        choices:
+            - full
+            - minimal
+            - stub

Review comment:
       I'd add this setting to sys/console instead so we can include sys/console instead of specific package in app and select via syscfg, similar as we did it for hci transport some time ago




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org