You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by zh...@apache.org on 2026/02/22 03:03:15 UTC

(shardingsphere) branch master updated: Add more test cases on MySQLSystemDatabaseTest (#38129)

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 339b8aad3c1 Add more test cases on MySQLSystemDatabaseTest (#38129)
339b8aad3c1 is described below

commit 339b8aad3c103e7ec79550397762d441b7a941e2
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Sun Feb 22 11:03:09 2026 +0800

    Add more test cases on MySQLSystemDatabaseTest (#38129)
---
 .../database/system/MySQLSystemDatabaseTest.java   | 26 +++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)

diff --git a/database/connector/dialect/mysql/src/test/java/org/apache/shardingsphere/database/connector/mysql/metadata/database/system/MySQLSystemDatabaseTest.java b/database/connector/dialect/mysql/src/test/java/org/apache/shardingsphere/database/connector/mysql/metadata/database/system/MySQLSystemDatabaseTest.java
index 8cbf9b2fe6d..e414884a969 100644
--- a/database/connector/dialect/mysql/src/test/java/org/apache/shardingsphere/database/connector/mysql/metadata/database/system/MySQLSystemDatabaseTest.java
+++ b/database/connector/dialect/mysql/src/test/java/org/apache/shardingsphere/database/connector/mysql/metadata/database/system/MySQLSystemDatabaseTest.java
@@ -22,17 +22,41 @@ import org.apache.shardingsphere.database.connector.core.spi.DatabaseTypedSPILoa
 import org.apache.shardingsphere.database.connector.core.type.DatabaseType;
 import org.apache.shardingsphere.infra.spi.type.typed.TypedSPILoader;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
 
 import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
 import java.util.LinkedHashSet;
+import java.util.stream.Stream;
 
-import static org.hamcrest.Matchers.is;
 import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.is;
 
 class MySQLSystemDatabaseTest {
     
     private final DialectSystemDatabase systemDatabase = DatabaseTypedSPILoader.getService(DialectSystemDatabase.class, TypedSPILoader.getService(DatabaseType.class, "MySQL"));
     
+    @Test
+    void assertGetSystemDatabases() {
+        assertThat(systemDatabase.getSystemDatabases(), is(new LinkedHashSet<>(Arrays.asList("information_schema", "performance_schema", "mysql", "sys", "shardingsphere"))));
+    }
+    
+    @ParameterizedTest(name = "{0}")
+    @MethodSource("getSystemSchemasByDatabaseNameArguments")
+    void assertGetSystemSchemasByDatabaseName(final String name, final String databaseName, final Collection<String> expected) {
+        assertThat(systemDatabase.getSystemSchemas(databaseName), is(expected));
+    }
+    
+    private static Stream<Arguments> getSystemSchemasByDatabaseNameArguments() {
+        return Stream.of(
+                Arguments.of("information schema database", "information_schema", Collections.singleton("information_schema")),
+                Arguments.of("mysql database", "mysql", Collections.singleton("mysql")),
+                Arguments.of("unknown database", "unknown_database", Collections.emptyList()));
+    }
+    
     @Test
     void assertGetSystemSchemas() {
         assertThat(systemDatabase.getSystemSchemas(), is(new LinkedHashSet<>(Arrays.asList("information_schema", "performance_schema", "mysql", "sys", "shardingsphere"))));