You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "riteshghorse (via GitHub)" <gi...@apache.org> on 2023/08/21 15:26:45 UTC
[GitHub] [beam] riteshghorse opened a new pull request, #28077: [Python] Fix python's Beam Programming Guide text block for ParDo
riteshghorse opened a new pull request, #28077:
URL: https://github.com/apache/beam/pull/28077
Changed the text description for Python's ParDo block to match the code.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on a diff in pull request #28077: [Python] Fix python's Beam Programming Guide text block for ParDo
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on code in PR #28077:
URL: https://github.com/apache/beam/pull/28077#discussion_r1300362477
##########
website/www/site/content/en/documentation/programming-guide.md:
##########
@@ -834,12 +834,18 @@ func init() {
##### 4.2.1.1. Applying ParDo {#applying-pardo}
-{{< paragraph class="language-java language-py" >}}
+{{< paragraph class="language-java">}}
Like all Beam transforms, you apply `ParDo` by calling the `apply` method on the
input `PCollection` and passing `ParDo` as an argument, as shown in the
following example code:
{{< /paragraph >}}
+{{< paragraph class="language-py">}}
+Like all Beam transforms, you apply `ParDo` by calling the `beam.ParDo` method on the
Review Comment:
```suggestion
Like all Beam transforms, you apply `ParDo` by calling the `beam.ParDo` instance on the
```
or class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on a diff in pull request #28077: [Python] Fix python's Beam Programming Guide text block for ParDo
Posted by "riteshghorse (via GitHub)" <gi...@apache.org>.
riteshghorse commented on code in PR #28077:
URL: https://github.com/apache/beam/pull/28077#discussion_r1300383571
##########
website/www/site/content/en/documentation/programming-guide.md:
##########
@@ -834,12 +834,18 @@ func init() {
##### 4.2.1.1. Applying ParDo {#applying-pardo}
-{{< paragraph class="language-java language-py" >}}
+{{< paragraph class="language-java">}}
Like all Beam transforms, you apply `ParDo` by calling the `apply` method on the
input `PCollection` and passing `ParDo` as an argument, as shown in the
following example code:
{{< /paragraph >}}
+{{< paragraph class="language-py">}}
+Like all Beam transforms, you apply `ParDo` by calling the `beam.ParDo` method on the
Review Comment:
actually just `beam.ParDo` looks good
##########
website/www/site/content/en/documentation/programming-guide.md:
##########
@@ -834,12 +834,18 @@ func init() {
##### 4.2.1.1. Applying ParDo {#applying-pardo}
-{{< paragraph class="language-java language-py" >}}
+{{< paragraph class="language-java">}}
Like all Beam transforms, you apply `ParDo` by calling the `apply` method on the
input `PCollection` and passing `ParDo` as an argument, as shown in the
following example code:
{{< /paragraph >}}
+{{< paragraph class="language-py">}}
+Like all Beam transforms, you apply `ParDo` by calling the `beam.ParDo` method on the
Review Comment:
actually just `beam.ParDo` looks good, updated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #28077: [Python] Fix python's Beam Programming Guide text block for ParDo
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28077:
URL: https://github.com/apache/beam/pull/28077#issuecomment-1686611315
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse merged pull request #28077: [Python] Fix python's Beam Programming Guide text block for ParDo
Posted by "riteshghorse (via GitHub)" <gi...@apache.org>.
riteshghorse merged PR #28077:
URL: https://github.com/apache/beam/pull/28077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #28077: [Python] Fix python's Beam Programming Guide text block for ParDo
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28077:
URL: https://github.com/apache/beam/pull/28077#issuecomment-1686659261
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @chamikaramj added as fallback since no labels match configuration
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org