You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/22 12:14:02 UTC

[GitHub] [iotdb] cornmonster commented on a change in pull request #5317: [IOTDB-2727] async memory reservation

cornmonster commented on a change in pull request #5317:
URL: https://github.com/apache/iotdb/pull/5317#discussion_r832101524



##########
File path: server/src/main/java/org/apache/iotdb/db/mpp/memory/MemoryPool.java
##########
@@ -79,8 +142,37 @@ public synchronized void free(String queryId, long bytes) {
     } else {
       queryMemoryReservations.put(queryId, queryReservedBytes);
     }
-
     reservedBytes -= bytes;
+
+    List<MemoryReservationFuture<Void>> futures =

Review comment:
       Make sense. Will fix it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org