You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "deathstrokedarksky (via GitHub)" <gi...@apache.org> on 2024/10/15 09:32:38 UTC
[PR] Set proper amount of steps to avoid confusing logs while examples [superset]
deathstrokedarksky opened a new pull request, #30606:
URL: https://github.com/apache/superset/pull/30606
### Summary
This pull request addresses an issue with the logging behavior in the `docker/docker-init.sh` script when loading examples in Apache Superset. The change ensures that the number of steps logged during the initialization process reflects whether example data should be loaded, thus preventing confusion in the logs. It was actually confusing in my case when I first ran superset in docker in different modes.
### Changes Made
- Modified the `STEP_CNT` variable initialization logic in the `docker/docker-init.sh` script.
- Added a conditional check to set `STEP_CNT` properly.
### Testing Instructions
1. Verify that the environment variable `SUPSET_LOAD_EXAMPLES` can be set to either `"yes"` or `"no"`.
2. Deploy the superset environment in different modes and observe the logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Set correct amount of steps to avoid confusing logs while loading examples [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #30606:
URL: https://github.com/apache/superset/pull/30606#issuecomment-2414664028
Thank you @deathstrokedarksky!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Set correct amount of steps to avoid confusing logs while loading examples [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #30606:
URL: https://github.com/apache/superset/pull/30606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org