[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #137: some pekko naming issues

["jrudolph (via GitHub)" <gi...@apache.org>]

jrudolph commented on code in PR #137:
URL: https://github.com/apache/incubator-pekko-http/pull/137#discussion_r1169750138


##########
build.sbt:
##########
@@ -405,11 +405,11 @@ lazy val docs = project("docs")
       "scaladoc.org.apache.pekko.base_url" -> s"https://pekko.apache.org/api/pekko/${PekkoDependency.docs.link}",
       "scaladoc.org.apache.pekko.link_style" -> "direct",
       "javadoc.org.apache.pekko.http.base_url" -> {
-        val v = if (!isSnapshot.value) "current" else version.value
+        val v = if (isSnapshot.value) "current" else version.value

Review Comment:
   Did we discuss changing the naming/URL scheme somewhere? The rationale behind the existing scheme is to have a single URL `/current` (in addition to the versioned ones) which will always point to the latest version of the documentation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org