You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "zzhpro (via GitHub)" <gi...@apache.org> on 2024/08/21 11:20:40 UTC
[PR] feat: support loading hudi global configs [hudi-rs]
zzhpro opened a new pull request, #118:
URL: https://github.com/apache/hudi-rs/pull/118
## Description
Load hudi-defaults.conf when creating table intances , for #111 .
I worked on this issue last weekend and didn't ask for assignment. Since now #111 has been assigned, I'll provide this PR just as a backup.
## How are the changes test-covered
- [x] Automated tests: I have added a unit test for this feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: support loading hudi global configs [hudi-rs]
Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan commented on PR #118:
URL: https://github.com/apache/hudi-rs/pull/118#issuecomment-2339820352
@zzhpro thanks. i've made some refactoring based on your version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: support loading hudi global configs [hudi-rs]
Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan merged PR #118:
URL: https://github.com/apache/hudi-rs/pull/118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: support loading hudi global configs [hudi-rs]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #118:
URL: https://github.com/apache/hudi-rs/pull/118#issuecomment-2318516590
## [Codecov](https://app.codecov.io/gh/apache/hudi-rs/pull/118?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `88.88889%` with `4 lines` in your changes missing coverage. Please review.
> Project coverage is 87.41%. Comparing base [(`3359e10`)](https://app.codecov.io/gh/apache/hudi-rs/commit/3359e108b8806c50c008072ef6afbcca86b2e4da?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`26c5bc9`)](https://app.codecov.io/gh/apache/hudi-rs/commit/26c5bc925444278da410ca7748208c03e3e13d6e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 2 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi-rs/pull/118?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [crates/core/src/table/mod.rs](https://app.codecov.io/gh/apache/hudi-rs/pull/118?src=pr&el=tree&filepath=crates%2Fcore%2Fsrc%2Ftable%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y3JhdGVzL2NvcmUvc3JjL3RhYmxlL21vZC5ycw==) | 89.28% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi-rs/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [crates/core/src/storage/mod.rs](https://app.codecov.io/gh/apache/hudi-rs/pull/118?src=pr&el=tree&filepath=crates%2Fcore%2Fsrc%2Fstorage%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y3JhdGVzL2NvcmUvc3JjL3N0b3JhZ2UvbW9kLnJz) | 87.50% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi-rs/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #118 +/- ##
==========================================
- Coverage 87.42% 87.41% -0.02%
==========================================
Files 14 14
Lines 700 723 +23
==========================================
+ Hits 612 632 +20
- Misses 88 91 +3
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/hudi-rs/pull/118?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org