You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/09/17 15:57:58 UTC
[GitHub] [incubator-eventmesh] JunjieChou opened a new pull request #525: [ISSUE #339] Add a skeleton for separated openschema registry service and implement most APIs that doesn't need compatibility check.
JunjieChou opened a new pull request #525:
URL: https://github.com/apache/incubator-eventmesh/pull/525
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes ISSUE#<XXX>`.)
-->
Fixes ISSUE #339
### Motivation
This pr aims at provides a skeleton for separated openschema registry service.
There are several further works to do, commented as todo.
### Modifications
create a new module named eventmesh-openschema
### Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? not documented
- If a feature is not applicable for documentation, explain why?
following commits will add up javadoc
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] JunjieChou commented on a change in pull request #525: [ISSUE #339] Add a skeleton for separated openschema registry service and implement most APIs that doesn't need compatibility check.
Posted by GitBox <gi...@apache.org>.
JunjieChou commented on a change in pull request #525:
URL: https://github.com/apache/incubator-eventmesh/pull/525#discussion_r713127524
##########
File path: eventmesh-openschema/eventmesh-openschema-registry/build.gradle
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+plugins {
+ id 'org.springframework.boot' version '2.5.4'
+ id 'io.spring.dependency-management'
+ id 'java'
+}
+
+group 'org.apache.eventmesh'
+version '1.2.0-SNAPSHOT'
+
+configurations {
+ compileOnly {
+ extendsFrom annotationProcessor
+ }
+}
+
+repositories {
+ mavenCentral()
+}
+
+dependencies {
+ implementation 'org.springframework.boot:spring-boot-starter-data-jdbc'
+ implementation 'org.springframework.boot:spring-boot-starter-data-jpa'
+ implementation 'org.springframework.boot:spring-boot-starter-jdbc'
+ implementation 'org.springframework.boot:spring-boot-starter-web'
+ implementation 'org.springframework:spring-beans:5.1.8.RELEASE'
+ implementation 'org.mybatis.spring.boot:mybatis-spring-boot-starter:2.2.0'
Review comment:
I was not familiar with the difference between JPA and mybatis. So I compared both of them and choose JPA due to its automatic generation of many query languages.
Next, I will try to modify the JPA part to mybatis since mybatis seems proposed and better maintainable by the community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] JunjieChou commented on pull request #525: [ISSUE #339] Add a skeleton for separated openschema registry service and implement most APIs that doesn't need compatibility check.
Posted by GitBox <gi...@apache.org>.
JunjieChou commented on pull request #525:
URL: https://github.com/apache/incubator-eventmesh/pull/525#issuecomment-922211699
> @JunjieChou please fix these files headers and fix the build error
> 
Sure, I've added licenses to those files, but encountering another problem.
Do you have any idea what that problem may be?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 merged pull request #525: [ISSUE #339] Add a skeleton for separated openschema registry service and implement most APIs that doesn't need compatibility check.
Posted by GitBox <gi...@apache.org>.
xwm1992 merged pull request #525:
URL: https://github.com/apache/incubator-eventmesh/pull/525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov-commenter commented on pull request #525: [ISSUE #339] Add a skeleton for separated openschema registry service and implement most APIs that doesn't need compatibility check.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #525:
URL: https://github.com/apache/incubator-eventmesh/pull/525#issuecomment-924614328
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/525?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#525](https://codecov.io/gh/apache/incubator-eventmesh/pull/525?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cd0f961) into [develop](https://codecov.io/gh/apache/incubator-eventmesh/commit/f12bf523ed9909015b0be0941040a56ca01759d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f12bf52) will **increase** coverage by `0.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-eventmesh/pull/525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #525 +/- ##
=============================================
+ Coverage 10.68% 10.76% +0.07%
- Complexity 349 353 +4
=============================================
Files 253 253
Lines 12099 12099
Branches 1028 1028
=============================================
+ Hits 1293 1302 +9
+ Misses 10697 10687 -10
- Partials 109 110 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...mesh/connector/standalone/broker/MessageQueue.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/525/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL01lc3NhZ2VRdWV1ZS5qYXZh) | `40.25% <0.00%> (+7.79%)` | :arrow_up: |
| [...tandalone/broker/task/HistoryMessageClearTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/525/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svSGlzdG9yeU1lc3NhZ2VDbGVhclRhc2suamF2YQ==) | `50.00% <0.00%> (+16.66%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/525?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/525?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f12bf52...cd0f961](https://codecov.io/gh/apache/incubator-eventmesh/pull/525?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on pull request #525: [ISSUE #339] Add a skeleton for separated openschema registry service and implement most APIs that doesn't need compatibility check.
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on pull request #525:
URL: https://github.com/apache/incubator-eventmesh/pull/525#issuecomment-922167086
@JunjieChou please fix these files headers and fix the build error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on pull request #525: [ISSUE #339] Add a skeleton for separated openschema registry service and implement most APIs that doesn't need compatibility check.
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #525:
URL: https://github.com/apache/incubator-eventmesh/pull/525#issuecomment-922162874
@JunjieChou Good job, this is a big feature.
To make the all comminity user to track this feature easier, suggest updating the progress in the [design doc](https://github.com/apache/incubator-eventmesh/blob/develop/docs/en/features/eventmesh-schemaregistry-design.md) like [FLIP](https://cwiki.apache.org/confluence/display/FLINK/Flink+Improvement+Proposals)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] yzhao244 commented on pull request #525: [ISSUE #339] Add a skeleton for separated openschema registry service and implement most APIs that doesn't need compatibility check.
Posted by GitBox <gi...@apache.org>.
yzhao244 commented on pull request #525:
URL: https://github.com/apache/incubator-eventmesh/pull/525#issuecomment-924299899
@JunjieChou Good work and thx for your contribution. :) . After this PR got merged, maybe I can help with compatibility check. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #525: [ISSUE #339] Add a skeleton for separated openschema registry service and implement most APIs that doesn't need compatibility check.
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #525:
URL: https://github.com/apache/incubator-eventmesh/pull/525#discussion_r711522066
##########
File path: eventmesh-openschema/eventmesh-openschema-registry/build.gradle
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+plugins {
+ id 'org.springframework.boot' version '2.5.4'
+ id 'io.spring.dependency-management'
+ id 'java'
+}
+
+group 'org.apache.eventmesh'
+version '1.2.0-SNAPSHOT'
+
+configurations {
+ compileOnly {
+ extendsFrom annotationProcessor
+ }
+}
+
+repositories {
+ mavenCentral()
+}
+
+dependencies {
+ implementation 'org.springframework.boot:spring-boot-starter-data-jdbc'
+ implementation 'org.springframework.boot:spring-boot-starter-data-jpa'
+ implementation 'org.springframework.boot:spring-boot-starter-jdbc'
+ implementation 'org.springframework.boot:spring-boot-starter-web'
+ implementation 'org.springframework:spring-beans:5.1.8.RELEASE'
+ implementation 'org.mybatis.spring.boot:mybatis-spring-boot-starter:2.2.0'
Review comment:
Why did you choose to add both jpa and mybatis? It seems you can just choose one of them.
I prefer mybatis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] JunjieChou commented on pull request #525: [ISSUE #339] Add a skeleton for separated openschema registry service and implement most APIs that doesn't need compatibility check.
Posted by GitBox <gi...@apache.org>.
JunjieChou commented on pull request #525:
URL: https://github.com/apache/incubator-eventmesh/pull/525#issuecomment-922173447
> @JunjieChou Good job, this is a big feature.
> To make the all comminity user to track this feature easier, suggest updating the progress in the [design doc](https://github.com/apache/incubator-eventmesh/blob/develop/docs/en/features/eventmesh-schemaregistry-design.md) like [FLIP](https://cwiki.apache.org/confluence/display/FLINK/Flink+Improvement+Proposals)
OK, I have a local development progress doc by myself. I'll update it later on [design doc](https://github.com/apache/incubator-eventmesh/blob/develop/docs/en/features/eventmesh-schemaregistry-design.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] yzhao244 commented on a change in pull request #525: [ISSUE #339] Add a skeleton for separated openschema registry service and implement most APIs that doesn't need compatibility check.
Posted by GitBox <gi...@apache.org>.
yzhao244 commented on a change in pull request #525:
URL: https://github.com/apache/incubator-eventmesh/pull/525#discussion_r713337990
##########
File path: eventmesh-openschema/eventmesh-openschema-registry/build.gradle
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+plugins {
+ id 'org.springframework.boot' version '2.5.4'
+ id 'io.spring.dependency-management'
+ id 'java'
+}
+
+group 'org.apache.eventmesh'
+version '1.2.0-SNAPSHOT'
+
+configurations {
+ compileOnly {
+ extendsFrom annotationProcessor
+ }
+}
+
+repositories {
+ mavenCentral()
+}
+
+dependencies {
+ implementation 'org.springframework.boot:spring-boot-starter-data-jdbc'
+ implementation 'org.springframework.boot:spring-boot-starter-data-jpa'
+ implementation 'org.springframework.boot:spring-boot-starter-jdbc'
+ implementation 'org.springframework.boot:spring-boot-starter-web'
+ implementation 'org.springframework:spring-beans:5.1.8.RELEASE'
+ implementation 'org.mybatis.spring.boot:mybatis-spring-boot-starter:2.2.0'
Review comment:
> Use JPA is OK, you can remove the `mybatis`.
Ya, Using Spring JPA should be fine. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] JunjieChou commented on pull request #525: [ISSUE #339] Add a skeleton for separated openschema registry service and implement most APIs that doesn't need compatibility check.
Posted by GitBox <gi...@apache.org>.
JunjieChou commented on pull request #525:
URL: https://github.com/apache/incubator-eventmesh/pull/525#issuecomment-924617509
> @JunjieChou Good work and thx for your contribution. :) . After this PR got merged, maybe I can help with compatibility check. :)
Sure, thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #525: [ISSUE #339] Add a skeleton for separated openschema registry service and implement most APIs that doesn't need compatibility check.
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #525:
URL: https://github.com/apache/incubator-eventmesh/pull/525#discussion_r713166353
##########
File path: eventmesh-openschema/eventmesh-openschema-registry/build.gradle
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+plugins {
+ id 'org.springframework.boot' version '2.5.4'
+ id 'io.spring.dependency-management'
+ id 'java'
+}
+
+group 'org.apache.eventmesh'
+version '1.2.0-SNAPSHOT'
+
+configurations {
+ compileOnly {
+ extendsFrom annotationProcessor
+ }
+}
+
+repositories {
+ mavenCentral()
+}
+
+dependencies {
+ implementation 'org.springframework.boot:spring-boot-starter-data-jdbc'
+ implementation 'org.springframework.boot:spring-boot-starter-data-jpa'
+ implementation 'org.springframework.boot:spring-boot-starter-jdbc'
+ implementation 'org.springframework.boot:spring-boot-starter-web'
+ implementation 'org.springframework:spring-beans:5.1.8.RELEASE'
+ implementation 'org.mybatis.spring.boot:mybatis-spring-boot-starter:2.2.0'
Review comment:
Use JPA is OK, you can remove the `mybatis`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #525: [ISSUE #339] Add a skeleton for separated openschema registry service and implement most APIs that doesn't need compatibility check.
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #525:
URL: https://github.com/apache/incubator-eventmesh/pull/525#discussion_r711522066
##########
File path: eventmesh-openschema/eventmesh-openschema-registry/build.gradle
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+plugins {
+ id 'org.springframework.boot' version '2.5.4'
+ id 'io.spring.dependency-management'
+ id 'java'
+}
+
+group 'org.apache.eventmesh'
+version '1.2.0-SNAPSHOT'
+
+configurations {
+ compileOnly {
+ extendsFrom annotationProcessor
+ }
+}
+
+repositories {
+ mavenCentral()
+}
+
+dependencies {
+ implementation 'org.springframework.boot:spring-boot-starter-data-jdbc'
+ implementation 'org.springframework.boot:spring-boot-starter-data-jpa'
+ implementation 'org.springframework.boot:spring-boot-starter-jdbc'
+ implementation 'org.springframework.boot:spring-boot-starter-web'
+ implementation 'org.springframework:spring-beans:5.1.8.RELEASE'
+ implementation 'org.mybatis.spring.boot:mybatis-spring-boot-starter:2.2.0'
Review comment:
Why did you choose to add both jpa and mybatis? It seems you can just choose one of them.
I prefer mybatis.
And don't add unnecessary dependencies, it seems Jupiter is not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org