You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by Weixin-Xu <gi...@git.apache.org> on 2018/07/09 03:14:45 UTC
[GitHub] trafodion pull request #1633: [TRAFODION-2743] Windows ODBC LOB support
GitHub user Weixin-Xu opened a pull request:
https://github.com/apache/trafodion/pull/1633
[TRAFODION-2743] Windows ODBC LOB support
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Weixin-Xu/incubator-trafodion winlob
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1633.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1633
----
commit f70b19c1a1a2612c44718c428864d522b7fb473a
Author: Weixin-Xu <we...@...>
Date: 2018-05-21T08:31:33Z
Windows ODBC LOB support
----
---
[GitHub] trafodion pull request #1633: [TRAFODION-2743] Windows ODBC LOB support
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1633#discussion_r201728736
--- Diff: win-odbc64/odbcclient/drvr35/lob.cpp ---
@@ -54,8 +54,12 @@ namespace ODBC {
CStmt *pStatement = (CStmt *)hstmt;
IDL_long extractLen = length;
+ IDL_string lobHandleTemp = (IDL_string)malloc(lobHandleLen + 1);
--- End diff --
Is there a place where this string will be deleted? If not, is this a memory leak?
---
[GitHub] trafodion pull request #1633: [TRAFODION-2743] Windows ODBC LOB support
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1633#discussion_r201439488
--- Diff: win-odbc64/Common/TransportBase.h ---
@@ -134,6 +134,8 @@ enum SRVR_API {
SRVR_API_SQLFASTEXECDIRECT, //OK WMS
SRVR_API_SQLFASTFETCH_PERF, //OK WMS
SRVR_API_GETSEGMENTS, //OK WMS
+ SRVR_API_EXTRACTLOB, //OK LOB
+ SRVR_API_UPDATELOB, //OK LOB
--- End diff --
My guess is that the original code uses tabs (which is bad) and the tab setting in github assumes 8 spaces per tab. Consider changing your editor to use 8 spaces per tab.
---
[GitHub] trafodion pull request #1633: [TRAFODION-2743] Windows ODBC LOB support
Posted by Weixin-Xu <gi...@git.apache.org>.
Github user Weixin-Xu commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1633#discussion_r201193635
--- Diff: win-odbc64/Common/TransportBase.h ---
@@ -134,6 +134,8 @@ enum SRVR_API {
SRVR_API_SQLFASTEXECDIRECT, //OK WMS
SRVR_API_SQLFASTFETCH_PERF, //OK WMS
SRVR_API_GETSEGMENTS, //OK WMS
+ SRVR_API_EXTRACTLOB, //OK LOB
+ SRVR_API_UPDATELOB, //OK LOB
--- End diff --
The above use tab while I use 4 spaces instead of tab.
---
[GitHub] trafodion pull request #1633: [TRAFODION-2743] Windows ODBC LOB support
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1633#discussion_r201149361
--- Diff: win-odbc64/Common/TransportBase.h ---
@@ -134,6 +134,8 @@ enum SRVR_API {
SRVR_API_SQLFASTEXECDIRECT, //OK WMS
SRVR_API_SQLFASTFETCH_PERF, //OK WMS
SRVR_API_GETSEGMENTS, //OK WMS
+ SRVR_API_EXTRACTLOB, //OK LOB
+ SRVR_API_UPDATELOB, //OK LOB
--- End diff --
You may want to check the tab settings in your editor; the indentation seems to frequently be wrong. Best practice is to store spaces instead of tabs.
---
[GitHub] trafodion pull request #1633: [TRAFODION-2743] Windows ODBC LOB support
Posted by Weixin-Xu <gi...@git.apache.org>.
Github user Weixin-Xu commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1633#discussion_r201885630
--- Diff: win-odbc64/odbcclient/drvr35/lob.cpp ---
@@ -54,8 +54,12 @@ namespace ODBC {
CStmt *pStatement = (CStmt *)hstmt;
IDL_long extractLen = length;
+ IDL_string lobHandleTemp = (IDL_string)malloc(lobHandleLen + 1);
--- End diff --
Thank you for your reminder
---
[GitHub] trafodion pull request #1633: [TRAFODION-2743] Windows ODBC LOB support
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafodion/pull/1633
---