You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/06/07 05:02:34 UTC

[GitHub] [incubator-nuttx] antmerlino commented on a change in pull request #3755: net/icmp: icmp bug fix and enhancement

antmerlino commented on a change in pull request #3755:
URL: https://github.com/apache/incubator-nuttx/pull/3755#discussion_r638831198



##########
File path: net/icmp/icmp_recvmsg.c
##########
@@ -181,7 +181,8 @@ static uint16_t recvfrom_eventhandler(FAR struct net_driver_s *dev,
 
           /* Indicate that the data has been consumed */
 
-          flags &= ~ICMP_NEWDATA;
+          flags     &= ~ICMP_NEWDATA;
+          dev->d_len = 0;

Review comment:
       @anchao Can you explain how not setting d_len=0 caused packet duplication? Is this only required for ICMP or should the change be propageted to other network protocols?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org