You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/04/24 17:10:15 UTC
[GitHub] [thrift] pacejackson opened a new pull request #2119: THRIFT-5164: add middleware framework for Go servers
pacejackson opened a new pull request #2119:
URL: https://github.com/apache/thrift/pull/2119
<!-- Explain the changes in the pull request below: -->
Client: go
This PR adds a simple middleware framework for Go servers.
It provides:
1. A `ProcessorMiddleware` function interface used to define the actual middleware
2. `WrapProcessor`, the function that you use to wrap a `TProcessor` in a list of middleware
3. A helper `WrappedTProcessorFunction` struct to help with developing middleware.
This is may be breaking change for any custom implementations of the `TProcessor` interface, but should not effect the code generated by compiling Thrift files. It adds two functions to the interface that are a part of the generated `TProcessor` code, but were not defined in the interface explicitly.
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but preferred)
- [ ] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, add ` [skip ci]` at the end of your pull request to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] fishy commented on pull request #2119: THRIFT-5164: add middleware framework for Go servers
Posted by GitBox <gi...@apache.org>.
fishy commented on pull request #2119:
URL: https://github.com/apache/thrift/pull/2119#issuecomment-619647145
Failing tests are fixed. The CI failure seems to be gradle related.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] pacejackson commented on pull request #2119: THRIFT-5164: add middleware framework for Go servers
Posted by GitBox <gi...@apache.org>.
pacejackson commented on pull request #2119:
URL: https://github.com/apache/thrift/pull/2119#issuecomment-620115399
Updated :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] dcelasun commented on pull request #2119: THRIFT-5164: add middleware framework for Go servers
Posted by GitBox <gi...@apache.org>.
dcelasun commented on pull request #2119:
URL: https://github.com/apache/thrift/pull/2119#issuecomment-620157935
Merged, thanks for the PR @pacejackson!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] dcelasun commented on pull request #2119: THRIFT-5164: add middleware framework for Go servers
Posted by GitBox <gi...@apache.org>.
dcelasun commented on pull request #2119:
URL: https://github.com/apache/thrift/pull/2119#issuecomment-619146495
@fishy @pacejackson thanks for the PR, I've been looking forward to this!
I'll play around with this locally tomorrow and we'll take it from there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] dcelasun commented on pull request #2119: THRIFT-5164: add middleware framework for Go servers
Posted by GitBox <gi...@apache.org>.
dcelasun commented on pull request #2119:
URL: https://github.com/apache/thrift/pull/2119#issuecomment-619266798
Tests are [failing](https://api.travis-ci.org/v3/job/679128191/log.txt).
```
gopath/src/tests/multiplexed_protocol_test.go:72:35: cannot use processor (type *thrift.TMultiplexedProcessor) as type thrift.TProcessor in argument to thrift.NewTSimpleServer4:
*thrift.TMultiplexedProcessor does not implement thrift.TProcessor (missing AddToProcessorMap method)
gopath/src/tests/multiplexed_protocol_test.go:111:35: cannot use processor (type *thrift.TMultiplexedProcessor) as type thrift.TProcessor in argument to thrift.NewTSimpleServer4:
*thrift.TMultiplexedProcessor does not implement thrift.TProcessor (missing AddToProcessorMap method)
gopath/src/tests/multiplexed_protocol_test.go:150:35: cannot use processor (type *thrift.TMultiplexedProcessor) as type thrift.TProcessor in argument to thrift.NewTSimpleServer4:
*thrift.TMultiplexedProcessor does not implement thrift.TProcessor (missing AddToProcessorMap method)
ok thrift 0.106s
FAIL tests [build failed]
ok dontexportrwtest 0.004s
FAIL
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] fishy commented on pull request #2119: THRIFT-5164: add middleware framework for Go servers
Posted by GitBox <gi...@apache.org>.
fishy commented on pull request #2119:
URL: https://github.com/apache/thrift/pull/2119#issuecomment-619143377
@dcelasun :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] dcelasun commented on pull request #2119: THRIFT-5164: add middleware framework for Go servers
Posted by GitBox <gi...@apache.org>.
dcelasun commented on pull request #2119:
URL: https://github.com/apache/thrift/pull/2119#issuecomment-619813948
All right tests are green, I've managed to play around with it locally and everything looks good.
One small thing: Since this is a breaking change for `TProcessor`, please mention it in [CHANGES.md](https://github.com/apache/thrift/blob/master/CHANGES.md#breaking-changes).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org